Skip to content

fix: gemma-2 tokenizer #993

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
akoumpa wants to merge 10 commits into
base: main
Choose a base branch
from
Open

fix: gemma-2 tokenizer #993

akoumpa wants to merge 10 commits into from
+183 −53

Conversation

@akoumpa
Copy link
Contributor

@akoumpa akoumpa commented Dec 19, 2025 •
edited
Loading

What does this PR do ?

Changes:

  • Fix gemma-2 (drop system message)
  • make NeMoAutoTokenizer a subclass of AutoTokenizer
  • add test

Changelog

  • Add specific line by line info of high level changes in this PR.

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you add or update any necessary documentation?

If you haven't finished some of the above items you can still open "Draft" PR.

Additional Information

  • Related to # (issue)

@copy-pr-bot
Copy link

copy-pr-bot bot commented Dec 19, 2025

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@akoumpa akoumpa changed the title fix: gemma-2 tokenizer (drop system message); make NeMoAutoTokenizer a subclass … fix: gemma-2 tokenizer Dec 19, 2025
@akoumpa
Copy link
Contributor Author

akoumpa commented Dec 19, 2025

/ok to test 7c2319f

@akoumpa
Copy link
Contributor Author

akoumpa commented Dec 19, 2025

/ok to test 8796b47

@akoumpa
Copy link
Contributor Author

akoumpa commented Dec 19, 2025

/ok to test ebd8056

@thomasdhc
Update codecov
b743beb 
Signed-off-by: Dong Hyuk Chang <[email protected]>
@thomasdhc thomasdhc requested a review from a team as a code owner January 7, 2026 15:33
@thomasdhc
Copy link
Contributor

thomasdhc commented Jan 7, 2026

/ok to test b743beb

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@HuiyingLi HuiyingLi Awaiting requested review from HuiyingLi HuiyingLi is a code owner

@adil-a adil-a Awaiting requested review from adil-a adil-a is a code owner

@hemildesai hemildesai Awaiting requested review from hemildesai hemildesai is a code owner

@ybabakhin ybabakhin Awaiting requested review from ybabakhin ybabakhin is a code owner

@shan-nvidia shan-nvidia Awaiting requested review from shan-nvidia shan-nvidia is a code owner

@rnyak rnyak Awaiting requested review from rnyak rnyak is a code owner

@oliverholworthy oliverholworthy Awaiting requested review from oliverholworthy oliverholworthy is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@akoumpa @HuiyingLi @thomasdhc