Skip to content

Commit aaf6330

Browse files
thomasdhcthomasdhc
authored
ci: Skip video cuda12 and pip for extra all (#1338)
* Skip video cuda12 and pip for extra all Signed-off-by: Dong Hyuk Chang <[email protected]> * Remove optional name and update matrix Signed-off-by: Dong Hyuk Chang <[email protected]> * Skip py3.10 all install Signed-off-by: Dong Hyuk Chang <[email protected]> * Skip all-install-only-test Signed-off-by: Dong Hyuk Chang <[email protected]> * Comment out echo Signed-off-by: Dong Hyuk Chang <[email protected]> --------- Signed-off-by: Dong Hyuk Chang <[email protected]>
1 parent 1fd3528 commit aaf6330

File tree

1 file changed

+87
-87
lines changed

1 file changed

+87
-87
lines changed

‎.github/workflows/install-test.yml‎

Lines changed: 87 additions & 87 deletions
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,7 @@ jobs:
4848

4949
- name: Get PR info
5050
id: get-pr-info
51-
if: startsWith(github.ref, 'refs/heads/pull-request/')
51+
if: github.event_name == 'push' && startsWith(github.ref, 'refs/heads/pull-request/')
5252
uses: nv-gha-runners/get-pr-info@main
5353

5454
- name: Determine base reference
@@ -215,7 +215,7 @@ jobs:
215215
retention-days: 1
216216

217217
# ============================================================================
218-
# GPU Extras - Install Only (pip=OPTIONAL, uv=Required)
218+
# GPU Extras - Install Only (pip=required, uv=Required)
219219
# ============================================================================
220220
gpu-install-test:
221221
needs: [pre-flight]
@@ -227,7 +227,7 @@ jobs:
227227
fail-fast: false
228228
matrix:
229229
installer: [pip, uv]
230-
name: "${{ matrix.installer == 'pip' && 'OPTIONAL: ' || '' }}GPU Extras Individual - Install Only (${{ matrix.installer }}) - Py3.12"
230+
name: "GPU Extras Individual - Install Only (${{ matrix.installer }}) - Py3.12"
231231
steps:
232232
- name: Install dependencies for setup-python
233233
run: apt-get update && apt-get install -y --no-install-recommends git curl
@@ -253,7 +253,7 @@ jobs:
253253
run: |
254254
set -o pipefail
255255
INSTALLER="${{ matrix.installer }}"
256-
GPU_EXTRAS=("cuda12" "deduplication_cuda12" "audio_cuda12" "image_cuda12" "text_cuda12" "video_cuda12")
256+
GPU_EXTRAS=("cuda12" "deduplication_cuda12" "audio_cuda12" "image_cuda12" "text_cuda12")
257257
RESULTS=""
258258
FAILED=0
259259
@@ -339,87 +339,87 @@ jobs:
339339
# ============================================================================
340340
# ALL Extras - Install Only (CPU Runner)
341341
# ============================================================================
342-
all-install-only-test:
343-
needs: [pre-flight]
344-
if: needs.pre-flight.outputs.docs_only != 'true'
345-
runs-on: linux-amd64-cpu16
346-
container:
347-
image: ${{ needs.pre-flight.outputs.cuda_base_image }}
348-
name: "${{ matrix.installer == 'pip' && 'OPTIONAL: ' || '' }}ALL Extras - Install Only (${{ matrix.installer }}) - Py${{ matrix.python-version }}"
349-
strategy:
350-
fail-fast: false
351-
matrix:
352-
installer: [pip, uv]
353-
python-version: ["3.12", "3.10"]
354-
exclude:
355-
- installer: uv
356-
python-version: "3.12" # This combo runs on GPU with import checks
357-
steps:
358-
- name: Install dependencies for setup-python
359-
run: apt-get update && apt-get install -y --no-install-recommends git curl
360-
361-
- uses: actions/checkout@v4
362-
with:
363-
submodules: recursive
364-
365-
- uses: actions/setup-python@v5
366-
with:
367-
python-version: "${{ matrix.python-version }}"
368-
369-
- name: Setup uv
370-
if: matrix.installer == 'uv'
371-
uses: astral-sh/setup-uv@v6
372-
with:
373-
python-version: "${{ matrix.python-version }}"
374-
enable-cache: false
375-
376-
- name: Install ALL extras (${{ matrix.installer }})
377-
id: install
378-
shell: bash
379-
run: |
380-
set -o pipefail
381-
echo "🚀 Installing ALL extras (${{ matrix.installer }}, Py${{ matrix.python-version }})"
382-
383-
if [ "${{ matrix.installer }}" = "pip" ]; then
384-
if pip install --no-cache-dir ".[all]" 2>&1 | tee install.log; then
385-
echo "install_status=success" >> $GITHUB_OUTPUT
386-
echo "✅ INSTALL SUCCESS"
387-
else
388-
echo "install_status=failure" >> $GITHUB_OUTPUT
389-
echo "❌ INSTALL FAILED"
390-
grep -E "(ERROR|error:|failed|conflict)" install.log | head -20 || true
391-
fi
392-
else
393-
export PATH="/root/.local/bin:$PATH"
394-
if uv sync --locked --link-mode copy --extra all 2>&1 | tee install.log; then
395-
echo "install_status=success" >> $GITHUB_OUTPUT
396-
echo "✅ INSTALL SUCCESS"
397-
else
398-
echo "install_status=failure" >> $GITHUB_OUTPUT
399-
echo "❌ INSTALL FAILED"
400-
grep -E "(error:|Error:|failed)" install.log | head -20 || true
401-
fi
402-
fi
403-
env:
404-
UV_HTTP_TIMEOUT: 300
405-
PIP_BREAK_SYSTEM_PACKAGES: 1
406-
407-
- name: Report
408-
if: always()
409-
run: |
410-
echo "📊 ALL Extras (${{ matrix.installer }}, Py${{ matrix.python-version }}) - Install Only"
411-
412-
if [ "${{ steps.install.outputs.install_status }}" = "success" ]; then
413-
echo "✅ Installation succeeded"
414-
else
415-
echo "❌ Installation failed (expected - known conflicts)"
416-
echo ""
417-
echo "Known conflicts that may cause this:"
418-
echo " - nemo_toolkit[asr] requires transformers<4.55 but vllm requires transformers>=4.55"
419-
echo " - flash-attn build requires packaging module"
420-
echo " - flash-attn build requires torch pre-installed (pip can't handle build-time deps)"
421-
exit 1
422-
fi
342+
# all-install-only-test:
343+
# needs: [pre-flight]
344+
# if: needs.pre-flight.outputs.docs_only != 'true'
345+
# runs-on: linux-amd64-cpu16
346+
# container:
347+
# image: ${{ needs.pre-flight.outputs.cuda_base_image }}
348+
# name: "ALL Extras - Install Only (${{ matrix.installer }}) - Py${{ matrix.python-version }}"
349+
# strategy:
350+
# fail-fast: false
351+
# matrix:
352+
# installer: [uv]
353+
# python-version: ["3.12", "3.10"]
354+
# exclude:
355+
# - installer: uv
356+
# python-version: "3.12" # This combo runs on GPU with import checks
357+
# steps:
358+
# - name: Install dependencies for setup-python
359+
# run: apt-get update && apt-get install -y --no-install-recommends git curl
360+
361+
# - uses: actions/checkout@v4
362+
# with:
363+
# submodules: recursive
364+
365+
# - uses: actions/setup-python@v5
366+
# with:
367+
# python-version: "${{ matrix.python-version }}"
368+
369+
# - name: Setup uv
370+
# if: matrix.installer == 'uv'
371+
# uses: astral-sh/setup-uv@v6
372+
# with:
373+
# python-version: "${{ matrix.python-version }}"
374+
# enable-cache: false
375+
376+
# - name: Install ALL extras (${{ matrix.installer }})
377+
# id: install
378+
# shell: bash
379+
# run: |
380+
# set -o pipefail
381+
# echo "🚀 Installing ALL extras (${{ matrix.installer }}, Py${{ matrix.python-version }})"
382+
383+
# if [ "${{ matrix.installer }}" = "pip" ]; then
384+
# if pip install --no-cache-dir ".[all]" 2>&1 | tee install.log; then
385+
# echo "install_status=success" >> $GITHUB_OUTPUT
386+
# echo "✅ INSTALL SUCCESS"
387+
# else
388+
# echo "install_status=failure" >> $GITHUB_OUTPUT
389+
# echo "❌ INSTALL FAILED"
390+
# grep -E "(ERROR|error:|failed|conflict)" install.log | head -20 || true
391+
# fi
392+
# else
393+
# export PATH="/root/.local/bin:$PATH"
394+
# if uv sync --locked --link-mode copy --extra all 2>&1 | tee install.log; then
395+
# echo "install_status=success" >> $GITHUB_OUTPUT
396+
# echo "✅ INSTALL SUCCESS"
397+
# else
398+
# echo "install_status=failure" >> $GITHUB_OUTPUT
399+
# echo "❌ INSTALL FAILED"
400+
# grep -E "(error:|Error:|failed)" install.log | head -20 || true
401+
# fi
402+
# fi
403+
# env:
404+
# UV_HTTP_TIMEOUT: 300
405+
# PIP_BREAK_SYSTEM_PACKAGES: 1
406+
407+
# - name: Report
408+
# if: always()
409+
# run: |
410+
# echo "📊 ALL Extras (${{ matrix.installer }}, Py${{ matrix.python-version }}) - Install Only"
411+
412+
# if [ "${{ steps.install.outputs.install_status }}" = "success" ]; then
413+
# echo "✅ Installation succeeded"
414+
# else
415+
# echo "❌ Installation failed (expected - known conflicts)"
416+
# echo ""
417+
# echo "Known conflicts that may cause this:"
418+
# echo " - nemo_toolkit[asr] requires transformers<4.55 but vllm requires transformers>=4.55"
419+
# echo " - flash-attn build requires packaging module"
420+
# echo " - flash-attn build requires torch pre-installed (pip can't handle build-time deps)"
421+
# exit 1
422+
# fi
423423

424424
# ============================================================================
425425
# ALL Extras - Install + Import (GPU Runner, uv Py3.12 only)
@@ -522,7 +522,7 @@ jobs:
522522
# ============================================================================
523523
install-test-summary:
524524
# Note: all jobs listed to access their .result status
525-
needs: [pre-flight, cpu-install-test, gpu-install-test, all-install-only-test, all-install-import-test]
525+
needs: [pre-flight, cpu-install-test, gpu-install-test, all-install-import-test]
526526
runs-on: ubuntu-latest
527527
if: ${{ always() && needs.pre-flight.outputs.docs_only != 'true' }}
528528
steps:
@@ -564,7 +564,7 @@ jobs:
564564
echo "## ALL Extras (Combined)"
565565
echo "| Job | Runner | Validation | Status |"
566566
echo "|-----|--------|------------|--------|"
567-
echo "| ALL (pip/uv, Py3.10/3.12) | CPU | Install Only | ${{ needs.all-install-only-test.result == 'success' && '✅' || '⚠️ (expected)' }} |"
567+
# echo "| ALL (pip/uv, Py3.10/3.12) | CPU | Install Only | ${{ needs.all-install-only-test.result == 'success' && '✅' || '⚠️ (expected)' }} |"
568568
echo "| ALL (uv, Py3.12) | **GPU** | **Install+Import** | ${{ needs.all-install-import-test.result == 'success' && '✅' || '❌' }} |"
569569
echo ""
570570

0 commit comments

Comments
 (0)