Skip to content

Commit 5dd2f8c

Browse files
committed
uncomment omega config overwrite.
Signed-off-by: Sajad Norouzi <snorouzi@nvidia.com>
1 parent 8c82f21 commit 5dd2f8c

File tree

1 file changed

+5
-7
lines changed

1 file changed

+5
-7
lines changed

examples/megatron/recipes/dit/pretrain_dit_model.py

Lines changed: 5 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -60,6 +60,7 @@
6060
from megatron.bridge.training.utils.omegaconf_utils import (
6161
apply_overrides,
6262
create_omegaconf_dict_config,
63+
parse_hydra_overrides,
6364
)
6465
from megatron.bridge.utils.common_utils import get_rank_safe
6566
from omegaconf import OmegaConf
@@ -158,13 +159,10 @@ def main() -> None:
158159
merged_omega_conf = OmegaConf.merge(merged_omega_conf, yaml_overrides_omega)
159160
logger.debug("YAML overrides merged successfully.")
160161

161-
# Apply command-line overrides using Hydra-style parsing
162-
# TODO: this is not working, need to fix it
163-
# if cli_overrides:
164-
# print("INSIDE OVERRIDE")
165-
# logger.debug(f"Applying Hydra-style command-line overrides: {cli_overrides}")
166-
# merged_omega_conf = parse_hydra_overrides(merged_omega_conf, cli_overrides)
167-
# logger.debug("Hydra-style command-line overrides applied successfully.")
162+
if cli_overrides:
163+
logger.debug(f"Applying Hydra-style command-line overrides: {cli_overrides}")
164+
merged_omega_conf = parse_hydra_overrides(merged_omega_conf, cli_overrides)
165+
logger.debug("Hydra-style command-line overrides applied successfully.")
168166

169167
# # Apply the final merged OmegaConf configuration back to the original ConfigContainer
170168
logger.debug("Applying final merged configuration back to Python ConfigContainer...")

0 commit comments

Comments
 (0)