Skip to content

Conversation

@pthombre
Copy link
Contributor

No description provided.

@copy-pr-bot
Copy link

copy-pr-bot bot commented Dec 30, 2025

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

Signed-off-by: Pranav Prashant Thombre <[email protected]>
Signed-off-by: Pranav Prashant Thombre <[email protected]>
@pthombre pthombre requested a review from akoumpa January 3, 2026 00:17
pthombre and others added 3 commits January 2, 2026 16:35
Signed-off-by: Pranav Prashant Thombre <[email protected]>
Signed-off-by: Pablo Garay <[email protected]>
Signed-off-by: Pablo Garay <[email protected]>
@pablo-garay pablo-garay force-pushed the pranav/hunyuan_support branch from 56f6f0f to aa475ee Compare January 3, 2026 21:49


@dataclass
class FlowMatchingContext:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this context limited to just flow matching? if i'm not missing something EDM pipeline requires the same set of attributes.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not specifically. But since I've implemented only flow matching thought to call it this.


return sigma, timesteps, sampling_method

def _sample_from_distribution(self, batch_size: int, device: torch.device) -> torch.Tensor:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shall we separate this out of flow matching pipeline? we can have time step scheduler classes.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I felt like the sampling process is an intrinsic part of the flow matching logic so included it here. But I would also be okay to move it out if the goal is to develop a more scheduler class.

@akoumpa
Copy link
Contributor

akoumpa commented Jan 6, 2026

/ok to test aa475ee

Copy link
Contributor

@huvunvidia huvunvidia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a comment. Thanks for the PR.



@dataclass
class FlowMatchingOutput:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This class doesn't seem to be used anywhere?

Signed-off-by: Pranav Prashant Thombre <[email protected]>
Signed-off-by: Pranav Prashant Thombre <[email protected]>
@pthombre pthombre marked this pull request as ready for review January 6, 2026 23:34
@pthombre pthombre requested a review from a team as a code owner January 6, 2026 23:34
@pthombre
Copy link
Contributor Author

pthombre commented Jan 6, 2026

/ok to test 33ea6fc

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants