Skip to content

Commit cde505b

Browse files
chtruong814chtruong814
authored
build: Update dependencies for 26.02 (#567)
Signed-off-by: Charlie Truong <chtruong@nvidia.com>
1 parent 125a636 commit cde505b

File tree

16 files changed

+1543
-2531
lines changed

16 files changed

+1543
-2531
lines changed

‎.github/actions/test-template/action.yml‎

Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -59,6 +59,12 @@ inputs:
5959
runner:
6060
description: "The GHA runner to use"
6161
required: true
62+
ngc-api-user:
63+
description: "NGC API User"
64+
required: false
65+
ngc-api-key:
66+
description: "NGC API Key"
67+
required: false
6268

6369
runs:
6470
using: "composite"
@@ -99,6 +105,14 @@ runs:
99105
path: cache-mount
100106
key: ${{ runner.os }}-uv-${{ hashFiles('**/uv.lock') }}
101107

108+
- name: Login to NGC
109+
if: ${{ inputs.ngc-api-user != '' && inputs.ngc-api-key != '' }}
110+
shell: bash
111+
run: |
112+
echo ::group::Use credentials
113+
echo ${{ inputs.ngc-api-key }} | docker login -u '${{ inputs.ngc-api-user }}' --password-stdin nvcr.io
114+
echo ::endgroup::
115+
102116
- name: Restore Docker cache mounts
103117
uses: reproducible-containers/buildkit-cache-dance@5b81f4d29dc8397a7d341dba3aeecc7ec54d6361
104118
with:

‎.github/workflows/build-test-publish-wheel.yml‎

Lines changed: 45 additions & 45 deletions
Original file line numberDiff line numberDiff line change
@@ -30,50 +30,50 @@ jobs:
3030
pre-flight:
3131
uses: NVIDIA-NeMo/FW-CI-templates/.github/workflows/_cicd_preflight.yml@v0.64.2
3232

33-
build-test-publish-wheel:
34-
needs: [pre-flight]
35-
if: |
36-
!(needs.pre-flight.outputs.docs_only == 'true'
37-
|| needs.pre-flight.outputs.is_deployment_workflow == 'true')
38-
uses: NVIDIA-NeMo/FW-CI-templates/.github/workflows/_build_test_publish_wheel.yml@v0.48.0
39-
with:
40-
dry-run: true
41-
python-package: nemo_export_deploy_common
42-
python-version: "3.10"
43-
packaging: uv
44-
no-publish: ${{ !(github.ref == 'refs/heads/main' || startsWith(github.ref, 'refs/heads/r')) }}
45-
skip-test-wheel: true
46-
custom-container: nvcr.io/nvidia/pytorch:25.05-py3
47-
no-build-isolation: true
48-
runner: linux-amd64-cpu16
49-
secrets:
50-
TWINE_USERNAME: ${{ secrets.TWINE_USERNAME }}
51-
TWINE_PASSWORD: ${{ secrets.TWINE_PASSWORD }}
52-
SLACK_WEBHOOK: ${{ secrets.SLACK_RELEASE_ENDPOINT }}
53-
SLACK_WEBHOOK_ADMIN: ${{ secrets.SLACK_WEBHOOK_ADMIN }}
54-
GH_TOKEN: ${{ secrets.PAT }}
33+
# build-test-publish-wheel:
34+
# needs: [pre-flight]
35+
# if: |
36+
# !(needs.pre-flight.outputs.docs_only == 'true'
37+
# || needs.pre-flight.outputs.is_deployment_workflow == 'true')
38+
# uses: NVIDIA-NeMo/FW-CI-templates/.github/workflows/_build_test_publish_wheel.yml@v0.48.0
39+
# with:
40+
# dry-run: true
41+
# python-package: nemo_export_deploy_common
42+
# python-version: "3.10"
43+
# packaging: uv
44+
# no-publish: ${{ !(github.ref == 'refs/heads/main' || startsWith(github.ref, 'refs/heads/r')) }}
45+
# skip-test-wheel: true
46+
# custom-container: nvcr.io/nvidia/pytorch:25.11-py3
47+
# no-build-isolation: true
48+
# runner: linux-amd64-cpu16
49+
# secrets:
50+
# TWINE_USERNAME: ${{ secrets.TWINE_USERNAME }}
51+
# TWINE_PASSWORD: ${{ secrets.TWINE_PASSWORD }}
52+
# SLACK_WEBHOOK: ${{ secrets.SLACK_RELEASE_ENDPOINT }}
53+
# SLACK_WEBHOOK_ADMIN: ${{ secrets.SLACK_WEBHOOK_ADMIN }}
54+
# GH_TOKEN: ${{ secrets.PAT }}
5555

56-
build-test-publish-wheel-summary:
57-
needs: [pre-flight, build-test-publish-wheel]
58-
if: |
59-
(
60-
needs.pre-flight.outputs.docs_only == 'true'
61-
|| needs.pre-flight.outputs.is_deployment_workflow == 'true'
62-
|| always()
63-
)
64-
&& !cancelled()
65-
runs-on: ubuntu-latest
66-
steps:
67-
- name: Result
68-
run: |
69-
FAILED_JOBS=$(gh run view $GITHUB_RUN_ID --json jobs --jq '[.jobs[] | select(.status == "completed" and .conclusion != "success")] | length') || echo 0
56+
# build-test-publish-wheel-summary:
57+
# needs: [pre-flight, build-test-publish-wheel]
58+
# if: |
59+
# (
60+
# needs.pre-flight.outputs.docs_only == 'true'
61+
# || needs.pre-flight.outputs.is_deployment_workflow == 'true'
62+
# || always()
63+
# )
64+
# && !cancelled()
65+
# runs-on: ubuntu-latest
66+
# steps:
67+
# - name: Result
68+
# run: |
69+
# FAILED_JOBS=$(gh run view $GITHUB_RUN_ID --json jobs --jq '[.jobs[] | select(.status == "completed" and .conclusion != "success")] | length') || echo 0
7070

71-
if [ "${FAILED_JOBS:-0}" -eq 0 ] || [ "$SKIPPING_IS_ALLOWED" == "true" ]; then
72-
echo "✅ All previous jobs completed successfully"
73-
exit 0
74-
else
75-
echo "❌ Found $FAILED_JOBS failed job(s)"
76-
# Show which jobs failed
77-
gh run view $GITHUB_RUN_ID --json jobs --jq '.jobs[] | select(.status == "completed" and .conclusion != "success") | .name'
78-
exit 1
79-
fi
71+
# if [ "${FAILED_JOBS:-0}" -eq 0 ] || [ "$SKIPPING_IS_ALLOWED" == "true" ]; then
72+
# echo "✅ All previous jobs completed successfully"
73+
# exit 0
74+
# else
75+
# echo "❌ Found $FAILED_JOBS failed job(s)"
76+
# # Show which jobs failed
77+
# gh run view $GITHUB_RUN_ID --json jobs --jq '.jobs[] | select(.status == "completed" and .conclusion != "success") | .name'
78+
# exit 1
79+
# fi

‎.github/workflows/cicd-main.yml‎

Lines changed: 44 additions & 32 deletions
Original file line numberDiff line numberDiff line change
@@ -120,6 +120,8 @@ jobs:
120120
inference-framework: trtllm
121121
test-data-path: ${{ needs.pre-flight.outputs.test_data_path }}
122122
runner: ${{ matrix.runner }}
123+
ngc-api-user: ${{ secrets.NGC_API_USER }}
124+
ngc-api-key: ${{ secrets.NGC_API_KEY }}
123125

124126
cicd-unit-tests-vllm:
125127
strategy:
@@ -160,6 +162,8 @@ jobs:
160162
inference-framework: vllm
161163
test-data-path: ${{ needs.pre-flight.outputs.test_data_path }}
162164
runner: ${{ matrix.runner }}
165+
ngc-api-user: ${{ secrets.NGC_API_USER }}
166+
ngc-api-key: ${{ secrets.NGC_API_KEY }}
163167

164168
cicd-e2e-tests-trtllm:
165169
strategy:
@@ -199,39 +203,43 @@ jobs:
199203
inference-framework: trtllm
200204
test-data-path: ${{ needs.pre-flight.outputs.test_data_path }}
201205
runner: ${{ matrix.runner }}
206+
ngc-api-user: ${{ secrets.NGC_API_USER }}
207+
ngc-api-key: ${{ secrets.NGC_API_KEY }}
202208

203-
cicd-e2e-tests-trt-onnx:
204-
needs: [cicd-unit-tests-trtllm, pre-flight]
205-
runs-on: ${{ needs.pre-flight.outputs.runner_prefix }}-gpu-x2
206-
name: ${{ matrix.is_optional && 'PLEASEFIXME_' || '' }}${{ matrix.script }}
207-
environment: nemo-ci
208-
if: |
209-
(
210-
success()
211-
|| (
212-
needs.cicd-wait-in-queue.result == 'skipped'
213-
&& needs.pre-flight.outputs.is_ci_workload == 'true'
214-
)
215-
)
216-
&& !cancelled()
217-
steps:
218-
- name: Checkout
219-
uses: actions/checkout@v4
220-
- name: main
221-
uses: ./.github/actions/test-template
222-
with:
223-
script: L2_ONNX_TRT
224-
is_optional: ${{ matrix.is_optional || false }}
225-
azure-client-id: ${{ secrets.AZURE_CLIENT_ID }}
226-
azure-tenant-id: ${{ secrets.AZURE_TENANT_ID }}
227-
azure-subscription-id: ${{ secrets.AZURE_SUBSCRIPTION_ID }}
228-
has-azure-credentials: true
229-
is_unit_test: "false"
230-
timeout: 60
231-
PAT: ${{ secrets.PAT }}
232-
inference-framework: trt-onnx
233-
test-data-path: ${{ needs.pre-flight.outputs.test_data_path }}
234-
runner: ${{ needs.pre-flight.outputs.runner_prefix }}-gpu-x2
209+
# cicd-e2e-tests-trt-onnx:
210+
# needs: [cicd-unit-tests-trtllm, pre-flight]
211+
# runs-on: ${{ needs.pre-flight.outputs.runner_prefix }}-gpu-x2
212+
# name: ${{ matrix.is_optional && 'PLEASEFIXME_' || '' }}${{ matrix.script }}
213+
# environment: nemo-ci
214+
# if: |
215+
# (
216+
# success()
217+
# || (
218+
# needs.cicd-wait-in-queue.result == 'skipped'
219+
# && needs.pre-flight.outputs.is_ci_workload == 'true'
220+
# )
221+
# )
222+
# && !cancelled()
223+
# steps:
224+
# - name: Checkout
225+
# uses: actions/checkout@v4
226+
# - name: main
227+
# uses: ./.github/actions/test-template
228+
# with:
229+
# script: L2_ONNX_TRT
230+
# is_optional: ${{ matrix.is_optional || false }}
231+
# azure-client-id: ${{ secrets.AZURE_CLIENT_ID }}
232+
# azure-tenant-id: ${{ secrets.AZURE_TENANT_ID }}
233+
# azure-subscription-id: ${{ secrets.AZURE_SUBSCRIPTION_ID }}
234+
# has-azure-credentials: true
235+
# is_unit_test: "false"
236+
# timeout: 60
237+
# PAT: ${{ secrets.PAT }}
238+
# inference-framework: trt-onnx
239+
# test-data-path: ${{ needs.pre-flight.outputs.test_data_path }}
240+
# runner: ${{ needs.pre-flight.outputs.runner_prefix }}-gpu-x2
241+
# ngc-api-user: ${{ secrets.NGC_API_USER }}
242+
# ngc-api-key: ${{ secrets.NGC_API_KEY }}
235243

236244
cicd-e2e-tests-vllm:
237245
needs: [cicd-unit-tests-vllm, pre-flight]
@@ -263,6 +271,8 @@ jobs:
263271
inference-framework: vllm
264272
test-data-path: ${{ needs.pre-flight.outputs.test_data_path }}
265273
runner: ${{ needs.pre-flight.outputs.runner_prefix }}-gpu-x2
274+
ngc-api-user: ${{ secrets.NGC_API_USER }}
275+
ngc-api-key: ${{ secrets.NGC_API_KEY }}
266276

267277
cicd-e2e-tests-inframework:
268278
needs: [pre-flight, cicd-unit-tests-trtllm, cicd-unit-tests-vllm]
@@ -294,6 +304,8 @@ jobs:
294304
inference-framework: inframework
295305
test-data-path: ${{ needs.pre-flight.outputs.test_data_path }}
296306
runner: ${{ needs.pre-flight.outputs.runner_prefix }}-gpu-x2
307+
ngc-api-user: ${{ secrets.NGC_API_USER }}
308+
ngc-api-key: ${{ secrets.NGC_API_KEY }}
297309

298310
Nemo_CICD_Test:
299311
needs:

0 commit comments

Comments
 (0)