Fix experimental attention variant spec#2018
Closed
yuzhongw-nvidia wants to merge 3 commits intoNVIDIA-NeMo:mainfrom
Closed
Fix experimental attention variant spec#2018yuzhongw-nvidia wants to merge 3 commits intoNVIDIA-NeMo:mainfrom
yuzhongw-nvidia wants to merge 3 commits intoNVIDIA-NeMo:mainfrom
Conversation
Signed-off-by: oliver könig <okoenig@nvidia.com>
Signed-off-by: oliver könig <okoenig@nvidia.com>
maanug-nv
approved these changes
Jan 21, 2026
Contributor
maanug-nv
left a comment
maanug-nv
left a comment
There was a problem hiding this comment.
lgtm, but let's wait until internal CI run finishes
Contributor
|
/ok to test 98586d6 |
ko3n1g
approved these changes
Jan 22, 2026
Contributor
|
Close in favor of #2030 due to linting issues |
maanug-nv
reviewed
Jan 22, 2026
| config = _transformer_config_from_args(args) | ||
|
|
||
| if args.num_experts: | ||
| if args.experimental_attention_variant is not None: |
Contributor
There was a problem hiding this comment.
this should be safely accessed with getattr
Suggested change
| if args.experimental_attention_variant is not None: | |
| if getattr(args, "experimental_attention_variant", None) is not None: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
Changelog
GitHub Actions CI
See the CI sectionin the Contributing doc for how to trigger the CI. A Nvidia developer will need to approve and trigger the CI for external contributors.
Before your PR is "Ready for review"
Pre checks:
If you haven't finished some of the above items you can still open "Draft" PR.
Additional Information