Removes use of torchaudio and moves transforms inside of NeMo #15211
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jason <[email protected]>
Signed-off-by: blisc <[email protected]>
Signed-off-by: Jason <[email protected]>
Signed-off-by: blisc <[email protected]>
Signed-off-by: Jason <[email protected]>
Signed-off-by: Jason <[email protected]>
Signed-off-by: Jason <[email protected]>
Signed-off-by: blisc <[email protected]>
Signed-off-by: blisc <[email protected]>
Signed-off-by: Jason <[email protected]>
…o tts_2512_removetorchaudio
nithinraok
previously approved these changes
Jan 8, 2026
Member
There was a problem hiding this comment.
@chtruong814 could you help review the docker file changes.
Member
|
@blisc I think updates to |
Collaborator
Author
I don't know if there is an equivalent to torchaudio.load() so I'm deferring making that change. @PiotrDabkowski Do you have a recommendation on how to update that docs? |
Member
|
That failing CI test is okay to skip as its flaky. @chtruong814 FYI |
nithinraok
approved these changes
Jan 16, 2026
Member
nithinraok
left a comment
nithinraok
left a comment
There was a problem hiding this comment.
LGTM.
@chtruong814 / @ko3n1g review for docker related changes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Important
The
Update branchbutton must only be pressed in very rare occassions.An outdated branch is never blocking the merge of a PR.
Please reach out to the automation team before pressing that button.
What does this PR do ?
Removes use of torchaudio.transforms and moves transforms inside of NeMo.
NOTE: we will use torchsquirm in nemo/collections/audio/metrics/squim.py and nemo/collections/tts/models/magpietts_preference_optimization.py
Collection: audio, asr, tts
Changelog
PR Type: