Skip to content

Commit 4733717

Browse files
committed
Fix linting issues
Signed-off-by: Olivier Delalleau <507137+odelalleau@users.noreply.github.com>
1 parent ba2e4b6 commit 4733717

File tree

2 files changed

+8
-5
lines changed

2 files changed

+8
-5
lines changed

nemo_rl/models/policy/__init__.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -38,6 +38,7 @@ class RewardModelConfig(TypedDict):
3838
enabled: bool
3939
reward_model_type: str
4040

41+
4142
class MegatronOptimizerConfig(TypedDict):
4243
optimizer: str
4344
lr: float

nemo_rl/models/policy/dtensor_policy_worker.py

Lines changed: 7 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -203,11 +203,15 @@ def __init__(
203203
else None,
204204
)
205205

206-
self._is_reward_model = self.cfg.get("reward_model_cfg", {}).get("enabled", False)
206+
self._is_reward_model = self.cfg.get("reward_model_cfg", {}).get(
207+
"enabled", False
208+
)
207209
if self._is_reward_model:
208210
# Ensure sequence packing is disabled.
209211
if self.enable_seq_packing:
210-
raise NotImplementedError("Sequence packing is not supported for reward models")
212+
raise NotImplementedError(
213+
"Sequence packing is not supported for reward models"
214+
)
211215
# Load model as a Reward Model.
212216
rm_type = self.cfg["reward_model_cfg"]["reward_model_type"]
213217
if rm_type == "bradley_terry":
@@ -227,9 +231,7 @@ def __init__(
227231
)
228232
model_config.num_labels = 1
229233
else:
230-
raise ValueError(
231-
f"Unknown reward model type: {rm_type}"
232-
)
234+
raise ValueError(f"Unknown reward model type: {rm_type}")
233235
else:
234236
model_class = AutoModelForCausalLM
235237

0 commit comments

Comments
 (0)