Skip to content

Commit 6526fe9

Browse files
cp: fix: relax nanov3 nightly test metrics strict (1712) into r0.5.0 (#1713)
Signed-off-by: ruit <ruit@nvidia.com> Signed-off-by: NeMo Bot <nemo-bot@nvidia.com> Co-authored-by: Rayen <ruit@nvidia.com>
1 parent 6e7a2f7 commit 6526fe9

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

tests/test_suites/llm/sft-nanov3-30BA3B-2n8g-fsdp2-lora.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,6 +33,6 @@ uv run tests/json_dump_tb_logs.py $LOG_DIR --output_path $JSON_METRICS
3333
# Only run metrics if the target step is reached
3434
if [[ $(jq 'to_entries | .[] | select(.key == "train/loss") | .value | keys | map(tonumber) | max' $JSON_METRICS) -ge $MAX_STEPS ]]; then
3535
uv run tests/check_metrics.py $JSON_METRICS \
36-
'data["train/loss"]["20"] < 2.03' \
36+
'data["train/loss"]["20"] < 2.05' \
3737
'mean(data["timing/train/total_step_time"], 2) < 18'
3838
fi

tests/test_suites/llm/sft-nanov3-30BA3B-2n8g-fsdp2.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,6 +33,6 @@ uv run tests/json_dump_tb_logs.py $LOG_DIR --output_path $JSON_METRICS
3333
# Only run metrics if the target step is reached
3434
if [[ $(jq 'to_entries | .[] | select(.key == "train/loss") | .value | keys | map(tonumber) | max' $JSON_METRICS) -ge $MAX_STEPS ]]; then
3535
uv run tests/check_metrics.py $JSON_METRICS \
36-
'data["train/loss"]["20"] < 1.98' \
36+
'data["train/loss"]["20"] < 2.05' \
3737
'mean(data["timing/train/total_step_time"], 2) < 15'
3838
fi

0 commit comments

Comments
 (0)