Skip to content

Commit 6ac9028

Browse files
committed
fix unit test
Signed-off-by: Yuki Huang <yukih@nvidia.com>
1 parent f2ce942 commit 6ac9028

File tree

1 file changed

+12
-3
lines changed

1 file changed

+12
-3
lines changed

tests/unit/models/automodel/test_automodel_setup.py

Lines changed: 12 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -56,7 +56,12 @@ def mock_config():
5656
"use_hf_tp_plan": False,
5757
"activation_checkpointing": False,
5858
},
59-
"generation": None,
59+
"generation": {
60+
"temperature": 1.0,
61+
"top_p": 1.0,
62+
"top_k": None,
63+
"colocated": {"enabled": True},
64+
},
6065
"hf_config_overrides": {},
6166
"optimizer": {
6267
"name": "torch.optim.AdamW",
@@ -325,7 +330,7 @@ def test_generation_colocated(
325330
mock_resolve_class.return_value = Mock
326331

327332
# Test with generation colocated enabled
328-
mock_config["generation"] = {"colocated": {"enabled": True}}
333+
mock_config["generation"]["colocated"]["enabled"] = True
329334
result = validate_and_prepare_config(mock_config, None, 0)
330335
assert result.is_generation_colocated is True
331336
# NCCL_CUMEM_ENABLE should not be set when colocated
@@ -348,7 +353,7 @@ def test_generation_not_colocated(
348353
mock_resolve_class.return_value = Mock
349354

350355
# Test with generation colocated disabled
351-
mock_config["generation"] = {"colocated": {"enabled": False}}
356+
mock_config["generation"]["colocated"]["enabled"] = False
352357
result = validate_and_prepare_config(mock_config, None, 0)
353358
assert result.is_generation_colocated is False
354359
# NCCL_CUMEM_ENABLE should be set when not colocated
@@ -605,6 +610,7 @@ def mock_runtime_config(self):
605610
cpu_offload=False,
606611
offload_optimizer_for_logprob=False,
607612
is_generation_colocated=None,
613+
sampling_params=None,
608614
is_reward_model=False,
609615
)
610616

@@ -645,6 +651,7 @@ def test_setup_distributed_with_cpu_offload(
645651
cpu_offload=True, # CPU offload enabled
646652
offload_optimizer_for_logprob=False,
647653
is_generation_colocated=None,
654+
sampling_params=None,
648655
is_reward_model=False,
649656
)
650657

@@ -712,6 +719,7 @@ def mock_runtime_config(self, mock_autoconfig):
712719
cpu_offload=False,
713720
offload_optimizer_for_logprob=False,
714721
is_generation_colocated=None,
722+
sampling_params=None,
715723
is_reward_model=False,
716724
)
717725

@@ -1469,6 +1477,7 @@ def test_setup_model_with_cpu_offload(
14691477
cpu_offload=True, # CPU offload enabled
14701478
offload_optimizer_for_logprob=False,
14711479
is_generation_colocated=None,
1480+
sampling_params=None,
14721481
is_reward_model=False,
14731482
)
14741483

0 commit comments

Comments
 (0)