Skip to content

Commit 8980a0d

Browse files
authored
fix: Fix incorrect indexing of message which cuts off user message when we… (#815)
Signed-off-by: Parth Chadha <pchadha@nvidia.com>
1 parent 26a1078 commit 8980a0d

File tree

2 files changed

+22
-1
lines changed

2 files changed

+22
-1
lines changed

examples/run_grpo_math.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -90,7 +90,7 @@ def hf_data_processor(
9090
add_special_tokens=False,
9191
)
9292
user_message["token_ids"] = tokenizer(message, return_tensors="pt")["input_ids"][0]
93-
user_message["content"] = message[0]
93+
user_message["content"] = message
9494
message_log.append(user_message)
9595

9696
length = sum(len(m["token_ids"]) for m in message_log)

tests/unit/utils/test_logger.py

Lines changed: 21 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -26,6 +26,7 @@
2626
TensorboardLogger,
2727
WandbLogger,
2828
flatten_dict,
29+
print_message_log_samples,
2930
)
3031

3132

@@ -1441,3 +1442,23 @@ def test_log_hyperparams_with_mlflow(
14411442
mock_wandb_instance.log_hyperparams.assert_called_once_with(params)
14421443
mock_tb_instance.log_hyperparams.assert_called_once_with(params)
14431444
mock_mlflow_instance.log_hyperparams.assert_called_once_with(params)
1445+
1446+
1447+
def test_print_message_log_samples(capsys):
1448+
"""Test that print_message_log_samples displays full content correctly."""
1449+
# Test message with full content (verifies our bug fix)
1450+
message_logs = [
1451+
[
1452+
{"role": "user", "content": "What is 2+2?"},
1453+
{"role": "assistant", "content": "2+2 = 4"},
1454+
]
1455+
]
1456+
rewards = [1.0]
1457+
1458+
print_message_log_samples(message_logs, rewards, num_samples=1, step=0)
1459+
1460+
captured = capsys.readouterr()
1461+
# Verify content is displayed properly
1462+
assert "What is 2+2?" in captured.out
1463+
assert "2+2 = 4" in captured.out
1464+
assert "Sample 1 | Reward: 1.0000" in captured.out

0 commit comments

Comments
 (0)