Skip to content

Commit a010564

Browse files
authored
chore: Enable LoRA Nightly Test (#1634)
Signed-off-by: ruit <ruit@nvidia.com>
1 parent 363165a commit a010564

File tree

4 files changed

+2
-4
lines changed

4 files changed

+2
-4
lines changed

examples/configs/recipes/llm/sft-llama3.1-8b-1n8g-fsdp2tp1-lora.yaml.disabled renamed to examples/configs/recipes/llm/sft-llama3.1-8b-1n8g-fsdp2tp1-lora.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ policy:
2626
weight_decay: 0.01
2727
eps: 1.0e-08
2828
data:
29-
dataset_name: tulu3
29+
dataset_name: tulu3_sft_mixture
3030
add_generation_prompt: true
3131
seed: 42
3232
logger:

nemo_rl/data/datasets/response_datasets/__init__.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -97,7 +97,6 @@ def load_response_dataset(data_config, seed: int = 42):
9797
split=data_config["split"],
9898
)
9999
elif dataset_name == "tulu3_sft_mixture":
100-
print("Loading allenai/tulu-3-sft-mixture for training and validation")
101100
base_dataset: Any = Tulu3SftMixtureDataset(
102101
test_size=data_config.get("test_size", 0.05),
103102
prompt_file=data_config.get("prompt_file", None),

tests/test_suites/llm/sft-llama3.1-8b-1n8g-fsdp2tp1-lora.sh.disabled renamed to tests/test_suites/llm/sft-llama3.1-8b-1n8g-fsdp2tp1-lora.sh

File renamed without changes.

tests/test_suites/nightly.txt

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -71,8 +71,7 @@ tests/test_suites/llm/sft-llama3.1-8b-1n8g-fsdp2tp2.sh
7171
# dynamic batching
7272
tests/test_suites/llm/sft-llama3.1-8b-1n8g-fsdp2tp1-dynamicbatch.sh
7373
# lora
74-
# Tulu3 dataset is not supported yet. Re-enable this test once PR https://github.com/NVIDIA-NeMo/RL/pull/1506 is merged.
75-
# tests/test_suites/llm/sft-llama3.1-8b-1n8g-fsdp2tp1-lora.sh
74+
tests/test_suites/llm/sft-llama3.1-8b-1n8g-fsdp2tp1-lora.sh
7675

7776
# Functional 32b test
7877
tests/test_suites/llm/sft-qwen2.5-32b-4n8g-fsdp2tp8sp-actckpt.v3.sh

0 commit comments

Comments
 (0)