ci: Update release-docs workflow to use FW-CI-templates v0.72.0#1965
ci: Update release-docs workflow to use FW-CI-templates v0.72.0#1965chtruong814 merged 1 commit intomainfrom
Conversation
Signed-off-by: Charlie Truong <chtruong@nvidia.com>
📝 WalkthroughWalkthroughThis PR updates the release-docs workflow by introducing a new optional workflow input Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Possibly related PRs
Suggested labels
Suggested reviewers
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches🧪 Generate unit tests (beta)
Tip Issue Planner is now in beta. Read the docs and try it out! Share your feedback on Discord. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
.github/workflows/release-docs.yml (1)
52-57:⚠️ Potential issue | 🟡 MinorStale inline comment — no longer reflects the new behavior.
These comments still describe the old behavior where running on
mainpublishes to the "latest" directory. Withoverwrite-latest-on-tagnow driven by thepublish-as-latestinput, "latest" is controlled explicitly and is no longer tied to being onmain. Please update or remove the comment to avoid confusion.✏️ Suggested comment update
- uses: ./FW-CI-templates/.github/actions/publish-docs - # This workflow runs either on main, or on a version tag. Any other git ref will lead - # to an error. - # If its on main, it will publish to "latest" directory in Akamai. - # If its on a versioned tag, it will extract the version number from the tag (strip `v` prefix) - # and publish to the versioned directory in Akamai. + # This workflow runs either on main or on a version tag. Any other git ref will lead + # to an error. + # On a versioned tag, it extracts the version number (strips `v` prefix) and publishes + # to the versioned directory in Akamai. If publish-as-latest is true, it also overwrites + # the "latest" directory.
…IA-NeMo#1965) Signed-off-by: Charlie Truong <chtruong@nvidia.com> Signed-off-by: yuanhangs <yuanhangs@nvidia.com>
What does this PR do ?
ci: Update release-docs workflow to use FW-CI-templates v0.72.0
The latest tag in some repos was whatever was published from main branch. However, we will now designate "latest" as the latest stable version. A follow-up change will include publshing docs as part of the release repo workflow. And we will also begin to publish "nightly" docs from the main branch.
Issues
List issues that this PR closes (syntax):
Usage
# Add a code snippet demonstrating how to use thisBefore your PR is "Ready for review"
Pre checks:
Additional Information
Summary by CodeRabbit