You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
@@ -34,16 +36,19 @@ We use [uv](https://docs.astral.sh/uv/) to develop NeMo Run. The following steps
34
36
If all tests passed, then you should be good to get started with the development of NeMo-Run.
35
37
36
38
## Code Structure
39
+
37
40
The repository is home to flexible Python modules, sample scripts, tests, and more.
38
41
Here is a brief overview of where everything lives:
42
+
39
43
-[docker](docker/) - Dockerfiles to build NeMo with NeMo Run.
40
44
-[docs](docs/) - Walkthroughs and guides the library.
41
45
-[examples](examples/) - Examples for how users may want to use NeMo Run.
42
46
-[src](src/) -
43
-
-[nemo_run](src/nemo_run/) - The source code for NeMo Run.
47
+
-[nemo_run](src/nemo_run/) - The source code for NeMo Run.
44
48
-[test](test/) - Unit tests.
45
49
46
50
## Examples and Documentation
51
+
47
52
Examples provide an easy way for users to see how the NeMo Run works in action.
48
53
They should be incredibly lightweight and rely mostly on `nemo_run` for their functionality
49
54
Most should be designed for a user to get up and running on their local machines, but examples on remote clusters are welcomed if it makes sense.
@@ -54,35 +59,49 @@ It should include both an explanation of the API, and how it's used in its corre
54
59
The documentation should also cover potential pitfalls and caveats.
55
60
This existing examples and documentation should serve as a good reference to what is expected.
56
61
62
+
### Building Documentation
63
+
64
+
Run the following commands to switch to the project documentation folder and generate HTML output.
65
+
66
+
```sh
67
+
cd docs/
68
+
uv run --group docs sphinx-build source/ _build/html
69
+
```
70
+
71
+
The resulting HTML files are generated in a `_build/html` folder created under the project `docs/` folder.
72
+
57
73
## Python style
58
-
We use [``ruff``](https://docs.astral.sh/ruff/) for linting and formatting. To lint and format your code, you can run `uv run --group lint -- ruff check` and `uv run --group lint -- ruff format` respectively.
74
+
75
+
We use [`ruff`](https://docs.astral.sh/ruff/) for linting and formatting. To lint and format your code, you can run `uv run --group lint -- ruff check` and `uv run --group lint -- ruff format` respectively.
59
76
60
77
## Unit tests
78
+
61
79
Unit tests should be simple and fast.
62
80
Developers should be able to run them frequently while developing without any slowdown.
63
81
64
82
## Pull Requests (PR) Guidelines
65
83
66
84
**Send your PRs to the `main` or `dev` branch**
67
85
68
-
1) Make sure your PR does one thing. Have a clear answer to "What does this PR do?".
69
-
2) Read General Principles and style guide above
70
-
3) Make sure you sign off your commits. E.g. use ``git commit --signoff`` when committing.
71
-
4) Make sure all unit tests finish successfully before sending PR
72
-
5) Send your PR and request a review
86
+
1. Make sure your PR does one thing. Have a clear answer to "What does this PR do?".
87
+
2. Read General Principles and style guide above
88
+
3. Make sure you sign off your commits. E.g. use `git commit --signoff` when committing.
89
+
4. Make sure all unit tests finish successfully before sending PR
90
+
5. Send your PR and request a review
73
91
74
92
The `dev` branch is for active development and may be unstable. Unit tests are expected to pass before merging into `dev` or `main`.
75
93
Every release `dev` and `main` will sync to be the same.
76
94
77
95
## Sign Your Work
78
96
79
-
* We require that all contributors "sign-off" on their commits. This certifies that the contribution is your original work, or you have rights to submit it under the same license, or a compatible license.
97
+
- We require that all contributors "sign-off" on their commits. This certifies that the contribution is your original work, or you have rights to submit it under the same license, or a compatible license.
98
+
99
+
- Any contribution which contains commits that are not Signed-Off will not be accepted.
80
100
81
-
* Any contribution which contains commits that are not Signed-Off will not be accepted.
101
+
- To sign off on a commit you simply use the `--signoff` option when committing your changes:
82
102
83
-
* To sign off on a commit you simply use the `--signoff` option when committing your changes:
0 commit comments