Skip to content

Commit 8199175

Browse files
authored
Remove ray deprecated dashboard-grpc-port arg (#325)
* Remove ray deprecated dashboard-grpo-port arg Signed-off-by: Charlie Truong <[email protected]> * Fix nemo run ray cluster tests Signed-off-by: Charlie Truong <[email protected]> * Remove DASHBOARD_GRPC_PORT Signed-off-by: Charlie Truong <[email protected]> --------- Signed-off-by: Charlie Truong <[email protected]>
1 parent 8196011 commit 8199175

File tree

3 files changed

+0
-6
lines changed

3 files changed

+0
-6
lines changed

nemo_run/run/ray/templates/ray.sub.j2

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,6 @@ METRICS_EXPORT_PORT=${METRICS_EXPORT_PORT:-53009}
3131
PORT=${PORT:-6379}
3232
RAY_CLIENT_SERVER_PORT=${RAY_CLIENT_SERVER_PORT:-10001}
3333
#REDIT_SHARD_PORTS=${REDIT_SHARD_PORTS:-"random"} ??
34-
DASHBOARD_GRPC_PORT=${DASHBOARD_GRPC_PORT:-52367}
3534
DASHBOARD_PORT=${DASHBOARD_PORT:-8265} # Also used by debugger
3635
DASHBOARD_AGENT_LISTEN_PORT=${DASHBOARD_AGENT_LISTEN_PORT:-52365}
3736

@@ -183,7 +182,6 @@ ray start --head \
183182
--node-ip-address="$head_node_ip" \
184183
--port=${PORT} \
185184
--ray-client-server-port=${RAY_CLIENT_SERVER_PORT} \
186-
--dashboard-grpc-port=${DASHBOARD_GRPC_PORT} \
187185
--dashboard-port=${DASHBOARD_PORT} \
188186
\
189187
--node-manager-port=${NODE_MANAGER_PORT} \

test/core/execution/artifacts/expected_ray_cluster.sub

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,6 @@ METRICS_EXPORT_PORT=${METRICS_EXPORT_PORT:-53009}
3333
PORT=${PORT:-6379}
3434
RAY_CLIENT_SERVER_PORT=${RAY_CLIENT_SERVER_PORT:-10001}
3535
#REDIT_SHARD_PORTS=${REDIT_SHARD_PORTS:-"random"} ??
36-
DASHBOARD_GRPC_PORT=${DASHBOARD_GRPC_PORT:-52367}
3736
DASHBOARD_PORT=${DASHBOARD_PORT:-8265} # Also used by debugger
3837
DASHBOARD_AGENT_LISTEN_PORT=${DASHBOARD_AGENT_LISTEN_PORT:-52365}
3938

@@ -177,7 +176,6 @@ ray start --head \
177176
--node-ip-address="$head_node_ip" \
178177
--port=${PORT} \
179178
--ray-client-server-port=${RAY_CLIENT_SERVER_PORT} \
180-
--dashboard-grpc-port=${DASHBOARD_GRPC_PORT} \
181179
--dashboard-port=${DASHBOARD_PORT} \
182180
\
183181
--node-manager-port=${NODE_MANAGER_PORT} \

test/core/execution/artifacts/expected_ray_cluster_ssh.sub

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,6 @@ METRICS_EXPORT_PORT=${METRICS_EXPORT_PORT:-53009}
3434
PORT=${PORT:-6379}
3535
RAY_CLIENT_SERVER_PORT=${RAY_CLIENT_SERVER_PORT:-10001}
3636
#REDIT_SHARD_PORTS=${REDIT_SHARD_PORTS:-"random"} ??
37-
DASHBOARD_GRPC_PORT=${DASHBOARD_GRPC_PORT:-52367}
3837
DASHBOARD_PORT=${DASHBOARD_PORT:-8265} # Also used by debugger
3938
DASHBOARD_AGENT_LISTEN_PORT=${DASHBOARD_AGENT_LISTEN_PORT:-52365}
4039

@@ -182,7 +181,6 @@ ray start --head \
182181
--node-ip-address="$head_node_ip" \
183182
--port=${PORT} \
184183
--ray-client-server-port=${RAY_CLIENT_SERVER_PORT} \
185-
--dashboard-grpc-port=${DASHBOARD_GRPC_PORT} \
186184
--dashboard-port=${DASHBOARD_PORT} \
187185
\
188186
--node-manager-port=${NODE_MANAGER_PORT} \

0 commit comments

Comments
 (0)