Skip to content

Commit abb82f0

Browse files
committed
Clarify tar repacking logic to avoid issues with concatenating tar files
Signed-off-by: smajumdar <[email protected]>
1 parent 71c2c3f commit abb82f0

File tree

1 file changed

+2
-0
lines changed

1 file changed

+2
-0
lines changed

nemo_run/core/packaging/git.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -89,6 +89,8 @@ def _concatenate_tar_files(
8989
quoted_output_file = shlex.quote(output_file)
9090

9191
# Extract all fragments and repack once (faster than iterative extract/append)
92+
# Note: Avoid using tar Af based solution as it does not properly concatenate
93+
# tar files for additional filepaths and submodules.
9294
temp_dir = f"temp_extract_{uuid.uuid4()}"
9395
ctx.run(f"mkdir -p {temp_dir}")
9496
for file in quoted_files:

0 commit comments

Comments
 (0)