fix lints

Signed-off-by: Rahim Dharssi <[email protected]>

Author: rahimftd

nemo_run/core/execution/skypilot_jobs.py

@@ -23,7 +23,7 @@
 
     _SKYPILOT_AVAILABLE = True
 except ImportError:
-    ...
+    pass
 
 logger = logging.getLogger(__name__)
 
@@ -110,7 +110,7 @@ class SkypilotJobsExecutor(Executor):
     infra: Optional[str] = None
     network_tier: Optional[str] = None
     retry_until_up: bool = False
-    packager: Packager = field(default_factory=lambda: GitArchivePackager())  # type: ignore  # noqa: F821
+    packager: Packager = field(default_factory=GitArchivePackager)  # type: ignore  # noqa: F821
 
     def __post_init__(self):
         assert _SKYPILOT_AVAILABLE, (
@@ -204,9 +204,7 @@ def parse_attr(attr: str):
         return resources  # type: ignore
 
     @classmethod
-    def status(
-        cls: Type["SkypilotJobsExecutor"], app_id: str
-    ) -> Optional[dict]:
+    def status(cls: Type["SkypilotJobsExecutor"], app_id: str) -> Optional[dict]:
         from sky import stream_and_get
         import sky.exceptions as sky_exceptions
         import sky.jobs.client.sdk as sky_jobs
@@ -215,11 +213,7 @@ def status(
 
         try:
             job_details: List[Dict[str, Any]] = stream_and_get(
-                sky_jobs.queue(
-                    refresh=True,
-                    all_users=True,
-                    job_ids=[job_id]
-                ),
+                sky_jobs.queue(refresh=True, all_users=True, job_ids=[job_id]),
             )[0]
         except sky_exceptions.ClusterNotUpError:
             return None
@@ -400,15 +394,13 @@ def launch(
         task: "skyt.Task",
         num_nodes: Optional[int] = None,
     ) -> tuple[Optional[int], Optional["backends.ResourceHandle"]]:
-        from sky import stream_and_get, skypilot_config
+        from sky import stream_and_get
         from sky.jobs.client.sdk import launch
 
         if num_nodes:
             task.num_nodes = num_nodes
 
-        job_id, handle = stream_and_get(
-            launch(task)
-        )
+        job_id, handle = stream_and_get(launch(task))
 
         return job_id, handle
 

nemo_run/run/torchx_backend/schedulers/skypilot_jobs.py

@@ -1,5 +1,4 @@
 import json
-import logging
 import os
 import shutil
 import tempfile
@@ -57,9 +56,8 @@
         ManagedJobStatus.FAILED_CONTROLLER: AppState.FAILED,
     }
 except ImportError:
-    ...
+    pass
 
-log: logging.Logger = logging.getLogger(__name__)
 SKYPILOT_JOB_DIRS = os.path.join(get_nemorun_home(), ".skypilot_jobs.json")
 
 
@@ -187,7 +185,8 @@ def describe(self, app_id: str) -> Optional[DescribeAppResponse]:
     def _cancel_existing(self, app_id: str) -> None:
         SkypilotJobsExecutor.cancel(app_id=app_id)
 
-    def list(self) -> list[ListAppResponse]: ...
+    def list(self) -> list[ListAppResponse]:
+        pass
 
 
 def create_scheduler(session_name: str, **kwargs: Any) -> SkypilotJobsScheduler:

test/core/execution/test_skypilot_jobs.py

@@ -371,7 +371,9 @@ def test_to_task(self, mock_task, mock_skypilot_imports, executor):
             executor.job_dir = tmp_dir
             executor.file_mounts = {"test_file": "/path/to/test_file"}
 
-            result = executor.to_task("test_task", ["python", "train.py"], {"TEST_VAR": "test_value"})
+            result = executor.to_task(
+                "test_task", ["python", "train.py"], {"TEST_VAR": "test_value"}
+            )
 
             mock_task.assert_called_once()
             assert mock_task.call_args[1]["name"] == "test_task"

test/run/torchx_backend/schedulers/test_skypilot_jobs.py

@@ -89,7 +89,9 @@ def test_cancel_existing(skypilot_jobs_scheduler):
 def test_describe_no_status(skypilot_jobs_scheduler):
     with (
         mock.patch.object(SkypilotJobsExecutor, "status") as mock_status,
-        mock.patch("nemo_run.run.torchx_backend.schedulers.skypilot_jobs._get_job_dirs") as mock_get_job_dirs,
+        mock.patch(
+            "nemo_run.run.torchx_backend.schedulers.skypilot_jobs._get_job_dirs"
+        ) as mock_get_job_dirs,
     ):
         mock_status.return_value = None
         mock_get_job_dirs.return_value = {}
@@ -101,14 +103,13 @@ def test_describe_no_status(skypilot_jobs_scheduler):
 def test_describe_with_status(skypilot_jobs_scheduler):
     from sky.jobs.state import ManagedJobStatus
 
-    task_details = {
-        "status": ManagedJobStatus.RUNNING,
-        "job_id": 123
-    }
+    task_details = {"status": ManagedJobStatus.RUNNING, "job_id": 123}
 
     with (
         mock.patch.object(SkypilotJobsExecutor, "status") as mock_status,
-        mock.patch("nemo_run.run.torchx_backend.schedulers.skypilot_jobs._save_job_dir") as mock_save,
+        mock.patch(
+            "nemo_run.run.torchx_backend.schedulers.skypilot_jobs._save_job_dir"
+        ) as mock_save,
     ):
         mock_status.return_value = task_details
 
@@ -122,15 +123,13 @@ def test_describe_with_status(skypilot_jobs_scheduler):
 
 
 def test_describe_with_past_jobs(skypilot_jobs_scheduler):
-    past_apps = {
-        "test_cluster___test_role___123": {
-            "job_status": "SUCCEEDED"
-        }
-    }
+    past_apps = {"test_cluster___test_role___123": {"job_status": "SUCCEEDED"}}
 
     with (
         mock.patch.object(SkypilotJobsExecutor, "status") as mock_status,
-        mock.patch("nemo_run.run.torchx_backend.schedulers.skypilot_jobs._get_job_dirs") as mock_get_job_dirs,
+        mock.patch(
+            "nemo_run.run.torchx_backend.schedulers.skypilot_jobs._get_job_dirs"
+        ) as mock_get_job_dirs,
     ):
         mock_status.return_value = None
         mock_get_job_dirs.return_value = past_apps
@@ -141,4 +140,5 @@ def test_describe_with_past_jobs(skypilot_jobs_scheduler):
         assert result.app_id == "test_cluster___test_role___123"
         # The state should be mapped from SUCCEEDED status
         from torchx.specs import AppState
+
         assert result.state == AppState.SUCCEEDED