fix

Signed-off-by: Hemil Desai <[email protected]>

Author: hemildesai

test/run/test_job.py

@@ -169,6 +169,7 @@ def test_job_launch_dryrun(simple_task, docker_executor, mock_runner):
     )
 
     with patch("nemo_run.run.job.launch") as mock_launch:
+        mock_launch.return_value = (None, "dryrun")
         job.prepare()
         job.launch(wait=False, runner=mock_runner, dryrun=True)
         mock_launch.assert_called_once()
@@ -537,6 +538,8 @@ def test_job_group_launch_dryrun(simple_task, docker_executor, mock_runner):
     job_group._executables = [(MagicMock(), docker_executor)]
 
     with patch("nemo_run.run.job.launch") as mock_launch:
+        mock_launch.return_value = (None, "dryrun")
+
         job_group.launch(wait=False, runner=mock_runner, dryrun=True)
         # Now we have just one executable, which gets launch called once
         assert mock_launch.call_count == 1

test/run/torchx_backend/test_launcher.py

@@ -62,7 +62,7 @@ def test_launch_dryrun(mock_runner, mock_executor, mock_executable):
     mock_runner.dryrun.assert_called_once_with(
         mock_executable, "test_executor", cfg=mock_executor, parent_run_id=None
     )
-    assert result == (None, None)
+    assert result == (None, dryrun_info)
 
 
 def test_launch_non_dryrun(mock_runner, mock_executor, mock_executable):
@@ -78,7 +78,11 @@ def test_launch_non_dryrun(mock_runner, mock_executor, mock_executable):
     )
 
     mock_runner.run.assert_called_once_with(
-        mock_executable, "test_executor", cfg=mock_executor, parent_run_id=None
+        mock_executable,
+        "test_executor",
+        cfg=mock_executor,
+        parent_run_id=None,
+        dryrun_info=None,
     )
     assert result[0] == mock_app_handle