[SkyPilot] Update YAML dump imports + backward compatibility for SkyPilot <=0.10.3 #339
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Romil Bhardwaj <[email protected]>
romilbhardwaj
had a problem deploying
to
public
GitHub Actions
Failure
romilbhardwaj
had a problem deploying
to
public
GitHub Actions
Failure
Contributor
|
Thanks @romilbhardwaj, this looks like it doesn't require specific unit tests. I'll see if we can disable the code coverage check for this PR. |
chtruong814
approved these changes
Sep 19, 2025
Contributor
|
Moving forward with merging this since just an import guard against different versions. |
zoeyz101
pushed a commit
to zoeyz101/NeMo-Run
that referenced
this pull request
Nov 12, 2025
Signed-off-by: Romil Bhardwaj <[email protected]> Signed-off-by: Zoey Zhang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SkyPilot 0.10.3 moved dump_yaml_str from
sky.utils.common_utilstosky.utils.yaml_utilsin skypilot-org/skypilot@c932c1b. This PR adds a fallback for YAML dumping if an older SkyPilot version is detected.Alternative to this PR could be to pin the SkyPilot version to >=0.10.3 and always use
from sky.utils import yaml_utils, but I'll let the Nemo Run maintainers take the call on that.