fix broken links in README.md #386
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthew-frank
had a problem deploying
to
public
GitHub Actions
Failure
Contributor
|
Hi, can you amend the commit with --signoff to pass the DCO check? |
matthew-frank
had a problem deploying
to
public
GitHub Actions
Failure
Signed-off-by: Matthew Frank <[email protected]>
matthew-frank
force-pushed
the
mfrank/fix-readme
branch
from
3ad773e to
d0b2ce3
Compare
Contributor
Author
I'm not sure what this means, but I followed some instructions from chatGPT that have hopefully done what you are requesting. |
matthew-frank
had a problem deploying
to
public
GitHub Actions
Failure
matthew-frank
had a problem deploying
to
public
GitHub Actions
Failure
Contributor
|
Hi @matthew-frank, yes that fixed it. Sorry I didn't include more details in my earlier message. We have mentioned the DCO requirements here - https://github.com/NVIDIA-NeMo/Run/blob/main/CONTRIBUTING.md#sign-your-work |
hemildesai
approved these changes
Nov 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes four broken links in the README.md