Skip to content

Change default log wait timeout to 10s #232

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hemildesai merged 2 commits into from
May 13, 2025
Merged

Change default log wait timeout to 10s #232

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2eb3ef6
Change default log wait timeout to 10s
hemildesai May 12, 2025
611c61f
fix
hemildesai May 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions nemo_run/run/torchx_backend/launcher.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,7 +122,7 @@ def wait_and_exit(
log: bool,
runner: Runner | None = None,
timeout: int = 10,
log_join_timeout: int = 600,
log_join_timeout: int = 10,
) -> specs.AppStatus:
if runner is None:
runner = get_runner()
Expand Down Expand Up @@ -161,7 +161,9 @@ def wait_and_exit(
logger.info(f"Job {app_id} finished: {status.state}")

if log_thread and log_thread.is_alive():
logger.debug("Waiting for log thread to complete...")
logger.warning(
f"Waiting for {app_id}'s log thread to complete for {log_join_timeout} seconds..."
)
log_thread.join(timeout=log_join_timeout)
if log_thread.is_alive():
logger.warning("Log thread did not complete within timeout, some logs may be missing")
Expand Down
Loading