lint

Author: mdavis36

csrc/fusion.h

@@ -71,7 +71,7 @@ class DynamicTransformConcretizationInfo;
 
 // Set the enum base to `int` so it can be safely serialized as a part of
 // serde::InputOutputAlias.
-enum class AllocationType : int {
+enum class AllocationType : int { // NOLINT(performance-enum-size)
   New, // Allocate a new buffer
   // Reuse the buffer allocated to `aliased_io`. For example, the tensor storing
   // BatchNorm's running mean. The output EMA is updated in place.
@@ -88,7 +88,7 @@ enum class AllocationType : int {
 
 std::ostream& operator<<(std::ostream& os, AllocationType);
 
-enum class OutputVisibility : int {
+enum class OutputVisibility : int { // NOLINT(performance-enum-size)
   kHidden,
   kVisible,
 };

csrc/ir/container.cpp

@@ -7,7 +7,6 @@
 // clang-format on
 #include "ir/container.h"
 
-#include "fusion.h"
 #include "instrumentation.h"
 #include "ir/base_nodes.h"
 #include "ir/builder.h"
@@ -19,9 +18,8 @@ namespace nvfuser {
 //! Return values in insertion order
 const std::deque<Val*> IrContainer::deterministic_vals() const noexcept {
   std::deque<Val*> vals_deque;
-  std::transform(
-      vals_up_.begin(),
-      vals_up_.end(),
+  std::ranges::transform(
+      vals_up_,
       std::back_inserter(vals_deque),
       [](const std::unique_ptr<Val>& val_up) { return val_up.get(); });
   return vals_deque;
@@ -30,9 +28,8 @@ const std::deque<Val*> IrContainer::deterministic_vals() const noexcept {
 //! Return expression in insertion order
 const std::deque<Expr*> IrContainer::deterministic_exprs() const noexcept {
   std::deque<Expr*> exprs_deque;
-  std::transform(
-      exprs_up_.begin(),
-      exprs_up_.end(),
+  std::ranges::transform(
+      exprs_up_,
       std::back_inserter(exprs_deque),
       [](const std::unique_ptr<Expr>& expr_up) { return expr_up.get(); });
   return exprs_deque;
@@ -43,9 +40,8 @@ const std::unordered_map<Val*, int64_t> IrContainer::deterministic_vals_map()
     const noexcept {
   std::unordered_map<Val*, int64_t> vals_map;
   int64_t count = 0;
-  std::transform(
-      vals_up_.begin(),
-      vals_up_.end(),
+  std::ranges::transform(
+      vals_up_,
       std::inserter(vals_map, vals_map.end()),
       [&count](const std::unique_ptr<Val>& val_up) {
         return std::make_pair(val_up.get(), count++);
@@ -58,9 +54,8 @@ const std::unordered_map<Expr*, int64_t> IrContainer::deterministic_exprs_map()
     const noexcept {
   std::unordered_map<Expr*, int64_t> exprs_map;
   int64_t count = 0;
-  std::transform(
-      exprs_up_.begin(),
-      exprs_up_.end(),
+  std::ranges::transform(
+      exprs_up_,
       std::inserter(exprs_map, exprs_map.end()),
       [&count](const std::unique_ptr<Expr>& expr_up) {
         return std::make_pair(expr_up.get(), count++);
@@ -119,9 +114,8 @@ void IrContainer::removeExpr(Expr* expr) {
   NVF_ERROR(
       exprs_.find(expr) != exprs_.end(),
       "Wanted to remove an expression but it doesn't exist in this container.");
-  auto expr_in_deque = std::find_if(
-      exprs_up_.begin(),
-      exprs_up_.end(),
+  auto expr_in_deque = std::ranges::find_if(
+      exprs_up_,
       [expr](std::unique_ptr<Expr>& expr_up) { return expr_up.get() == expr; });
 
   NVF_ERROR(
@@ -138,10 +132,9 @@ void IrContainer::removeVal(Val* val) {
   NVF_ERROR(
       vals_.find(val) != vals_.end(),
       "Wanted to remove a value but it doesn't exist in this container.");
-  auto val_in_deque = std::find_if(
-      vals_up_.begin(), vals_up_.end(), [val](std::unique_ptr<Val>& val_up) {
-        return val_up.get() == val;
-      });
+  auto val_in_deque = std::ranges::find_if(
+      vals_up_,
+      [val](std::unique_ptr<Val>& val_up) { return val_up.get() == val; });
 
   NVF_ERROR(
       val_in_deque != vals_up_.end(),

csrc/ir/utils.cpp

@@ -46,7 +46,7 @@ std::vector<int64_t> normalizeNew2Old(
     const std::vector<int64_t>& new2old_in,
     int64_t ndims) {
   NVF_CHECK(
-      (int64_t)new2old_in.size() == ndims,
+      std::cmp_equal(new2old_in.size(), ndims),
       "There must be a transpose mapping for each dimension in domain");
 
   // Canonicalize dimensions by wrapping each dim for the given ndims
@@ -74,7 +74,8 @@ std::vector<int64_t> normalizeNew2Old(
 
   // Error out if duplicate values are found.
   NVF_CHECK(
-      (int64_t)new2old.size() == ndims && old_pos_set.size() == new2old.size(),
+      std::cmp_equal(new2old.size(), ndims) &&
+          old_pos_set.size() == new2old.size(),
       "Duplicate entries in transformation map.");
 
   // END VALIDATION CHECKS
@@ -534,6 +535,7 @@ class ValReplacementMutator : public OptOutMutator {
           expr->outputs().begin(),
           expr->outputs().end());
     }
+    // NOLINTNEXTLINE(bugprone-nondeterministic-pointer-iteration-order)
     for (auto input : inputs) {
       outputs.erase(input);
     }
@@ -1057,6 +1059,7 @@ CompareDomainResult compareDomains(
     return v->as<IterDomain>()->getIterType() == IterType::Symbolic;
   };
   std::vector<Val*> ids_to_remove;
+  // NOLINTNEXTLINE(bugprone-nondeterministic-pointer-iteration-order)
   for (Val* id : frontier) {
     if (is_symb(id) && dom1_set.count(id)) {
       ids_to_remove.push_back(id);