-
Notifications
You must be signed in to change notification settings - Fork 74
skip nvfp4 gemm #5758
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
skip nvfp4 gemm #5758
Conversation
Greptile SummaryThis PR updates
Confidence Score: 5/5
Important Files Changed
Sequence DiagramsequenceDiagram
participant pytest as pytest
participant test as test_cutlass_nvfp4_gemm.py
participant utils as direct_utils
participant torch as torch.cuda
pytest->>test: Load test module
pytest->>test: Discover test functions
loop For each test function
pytest->>test: Check @skipif decorator
test->>utils: microarchitecture_is(10, 0)
utils->>torch: get_device_properties()
torch-->>utils: DeviceProperties(major, minor)
utils-->>test: major==10 and minor==0
alt GPU is compute cap 10.0
test-->>pytest: Run test
else GPU is not compute cap 10.0
test-->>pytest: Skip test
end
end
|
|
Review updated until commit 33d88bf Description
|
| Relevant files | |||
|---|---|---|---|
| Tests |
|
PR Reviewer Guide
Here are some key observations to aid the review process:
| 🧪 PR contains tests |
| ⚡ Recommended focus areas for review |
Architecture checking logic change
compute_cap < (10, 0) or compute_cap >= (12, 0) to using not microarchitecture_is(10, 0). This changes the logic from excluding both older (< 10.0) and newer (>= 12.0) architectures to only excluding non-10.0 architectures. The new logic would allow compute capability 11.x, 13.x, etc., which may not have been intended. The reason text also changed from "Nvfp4 Requires compute capability 10" to "Does not support blackwell compute 12.0", suggesting the intent was to exclude Blackwell specifically while potentially allowing other newer architectures. |
|
!test |
Similar to #5757