Skip to content

Commit ef5f878

Browse files
committed
Rename individual tracker implementation interfaces to be consistent
1 parent c77ba99 commit ef5f878

21 files changed

+46
-46
lines changed

docs/source/device/add_device.rst

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -138,7 +138,7 @@ Reference implementation — split across facade and live backend:
138138
(class ``Generic3AxisPedalTracker``): holds collection configuration, implements ``ITracker``, and
139139
exposes ``get_data(session)`` returning
140140
``Generic3AxisPedalOutputTrackedT`` by dispatching to the session’s
141-
``Generic3AxisPedalTrackerImpl`` (see :code-file:`src/core/deviceio_base/cpp/inc/deviceio_base/generic_3axis_pedal_tracker_base.hpp`).
141+
``IGeneric3AxisPedalTrackerImpl`` (see :code-file:`src/core/deviceio_base/cpp/inc/deviceio_base/generic_3axis_pedal_tracker_base.hpp`).
142142
- **Live backend** — :code-file:`src/core/live_trackers/cpp/live_generic_3axis_pedal_tracker_impl.cpp`
143143
(``LiveGeneric3AxisPedalTrackerImpl``): composes ``SchemaTracker``, implements ``update()`` and
144144
``serialize_all()``, and uses ``SchemaTracker::read_all_samples()`` with
@@ -211,7 +211,7 @@ Both exit after 100 samples, or press Ctrl+C to exit early.
211211
- **Generic3AxisPedalTracker** (tracker facade in ``deviceio_trackers``) — Concrete ``ITracker`` for
212212
``Generic3AxisPedalOutput``: holds configuration and
213213
``get_data(session)`` returning ``Generic3AxisPedalOutputTrackedT`` via the session’s
214-
``Generic3AxisPedalTrackerImpl``.
214+
``IGeneric3AxisPedalTrackerImpl``.
215215
- **DeviceIOSession** — Session manager: collects required OpenXR extensions from registered
216216
trackers, creates tracker implementations with session handles, and calls ``update()`` on all
217217
trackers during the update loop.

src/core/deviceio_base/cpp/inc/deviceio_base/controller_tracker_base.hpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10,8 +10,8 @@ namespace core
1010

1111
struct ControllerSnapshotTrackedT;
1212

13-
// Abstract base for controller tracker implementations.
14-
class ControllerTrackerImpl : public ITrackerImpl
13+
// Abstract base interface for controller tracker implementations.
14+
class IControllerTrackerImpl : public ITrackerImpl
1515
{
1616
public:
1717
virtual const ControllerSnapshotTrackedT& get_left_controller() const = 0;

src/core/deviceio_base/cpp/inc/deviceio_base/frame_metadata_tracker_oak_base.hpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,8 +12,8 @@ namespace core
1212

1313
struct FrameMetadataOakTrackedT;
1414

15-
// Abstract base for FrameMetadataTrackerOak implementations.
16-
class FrameMetadataTrackerOakImpl : public ITrackerImpl
15+
// Abstract base interface for FrameMetadataTrackerOak implementations.
16+
class IFrameMetadataTrackerOakImpl : public ITrackerImpl
1717
{
1818
public:
1919
virtual const FrameMetadataOakTrackedT& get_stream_data(size_t stream_index) const = 0;

src/core/deviceio_base/cpp/inc/deviceio_base/full_body_tracker_pico_base.hpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10,8 +10,8 @@ namespace core
1010

1111
struct FullBodyPosePicoTrackedT;
1212

13-
// Abstract base for full body tracker (PICO) implementations.
14-
class FullBodyTrackerPicoImpl : public ITrackerImpl
13+
// Abstract base interface for full body tracker (PICO) implementations.
14+
class IFullBodyTrackerPicoImpl : public ITrackerImpl
1515
{
1616
public:
1717
virtual const FullBodyPosePicoTrackedT& get_body_pose() const = 0;

src/core/deviceio_base/cpp/inc/deviceio_base/generic_3axis_pedal_tracker_base.hpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10,8 +10,8 @@ namespace core
1010

1111
struct Generic3AxisPedalOutputTrackedT;
1212

13-
// Abstract base for Generic3AxisPedalTracker implementations.
14-
class Generic3AxisPedalTrackerImpl : public ITrackerImpl
13+
// Abstract base interface for Generic3AxisPedalTracker implementations.
14+
class IGeneric3AxisPedalTrackerImpl : public ITrackerImpl
1515
{
1616
public:
1717
virtual const Generic3AxisPedalOutputTrackedT& get_data() const = 0;

src/core/deviceio_base/cpp/inc/deviceio_base/hand_tracker_base.hpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10,8 +10,8 @@ namespace core
1010

1111
struct HandPoseTrackedT;
1212

13-
// Abstract base for hand tracker implementations.
14-
class HandTrackerImpl : public ITrackerImpl
13+
// Abstract base interface for hand tracker implementations.
14+
class IHandTrackerImpl : public ITrackerImpl
1515
{
1616
public:
1717
virtual const HandPoseTrackedT& get_left_hand() const = 0;

src/core/deviceio_base/cpp/inc/deviceio_base/head_tracker_base.hpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10,8 +10,8 @@ namespace core
1010

1111
struct HeadPoseTrackedT;
1212

13-
// Abstract base for head tracker implementations.
14-
class HeadTrackerImpl : public ITrackerImpl
13+
// Abstract base interface for head tracker implementations.
14+
class IHeadTrackerImpl : public ITrackerImpl
1515
{
1616
public:
1717
virtual const HeadPoseTrackedT& get_head() const = 0;

src/core/deviceio_trackers/cpp/controller_tracker.cpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,12 +12,12 @@ namespace core
1212

1313
const ControllerSnapshotTrackedT& ControllerTracker::get_left_controller(const ITrackerSession& session) const
1414
{
15-
return static_cast<const ControllerTrackerImpl&>(session.get_tracker_impl(*this)).get_left_controller();
15+
return static_cast<const IControllerTrackerImpl&>(session.get_tracker_impl(*this)).get_left_controller();
1616
}
1717

1818
const ControllerSnapshotTrackedT& ControllerTracker::get_right_controller(const ITrackerSession& session) const
1919
{
20-
return static_cast<const ControllerTrackerImpl&>(session.get_tracker_impl(*this)).get_right_controller();
20+
return static_cast<const IControllerTrackerImpl&>(session.get_tracker_impl(*this)).get_right_controller();
2121
}
2222

2323
} // namespace core

src/core/deviceio_trackers/cpp/frame_metadata_tracker_oak.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@ FrameMetadataTrackerOak::FrameMetadataTrackerOak(const std::string& collection_p
3838
const FrameMetadataOakTrackedT& FrameMetadataTrackerOak::get_stream_data(const ITrackerSession& session,
3939
size_t stream_index) const
4040
{
41-
return static_cast<const FrameMetadataTrackerOakImpl&>(session.get_tracker_impl(*this)).get_stream_data(stream_index);
41+
return static_cast<const IFrameMetadataTrackerOakImpl&>(session.get_tracker_impl(*this)).get_stream_data(stream_index);
4242
}
4343

4444
} // namespace core

src/core/deviceio_trackers/cpp/full_body_tracker_pico.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ namespace core
1212

1313
const FullBodyPosePicoTrackedT& FullBodyTrackerPico::get_body_pose(const ITrackerSession& session) const
1414
{
15-
return static_cast<const FullBodyTrackerPicoImpl&>(session.get_tracker_impl(*this)).get_body_pose();
15+
return static_cast<const IFullBodyTrackerPicoImpl&>(session.get_tracker_impl(*this)).get_body_pose();
1616
}
1717

1818
} // namespace core

0 commit comments

Comments
 (0)