Skip to content

Fix checkpoint converter missing parallel group initialization#3217

Merged
dimapihtar merged 1 commit intoNVIDIA:mainfrom
yashaswikarnati:yash/fix-checkpoint-converter-parallel-groups
Feb 4, 2026
Merged

Fix checkpoint converter missing parallel group initialization#3217
dimapihtar merged 1 commit intoNVIDIA:mainfrom
yashaswikarnati:yash/fix-checkpoint-converter-parallel-groups

Conversation

@yashaswikarnati
Copy link
Contributor

Add fake process groups required by ProcessGroupCollection during checkpoint conversion. Also add accelerate to mlm optional deps.

Test:

uv pip install -e ".[mlm]"
python tools/checkpoint/convert.py \
  --bf16 --model-type GPT --loader llama_mistral --saver core \
  --target-tensor-parallel-size 1 --checkpoint-type hf \
  --load-dir <hf-model-path> --save-dir ./converted \
  --tokenizer-model <hf-model-path> --model-size mistral

What does this PR do ?

⚠️ For major changes (either in lines of code or in its impact), please make sure to first share a design doc with the team. If you're unsure what's the best way to do so, contact the @mcore-oncall.

Contribution process

flowchart LR
    A[Pre-checks] --> B[PR Tests]
    subgraph Code Review/Approval
        C1[Expert Review] --> C2[Final Review]
    end
    B --> C1
    C2 --> D[Merge]
Loading

Pre-checks

  • I want this PR in a versioned release and have added the appropriate Milestone (e.g., Core 0.8)
  • I have added relevant unit tests
  • I have added relevant functional tests
  • I have added proper typing to my code Typing guidelines
  • I have added relevant documentation
  • I have run the autoformatter.sh on my PR

Code review

The following process is enforced via the CODEOWNERS file for changes into megatron/core. For changes outside of megatron/core, it is up to the PR author whether or not to tag the Final Reviewer team.

For MRs into `main` branch

Feel free to message or comment the @mcore-oncall to help accelerate your merge into main. The less complex your PR is, the faster it will be approved and merged!

(Step 1): Add PR label Expert Review

(Step 2): Collect the expert reviewers reviews

  1. Attach the Expert Review label when your PR is ready for review.
  2. GitHub auto-assigns expert reviewers based on your changes. They will get notified and pick up your PR soon.

⚠️ Only proceed to the next step once all reviewers have approved, merge-conflict are resolved and the CI is passing.
Final Review might get declined if these requirements are not fulfilled.

(Step 3): Final Review

  1. Add Final Review label
  2. GitHub auto-assigns final reviewers based on your changes. They will get notified and pick up your PR soon.

(Optional Step 4): Cherry-pick into release branch

If this PR also needs to be merged into core_r* release branches, after this PR has been merged, select Cherry-pick to open a new PR into the release branch.

For MRs into `dev` branch The proposed review process for `dev` branch is under active discussion.

MRs are mergable after one approval by either eharper@nvidia.com or zijiey@nvidia.com.

Merging your PR

Any member of core-adlr and core-nemo will be able to merge your PR.

Add fake process groups required by ProcessGroupCollection during
checkpoint conversion. Also add accelerate to mlm optional deps.

Test:
```
uv pip install -e ".[mlm]"
python tools/checkpoint/convert.py \
  --bf16 --model-type GPT --loader llama_mistral --saver core \
  --target-tensor-parallel-size 1 --checkpoint-type hf \
  --load-dir <hf-model-path> --save-dir ./converted \
  --tokenizer-model <hf-model-path> --model-size mistral
```
@faradawn
Copy link
Contributor

faradawn commented Feb 3, 2026

Hi @yashaswikarnati , it successful resolved the issue of data parallel group uninitialized. Thanks a lot!

Copy link
Contributor

@faradawn faradawn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested successfully for Mixtral model

@faradawn
Copy link
Contributor

faradawn commented Feb 3, 2026

This PR adds more initialization: https://github.com/NVIDIA/Megatron-LM/pull/3111/changes. Potentially safer?

Copy link
Contributor

@dimapihtar dimapihtar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you!

@dimapihtar dimapihtar added this pull request to the merge queue Feb 4, 2026
Merged via the queue into NVIDIA:main with commit f3e6cc8 Feb 4, 2026
51 checks passed
daiyaanarfeen pushed a commit to daiyaanarfeen/Megatron-LM that referenced this pull request Feb 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants