Skip to content

Miscellaneous inference cleanup (Replay of !2955)#3232

Merged
ko3n1g merged 62 commits intoNVIDIA:mainfrom
santhnm2:engine_context_cleanup
Feb 4, 2026
Merged

Miscellaneous inference cleanup (Replay of !2955)#3232
ko3n1g merged 62 commits intoNVIDIA:mainfrom
santhnm2:engine_context_cleanup

Conversation

@santhnm2
Copy link
Contributor

@santhnm2 santhnm2 commented Feb 3, 2026

What does this PR do ?

This PR makes the following quality-of-life improvements to inference:

  • Removes InferenceWrapperConfig.
  • Consolidates all the redundant TransformerConfig arguments in DynamicInferenceContext into a single model_config argument.
  • Adds an InferenceConfig object that has all the inference-related configuration parameters from the command line arguments.
  • Adds megatron/inference as a location for convenience functions to initialize an InferenceConfig or DynamicInferenceEngine using the global args.
  • Updates all driver scripts to use these convenience functions.
  • Moves some commonly used utility functions out of gpt_dynamic_inference.py into megatron/inference/utils.py.
  • Deprecates the pipeline_parallel_large_batch function in AbstractModelInferenceWrapper
  • Removes simple_text_generation_controller.py
  • Ensures that the static engine generate function always returns InferenceRequest objects instead of DynamicInferenceRequestRecord objects.

Contribution process

flowchart LR
    A[Pre-checks] --> B[PR Tests]
    subgraph Code Review/Approval
        C1[Expert Review] --> C2[Final Review]
    end
    B --> C1
    C2 --> D[Merge]
Loading

Pre-checks

  • I want this PR in a versioned release and have added the appropriate Milestone (e.g., Core 0.8)
  • I have added relevant unit tests
  • I have added relevant functional tests
  • I have added proper typing to my code Typing guidelines
  • I have added relevant documentation
  • I have run the autoformatter.sh on my PR

Code review

The following process is enforced via the CODEOWNERS file for changes into megatron/core. For changes outside of megatron/core, it is up to the PR author whether or not to tag the Final Reviewer team.

For MRs into `main` branch

Feel free to message or comment the @mcore-oncall to help accelerate your merge into main. The less complex your PR is, the faster it will be approved and merged!

(Step 1): Add PR label Expert Review

(Step 2): Collect the expert reviewers reviews

  1. Attach the Expert Review label when your PR is ready for review.
  2. GitHub auto-assigns expert reviewers based on your changes. They will get notified and pick up your PR soon.

⚠️ Only proceed to the next step once all reviewers have approved, merge-conflict are resolved and the CI is passing.
Final Review might get declined if these requirements are not fulfilled.

(Step 3): Final Review

  1. Add Final Review label
  2. GitHub auto-assigns final reviewers based on your changes. They will get notified and pick up your PR soon.

(Optional Step 4): Cherry-pick into release branch

If this PR also needs to be merged into core_r* release branches, after this PR has been merged, select Cherry-pick to open a new PR into the release branch.

For MRs into `dev` branch The proposed review process for `dev` branch is under active discussion.

MRs are mergable after one approval by either eharper@nvidia.com or zijiey@nvidia.com.

Merging your PR

Any member of core-adlr and core-nemo will be able to merge your PR.

Signed-off-by: Keshav Santhanam <ksanthanam@nvidia.com>
Signed-off-by: Keshav Santhanam <ksanthanam@nvidia.com>
Signed-off-by: Keshav Santhanam <ksanthanam@nvidia.com>
Signed-off-by: Keshav Santhanam <ksanthanam@nvidia.com>
Signed-off-by: Keshav Santhanam <ksanthanam@nvidia.com>
Signed-off-by: Keshav Santhanam <ksanthanam@nvidia.com>
Signed-off-by: Keshav Santhanam <ksanthanam@nvidia.com>
Signed-off-by: Keshav Santhanam <ksanthanam@nvidia.com>
Signed-off-by: Keshav Santhanam <ksanthanam@nvidia.com>
Signed-off-by: Keshav Santhanam <ksanthanam@nvidia.com>
Signed-off-by: Keshav Santhanam <ksanthanam@nvidia.com>
Signed-off-by: Keshav Santhanam <ksanthanam@nvidia.com>
Signed-off-by: Keshav Santhanam <ksanthanam@nvidia.com>
Signed-off-by: Keshav Santhanam <ksanthanam@nvidia.com>
Signed-off-by: Keshav Santhanam <ksanthanam@nvidia.com>
Signed-off-by: Keshav Santhanam <ksanthanam@nvidia.com>
Signed-off-by: Keshav Santhanam <ksanthanam@nvidia.com>
Signed-off-by: Keshav Santhanam <ksanthanam@nvidia.com>
Signed-off-by: Keshav Santhanam <ksanthanam@nvidia.com>
Signed-off-by: Keshav Santhanam <ksanthanam@nvidia.com>
Signed-off-by: Keshav Santhanam <ksanthanam@nvidia.com>
Signed-off-by: Keshav Santhanam <ksanthanam@nvidia.com>
Signed-off-by: Keshav Santhanam <ksanthanam@nvidia.com>
@santhnm2
Copy link
Contributor Author

santhnm2 commented Feb 4, 2026

/ok to test 5953507

@santhnm2
Copy link
Contributor Author

santhnm2 commented Feb 4, 2026

/ok to test 60c03cf

Signed-off-by: Keshav Santhanam <ksanthanam@nvidia.com>
@santhnm2
Copy link
Contributor Author

santhnm2 commented Feb 4, 2026

/ok to test aff0fa2

@santhnm2
Copy link
Contributor Author

santhnm2 commented Feb 4, 2026

/ok to test 3d00cc5

@ko3n1g ko3n1g merged commit 43db8c1 into NVIDIA:main Feb 4, 2026
159 of 173 checks passed
daiyaanarfeen pushed a commit to daiyaanarfeen/Megatron-LM that referenced this pull request Feb 23, 2026
Signed-off-by: Keshav Santhanam <ksanthanam@nvidia.com>
Co-authored-by: oliver könig <okoenig@nvidia.com>
ko3n1g added a commit to ko3n1g/Megatron-LM that referenced this pull request Mar 15, 2026
ko3n1g added a commit to ko3n1g/Megatron-LM that referenced this pull request Mar 15, 2026
This reverts commit 43db8c1.

Signed-off-by: oliver könig <okoenig@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants