Skip to content

fix: Env var for HybridEP#4146

Open
ko3n1g wants to merge 1 commit intoNVIDIA:mainfrom
ko3n1g:ko3n1g/cp/4f98be5158db541f096ee906db5f4eb0950f6f84
Open

fix: Env var for HybridEP#4146
ko3n1g wants to merge 1 commit intoNVIDIA:mainfrom
ko3n1g:ko3n1g/cp/4f98be5158db541f096ee906db5f4eb0950f6f84

Conversation

@ko3n1g
Copy link
Copy Markdown
Contributor

@ko3n1g ko3n1g commented Apr 4, 2026

What does this PR do ?

We need this after bumping HybridEP to head

Contribution process

Pre-checks

  • I have added relevant unit tests
  • I have added relevant functional tests
  • I have added proper typing to my code Typing guidelines
  • I have added relevant documentation
  • I have run the autoformatter.sh on my PR

Code review

Feel free to message or comment the @mcore-oncall to help accelerate your merge into main. The less complex your PR is, the faster it will be approved and merged!

All PRs start as draft. If you open a non-draft PR, it will be automatically converted to draft.

Step 1: Mark PR as "Ready for Review"

  1. When your PR is ready, click Ready for Review.
  2. An oncall reviewer is auto-assigned and expert reviewers are notified based on your changes.
    • Some PRs may jump straight to step 2. This is determined by .github/CODEOWNERS.

⚠️ Only mark as ready once merge-conflicts are resolved and the CI is passing.
Final Review might get declined if these requirements are not fulfilled.

Step 2: Final Review

For PRs that change megatron/core, once all expert reviewers have approved, the Final Review label is applied automatically and final reviewers are assigned.

For PRs outside megatron/core, this step is skipped.

Step 3: Approved

Once all required reviewers have approved, the Approved label is applied automatically.

Merge

Any member of mcore-engineers will be able to merge your PR.

For MRs into `dev` branch The proposed review process for `dev` branch is under active discussion.

MRs are mergable after one approval by either eharper@nvidia.com or zijiey@nvidia.com.

Signed-off-by: oliver könig <okoenig@nvidia.com>
@svcnvidia-nemo-ci svcnvidia-nemo-ci marked this pull request as draft April 4, 2026 10:16
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 4, 2026

This PR has been automatically converted to draft because all PRs must start as drafts.

When you are ready for review, click Ready for Review to begin the review process. This will:

  1. Add the oncall reviewer (optional reviewer)
  2. Add required review teams based on your changes

See the contribution guide for more details.

@copy-pr-bot
Copy link
Copy Markdown

copy-pr-bot bot commented Apr 4, 2026

Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

@svcnvidia-nemo-ci svcnvidia-nemo-ci added this to the Core 0.16 milestone Apr 4, 2026
@ko3n1g ko3n1g marked this pull request as ready for review April 4, 2026 10:17
@svcnvidia-nemo-ci svcnvidia-nemo-ci requested a review from a team April 4, 2026 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants