Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes the POC shutdown functionality by clarifying the shutdown methods used in different scenarios and removing outdated documentation related to deprecated SP (service provider) commands.
- Updates print statements to clarify whether shutdown uses FLARE API or stop_fl.sh script
- Removes documentation for deprecated SP-related commands (list_sp, get_active_sp, promote_sp)
- Cleans up migration documentation to remove references to removed SP commands
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| nvflare/tool/poc/poc_commands.py | Updates shutdown print statements to clarify shutdown method |
| docs/real_world_fl/operation.rst | Removes deprecated SP command documentation |
| docs/real_world_fl/migrating_to_flare_api.rst | Removes SP commands from migration table |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
yanchengnv
reviewed
Aug 22, 2025
Collaborator
yanchengnv
left a comment
There was a problem hiding this comment.
See my comment about wait_for_system_shutdown.
chesterxgchen
approved these changes
Aug 25, 2025
Collaborator
Author
|
/build |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix poc shutdown
Description
Fix poc shutdown
Types of changes
./runtest.sh.