Skip to content

Fix poc shutdown#3626

Merged
YuanTingHsieh merged 5 commits intoNVIDIA:mainfrom
YuanTingHsieh:fix_poc_shutdown
Aug 26, 2025
Merged

Fix poc shutdown#3626
YuanTingHsieh merged 5 commits intoNVIDIA:mainfrom
YuanTingHsieh:fix_poc_shutdown

Conversation

@YuanTingHsieh
Copy link
Collaborator

Fix poc shutdown

Description

Fix poc shutdown

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Quick tests passed locally by running ./runtest.sh.
  • In-line docstrings updated.
  • Documentation updated.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes the POC shutdown functionality by clarifying the shutdown methods used in different scenarios and removing outdated documentation related to deprecated SP (service provider) commands.

  • Updates print statements to clarify whether shutdown uses FLARE API or stop_fl.sh script
  • Removes documentation for deprecated SP-related commands (list_sp, get_active_sp, promote_sp)
  • Cleans up migration documentation to remove references to removed SP commands

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File Description
nvflare/tool/poc/poc_commands.py Updates shutdown print statements to clarify shutdown method
docs/real_world_fl/operation.rst Removes deprecated SP command documentation
docs/real_world_fl/migrating_to_flare_api.rst Removes SP commands from migration table

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Copy link
Collaborator

@yanchengnv yanchengnv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See my comment about wait_for_system_shutdown.

@YuanTingHsieh
Copy link
Collaborator Author

/build

@YuanTingHsieh YuanTingHsieh merged commit fa8b3e2 into NVIDIA:main Aug 26, 2025
20 of 21 checks passed
@YuanTingHsieh YuanTingHsieh deleted the fix_poc_shutdown branch August 26, 2025 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants