[Doc] Flare Overview, System architect updates and new how-to guide structure [skip ci]#3922
[Doc] Flare Overview, System architect updates and new how-to guide structure [skip ci]#3922chesterxgchen wants to merge 49 commits intoNVIDIA:mainfrom
Conversation
Greptile SummaryThis PR significantly improves NVIDIA FLARE's documentation structure and content. The changes include: Major Structural Improvements:
New Documentation Content:
Visual Assets:
Documentation Quality:
Placeholder Content:
All changes are documentation-only with no code modifications. The restructuring makes architecture information more discoverable and provides practical task-oriented guides for users. Confidence Score: 5/5
Important Files Changed
Sequence DiagramsequenceDiagram
participant Author as PR Author
participant Docs as Documentation
participant Overview as FLARE Overview
participant SysArch as System Architecture
participant HowTo as How-To Guides
participant Users as Documentation Users
Author->>Docs: Update FLARE overview with latest features
Author->>Docs: Delete old flare_system_architecure.rst
Author->>SysArch: Create new system_architecture/ folder
Author->>SysArch: Write comprehensive system_architecture.rst
Author->>SysArch: Add design_principles.rst
Author->>SysArch: Move security_overview.rst to system_architecture/
Author->>SysArch: Move cellnet_architecture.rst to system_architecture/
Author->>Docs: Add system_architecture/index.rst to main navigation
Author->>HowTo: Create new how-to-guide/ structure
Author->>HowTo: Add develop/ subfolder with API guides
Author->>HowTo: Add production/ subfolder with deployment guides
Author->>HowTo: Create different_flare_apis.rst guide
Author->>HowTo: Create dl_to_fl_guide.rst
Author->>HowTo: Create fed_analytics.rst guide
Author->>HowTo: Create simulation.rst guide
Author->>HowTo: Add placeholder files (use_he.rst, use_dp.rst)
Author->>Overview: Add flare_api_evolution.rst to programming_guide
Author->>Docs: Add reference labels to hello-world examples
Author->>Docs: Add new architecture diagrams (7 new images)
Author->>Docs: Update main index.rst navigation structure
Docs->>Users: Provide improved documentation structure
Docs->>Users: Enable easier navigation to architecture info
Docs->>Users: Offer practical how-to guides
Users->>Docs: Access comprehensive, well-organized documentation
|
Greptile found no issues!From now on, if a review finishes and we haven't found any issues, we will not post anything, but you can confirm that we reviewed your changes in the status check section. This feature can be toggled off in your Code Review Settings by deselecting "Create a status check for each PR". |
There was a problem hiding this comment.
Additional Comments (1)
-
docs/programming_guide/execution_api_type/client_api.rst, line 194 (link)syntax: incorrect reStructuredText syntax - triple backticks don't create references in RST
16 files reviewed, 1 comment
|
/build |
|
/build |
There was a problem hiding this comment.
Additional Comments (9)
-
docs/hello-world/hello-tf/index.rst, line 56 (link)syntax: Directory name should be 'hello-tf' not 'hello-pt' to match the actual example being documented
-
docs/index.rst, line 38 (link)logic: Duplicate confidential computing reference - line 18 adds
user_guide/confidential_computing/indexto Introduction section, but line 38 still has the oldconfidential_computing/indexentry in Guides section. Should the confidential_computing/index entry on line 38 be removed since it's now included in the Introduction section on line 18? -
docs/programming_guide/flare_api_evolution.rst, line 44 (link)syntax: Missing period at end of sentence
-
docs/programming_guide/flare_api_evolution.rst, line 150 (link)syntax: Missing article 'a' before 'job'
-
docs/hello-world/hello-tabular-stats/index.rst, line 96 (link)syntax: Markdown link syntax
[adult dataset](https://archive.ics.uci.edu/dataset/2/adult)is incorrect for RST format -
docs/hello-world/hello-tabular-stats/index.rst, line 204-206 (link)syntax: Markdown-style headers
## Visualizationare incorrect for RST format -
docs/programming_guide/execution_api_type/client_api.rst, line 69 (link)syntax: Incomplete sentence - missing completion after 'job Recipe and the'
-
docs/how-to-guide/production/setup_nvflare.rst, line 209 (link)style: Uses
@in email addresses without code formattingNote: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!
-
docs/how-to-guide/develop/fed_analytics.rst, line 23 (link)logic: mentions min and max as common outputs but line 46 states they're excluded for privacy
29 files reviewed, 9 comments
|
/build |
|
/build |
|
/build |
|
this already merged using other 2 PRs, closing |
Description
Types of changes
./runtest.sh.