Update conditional None handling (#436)

thomasdhc · web-flow · commit 35e439393e2e · 2024-10-01T19:29:11.000-07:00
* Update conditional None handling

* Formatting

---------

Co-authored-by: Dong Hyuk Chang &lt;donghyukc@nvidia.com&gt;
diff --git a/launcher_scripts/nemo_launcher/collections/eval_harness/lm_eval/models/nemo_gpt3.py b/launcher_scripts/nemo_launcher/collections/eval_harness/lm_eval/models/nemo_gpt3.py
@@ -149,7 +149,10 @@ def setup_trainer_and_model(args):
             )
             if trainer.precision == "16":
                 pretrained_cfg.megatron_amp_O2 = False
-            if args.dist_ckpt_load_strictness is not None:
+            if (
+                args.dist_ckpt_load_strictness is not None
+                and args.dist_ckpt_load_strictness != "None"
+            ):
                 pretrained_cfg.dist_ckpt_load_strictness = (
                     args.dist_ckpt_load_strictness
                 )

Original file line number	Diff line number	Diff line change
`@@ -149,7 +149,10 @@ def setup_trainer_and_model(args):`
`149`	`149`	`)`
`150`	`150`	`if trainer.precision == "16":`
`151`	`151`	`pretrained_cfg.megatron_amp_O2 = False`
`152`		`- if args.dist_ckpt_load_strictness is not None:`
	`152`	`+ if (`
	`153`	`+ args.dist_ckpt_load_strictness is not None`
	`154`	`+ and args.dist_ckpt_load_strictness != "None"`
	`155`	`+ ):`
`153`	`156`	`pretrained_cfg.dist_ckpt_load_strictness = (`
`154`	`157`	`args.dist_ckpt_load_strictness`
`155`	`158`	`)`