Skip to content

Commit a0a3009

Browse files
authored
Dont include imagePullSecret with empty name in service chart. (#199)
* Dont include imagePullSecret if there is no imagePullSecret set * Update router and web-ui as well * Keep at version 1.0.1 for all charts
1 parent 7b74914 commit a0a3009

File tree

9 files changed

+16
-2
lines changed

9 files changed

+16
-2
lines changed

deployments/charts/quick-start/Chart.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@ dependencies:
3232
version: 1.0.1
3333
repository: file://../web-ui
3434
- name: router
35-
version: 1.0.0
35+
version: 1.0.1
3636
repository: file://../router
3737
- name: backend-operator
3838
version: 1.0.1

deployments/charts/router/Chart.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ type: application
3030
# This is the chart version. This version number should be incremented each time you make changes
3131
# to the chart and its templates, including the app version.
3232
# Versions are expected to follow Semantic Versioning (https://semver.org/)
33-
version: 1.0.0
33+
version: 1.0.1
3434

3535

3636
# This is the version number of the application being deployed. This version number should be

deployments/charts/router/templates/router-service.yaml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -63,8 +63,10 @@ spec:
6363
tolerations:
6464
{{- toYaml . | nindent 8 }}
6565
{{- end }}
66+
{{- if .Values.global.imagePullSecret }}
6667
imagePullSecrets:
6768
- name: {{ .Values.global.imagePullSecret }}
69+
{{- end }}
6870
serviceAccountName: {{ .Values.services.service.serviceAccountName | default "default" }}
6971
{{- with .Values.services.service.initContainers }}
7072
initContainers:

deployments/charts/service/templates/agent-service.yaml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -62,8 +62,10 @@ spec:
6262
{{- end}}
6363
tolerations:
6464
{{ toYaml .Values.services.agent.tolerations | nindent 8 }}
65+
{{- if .Values.global.imagePullSecret }}
6566
imagePullSecrets:
6667
- name: {{ .Values.global.imagePullSecret }}
68+
{{- end }}
6769
serviceAccountName: {{ include "osmo.service-account-name" (dict "serviceAccountName" .Values.services.agent.serviceAccountName "Values" .Values) }}
6870
{{- with .Values.services.agent.initContainers }}
6971
initContainers:

deployments/charts/service/templates/api-service.yaml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -61,8 +61,10 @@ spec:
6161
{{- end}}
6262
tolerations:
6363
{{ toYaml .Values.services.service.tolerations | nindent 8 }}
64+
{{- if .Values.global.imagePullSecret }}
6465
imagePullSecrets:
6566
- name: {{ .Values.global.imagePullSecret }}
67+
{{- end }}
6668
serviceAccountName: {{ include "osmo.service-account-name" (dict "serviceAccountName" .Values.services.service.serviceAccountName "Values" .Values) }}
6769
{{- with .Values.services.service.initContainers }}
6870
initContainers:

deployments/charts/service/templates/delayed-job-monitor.yaml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -43,8 +43,10 @@ spec:
4343
{{- end}}
4444
tolerations:
4545
{{ toYaml .Values.services.delayedJobMonitor.tolerations | nindent 8 }}
46+
{{- if .Values.global.imagePullSecret }}
4647
imagePullSecrets:
4748
- name: {{ .Values.global.imagePullSecret }}
49+
{{- end }}
4850
serviceAccountName: {{ include "osmo.service-account-name" (dict "serviceAccountName" .Values.services.delayedJobMonitor.serviceAccountName "Values" .Values) }}
4951
{{- with .Values.services.delayedJobMonitor.initContainers }}
5052
initContainers:

deployments/charts/service/templates/logger-service.yaml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -62,8 +62,10 @@ spec:
6262
{{- end}}
6363
tolerations:
6464
{{ toYaml .Values.services.logger.tolerations | nindent 8 }}
65+
{{- if .Values.global.imagePullSecret }}
6566
imagePullSecrets:
6667
- name: {{ .Values.global.imagePullSecret }}
68+
{{- end }}
6769
serviceAccountName: {{ include "osmo.service-account-name" (dict "serviceAccountName" .Values.services.logger.serviceAccountName "Values" .Values) }}
6870
{{- with .Values.services.logger.initContainers }}
6971
initContainers:

deployments/charts/service/templates/worker.yaml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -54,8 +54,10 @@ spec:
5454
{{- end}}
5555
tolerations:
5656
{{ toYaml .Values.services.worker.tolerations | nindent 8 }}
57+
{{- if .Values.global.imagePullSecret }}
5758
imagePullSecrets:
5859
- name: {{ .Values.global.imagePullSecret }}
60+
{{- end }}
5961
serviceAccountName: {{ include "osmo.service-account-name" (dict "serviceAccountName" .Values.services.worker.serviceAccountName "Values" .Values) }}
6062
{{- with .Values.services.worker.initContainers }}
6163
initContainers:

deployments/charts/web-ui/templates/ui.yaml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -60,8 +60,10 @@ spec:
6060
{{- end}}
6161
tolerations:
6262
{{ toYaml .Values.services.ui.tolerations | nindent 8 }}
63+
{{- if .Values.global.imagePullSecret }}
6364
imagePullSecrets:
6465
- name: {{ .Values.global.imagePullSecret }}
66+
{{- end }}
6567
{{- if .Values.services.ui.initContainers }}
6668
initContainers:
6769
{{- toYaml .Values.services.ui.initContainers | nindent 6 }}

0 commit comments

Comments
 (0)