Skip to content

Commit 35ba03b

Browse files
committed
activate NCCL_SYMMETRIC auto-tuning
Signed-off-by: Ludwig Schneider <lschneider@nvidia.com>
1 parent cfebfbb commit 35ba03b

File tree

1 file changed

+2
-3
lines changed

1 file changed

+2
-3
lines changed

tensorrt_llm/_torch/custom_ops/torch_custom_ops.py

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1695,8 +1695,7 @@ def get_valid_tactics(
16951695
**kwargs,
16961696
) -> List[int]:
16971697
valid_strategies = [
1698-
# TODO: NCCL_SYMMETRIC will cause hang during tuning process
1699-
# AllReduceStrategy.NCCL_SYMMETRIC.value,
1698+
AllReduceStrategy.NCCL_SYMMETRIC.value,
17001699
AllReduceStrategy.NCCL.value,
17011700
]
17021701
# Fallback in allreduceOp is set to NCCL_SYMMETRIC as default
@@ -1725,7 +1724,7 @@ def forward(
17251724
input, residual, norm_weight, scale, bias, workspace = inputs
17261725
if tactic == -1:
17271726
# TODO: Use NCCL instead of NCCL_SYMMETRIC to avoid hanging during tuning process
1728-
tactic = AllReduceStrategy.NCCL.value
1727+
tactic = AllReduceStrategy.NCCL_SYMMETRIC.value
17291728

17301729
return torch.ops.trtllm.allreduce(
17311730
input,

0 commit comments

Comments
 (0)