Skip to content

Commit 4da0e14

Browse files
authored
[None][test] add ntp tolerance in time metrics verification (#9741)
Signed-off-by: zhengd-nv <[email protected]>
1 parent 383178c commit 4da0e14

File tree

1 file changed

+6
-3
lines changed

1 file changed

+6
-3
lines changed

tests/integration/defs/disaggregated/test_disaggregated.py

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -114,13 +114,16 @@ def validate_timing_metrics(perf_metrics_item, request_context=""):
114114
)), f"gen server_first_token_time is not numeric in {request_context}"
115115
assert gen_server_arrival <= gen_server_first_token, f"gen server_arrival_time > server_first_token_time in {request_context}"
116116

117+
# Network Time Protocol can ensure ms-level accuracy in LAN
118+
ntp_tolerance = 1e-3
119+
117120
# Validate timing relationships between different levels
118121
# Disaggregated server should receive request before individual servers
119-
assert disagg_arrival <= ctx_server_arrival, f"disagg_arrival > ctx_server_arrival in {request_context}"
120-
assert disagg_arrival <= gen_server_arrival, f"disagg_arrival > gen_server_arrival in {request_context}"
122+
assert disagg_arrival - ntp_tolerance <= ctx_server_arrival, f"disagg_arrival > ctx_server_arrival in {request_context}"
123+
assert disagg_arrival - ntp_tolerance <= gen_server_arrival, f"disagg_arrival > gen_server_arrival in {request_context}"
121124

122125
# Context should complete before generation starts
123-
assert ctx_server_first_token <= gen_server_arrival, f"ctx_server_first_token > gen_server_arrival in {request_context}"
126+
assert ctx_server_first_token - ntp_tolerance <= gen_server_arrival, f"ctx_server_first_token > gen_server_arrival in {request_context}"
124127

125128
# Validate internal timing consistency
126129
ctx_arrival_time = ctx_metrics["arrival_time"]

0 commit comments

Comments
 (0)