Skip to content

Commit 562f995

Browse files
committed
use get_free_port_in_ci
Signed-off-by: Lizhi Zhou <1432185+reasonsolo@users.noreply.github.com>
1 parent 71e42bb commit 562f995

File tree

3 files changed

+8
-13
lines changed

3 files changed

+8
-13
lines changed

tests/integration/defs/disaggregated/test_auto_scaling.py

Lines changed: 8 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -12,9 +12,9 @@
1212
import pytest
1313
import requests
1414
import yaml
15+
from defs.common import get_free_port_in_ci as get_free_port
1516
from defs.conftest import llm_models_root
1617

17-
from tensorrt_llm._utils import get_free_port
1818
from tensorrt_llm.logger import logger
1919

2020
HEARTBEAT_INTERVAL = 1
@@ -454,7 +454,7 @@ async def test_worker_restart(model_name, disagg_server_config, worker_config,
454454
port=disagg_port)
455455
print(response)
456456
# kill gen1, the request should fail
457-
terminate(gen_worker1, release_port=False)
457+
terminate(gen_worker1, release_port=True)
458458
await asyncio.sleep(CHECK_STATUS_INTERVAL)
459459
verify_cluster_info(False, 1, 0, port=disagg_port)
460460
with pytest.raises(Exception):
@@ -480,7 +480,7 @@ async def test_worker_restart(model_name, disagg_server_config, worker_config,
480480
assert len(response.choices[0].text) >= 1
481481

482482
# kill ctx1, the request should fail
483-
terminate(ctx_worker1, release_port=False)
483+
terminate(ctx_worker1, release_port=True)
484484
await asyncio.sleep(CHECK_STATUS_INTERVAL)
485485
verify_cluster_info(False, 0, 1, port=disagg_port)
486486
with pytest.raises(Exception):
@@ -500,16 +500,16 @@ async def test_worker_restart(model_name, disagg_server_config, worker_config,
500500
assert len(response.choices[0].text) >= 1
501501

502502
# start ctx1 and gen1 again, we have 2 ctxs and 2 gens now
503-
await wait_for_port_released(ctx_worker1.port)
504-
await wait_for_port_released(gen_worker1.port)
505503
ctx_worker1 = run_ctx_worker(model_name,
506504
worker_config,
507505
work_dir,
508-
port=ctx_worker1.port)
506+
port=0,
507+
device=0)
509508
gen_worker1 = run_gen_worker(model_name,
510509
worker_config,
511510
work_dir,
512-
port=gen_worker1.port)
511+
port=0,
512+
device=1)
513513
await wait_for_worker_ready(ctx_worker1.port)
514514
await wait_for_worker_ready(gen_worker1.port)
515515
await asyncio.sleep(CHECK_STATUS_INTERVAL)
@@ -556,6 +556,7 @@ async def test_disagg_server_restart(model_name, disagg_server_config,
556556
terminate(disagg_server)
557557
# wait for the port to be released, so we can rebind the new process to the same port
558558
await wait_for_port_released(disagg_port)
559+
await asyncio.sleep(CHECK_STATUS_INTERVAL)
559560

560561
with pytest.raises(requests.exceptions.RequestException):
561562
verify_cluster_info(False,

tests/integration/test_lists/qa/llm_function_core_sanity.txt

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -251,11 +251,6 @@ disaggregated/test_workers.py::test_workers_conditional_disaggregation[TinyLlama
251251
disaggregated/test_workers.py::test_workers_kv_cache_aware_router_eviction[TinyLlama-1.1B-Chat-v1.0]
252252
disaggregated/test_workers.py::test_workers_kv_cache_aware_router[TinyLlama-1.1B-Chat-v1.0]
253253
disaggregated/test_workers.py::test_workers_kv_cache_events[TinyLlama-1.1B-Chat-v1.0]
254-
disaggregated/test_auto_scaling.py::test_service_discovery[etcd-load_balancing]
255-
disaggregated/test_auto_scaling.py::test_service_discovery[http-load_balancing]
256-
disaggregated/test_auto_scaling.py::test_worker_restart[etcd-round_robin]
257-
disaggregated/test_auto_scaling.py::test_worker_restart[http-round_robin]
258-
disaggregated/test_auto_scaling.py::test_worker_restart[http-kv_cache_aware]
259254
test_e2e.py::test_openai_chat_harmony
260255
test_e2e.py::test_openai_consistent_chat
261256
test_e2e.py::test_openai_multi_chat_example

tests/integration/test_lists/waives.txt

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -454,7 +454,6 @@ accuracy/test_cli_flow.py::TestPhi3Small128kInstruct::test_auto_dtype SKIP (http
454454
accuracy/test_cli_flow.py::TestPhi3_5MiniInstruct::test_auto_dtype SKIP (https://nvbugs/5744293)
455455
unittest/_torch/auto_deploy/unit/singlegpu/models/test_llama4_vlm_patch.py::test_build_run_llama4_vlm SKIP (https://nvbugs/5747878)
456456
accuracy/test_llm_api_pytorch.py::TestDeepSeekV3Lite::test_nvfp4_4gpus_online_eplb[fp8kv=True-moe_backend=TRTLLM] SKIP (https://nvbugs/5740377)
457-
disaggregated/test_auto_scaling.py::test_minimal_instances[etcd-round_robin] SKIP (https://nvbugs/5748564)
458457
unittest/_torch/attention/test_trtllm_flashinfer_symbol_collision.py::test_flashinfer_fused_moe_matches_torch_moe SKIP (https://nvbugs/5752521)
459458
cpp/test_multi_gpu.py::TestDisagg::test_symmetric_executor[gpt-2proc-mpi_kvcache-90] SKIP (https://nvbugs/5755941)
460459
accuracy/test_disaggregated_serving.py::TestDeepSeekV3Lite::test_guided_decoding[xgrammar-mtp_nextn=0] SKIP (https://nvbugs/5748600)

0 commit comments

Comments
 (0)