Skip to content

Commit c448fba

Browse files
committed
Complete merge with remote user/venky/auto-assign-pr-test changes
Signed-off-by: Venky Ganesh <[email protected]>
2 parents 192a3be + decd175 commit c448fba

File tree

1 file changed

+7
-0
lines changed

1 file changed

+7
-0
lines changed

CONTRIBUTING.md

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -93,6 +93,13 @@ Developer workflow for code contributions is as follows:
9393
3. Once the code changes are staged on the fork and ready for review, a [Pull Request](https://help.github.com/en/articles/about-pull-requests) (PR) can be [requested](https://help.github.com/en/articles/creating-a-pull-request) to merge the changes from a branch of the fork into a selected branch of upstream. PRs should typically target the `main` branch.
9494
* Creation of a PR creation kicks off the code review process.
9595
* At least one TensorRT-LLM engineer will be assigned for the review. When the PR is under review, the label `Pending Review` will be added to the PR.
96+
* Reviewers are automatically requested based on the modules affected in the PR. Module paths are defined in `.github/module-paths.json` and ownership in `.github/workflows/module-owners.json`.
97+
* You can test the assignment script locally with the `--dry-run` flag:
98+
```bash
99+
GH_TOKEN=<token> BASE_SHA=<base> HEAD_SHA=<head> PR_NUMBER=<pr> \
100+
PR_AUTHOR=<username> \
101+
python3 .github/scripts/assign_reviewers.py --dry-run
102+
```
96103
* If changes are requested, then the reviewer will add the label `Changes Requested` to the PR.
97104
* Once changes are approved, CI will be launched to validate the change. When CI passes, the reviewer will merge the PR.
98105
* If CI reports any failures, it's up to the requester to fix any CI failures before requesting another review.

0 commit comments

Comments
 (0)