Skip to content

Commit c7add46

Browse files
Fix evaluation of Makefile variables
Signed-off-by: Martin Marciniszyn Mehringer <11665257+MartinMarciniszyn@users.noreply.github.com>
1 parent 2447206 commit c7add46

File tree

1 file changed

+9
-5
lines changed

1 file changed

+9
-5
lines changed

docker/Makefile

Lines changed: 9 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -56,10 +56,6 @@ NGC_STAGING_REPO ?= nvcr.io/nvstaging/tensorrt-llm
5656
NGC_REPO ?= nvcr.io/nvidia/tensorrt-llm
5757
NGC_USE_STAGING ?= 0
5858
NGC_AUTO_REPO ?= $(if $(filter 1,$(NGC_USE_STAGING)),$(NGC_STAGING_REPO),$(NGC_REPO))
59-
SH_ENV ?= $(shell docker inspect --format='{{range .Config.Env}}{{println .}}{{end}}' $(BASE_IMAGE):$(BASE_TAG) \
60-
| grep '^ENV=' | sed 's/^[^=]*=//' 2>/dev/null)
61-
BASH_ENV ?= $(shell docker inspect --format='{{range .Config.Env}}{{println .}}{{end}}' $(BASE_IMAGE):$(BASE_TAG) \
62-
| grep '^BASH_ENV=' | sed 's/^[^=]*=//' 2>/dev/null)
6359

6460
define add_local_user
6561
docker build \
@@ -79,8 +75,16 @@ define rewrite_tag
7975
$(shell echo $(IMAGE_WITH_TAG) | sed "s/\/tensorrt-llm:/\/tensorrt-llm-staging:/g")
8076
endef
8177

78+
base_pull:
79+
@echo "Pulling base image: $(BASE_IMAGE):$(BASE_TAG)"
80+
docker pull $(BASE_IMAGE):$(BASE_TAG)
81+
8282
%_build: DEVEL_IMAGE = $(if $(findstring 1,$(JENKINS_DEVEL)),$(shell . ../jenkins/current_image_tags.properties && echo $$LLM_DOCKER_IMAGE))
83-
%_build:
83+
%_build: SH_ENV = $(shell docker inspect --format='{{range .Config.Env}}{{println .}}{{end}}' $(BASE_IMAGE):$(BASE_TAG) \
84+
| grep '^ENV=' | sed 's/^[^=]*=//' 2>/dev/null)
85+
%_build: BASH_ENV = $(shell docker inspect --format='{{range .Config.Env}}{{println .}}{{end}}' $(BASE_IMAGE):$(BASE_TAG) \
86+
| grep '^BASH_ENV=' | sed 's/^[^=]*=//' 2>/dev/null)
87+
%_build: base_pull
8488
@echo "Building docker image: $(IMAGE_WITH_TAG)"
8589
docker buildx build $(DOCKER_BUILD_OPTS) $(DOCKER_BUILD_ARGS) \
8690
--progress $(DOCKER_PROGRESS) \

0 commit comments

Comments
 (0)