Skip to content

Commit dfd940b

Browse files
committed
potential fix
1 parent 767f2d9 commit dfd940b

File tree

2 files changed

+8
-3
lines changed

2 files changed

+8
-3
lines changed

cpp/tensorrt_llm/executor/cache_transmission/cacheSplitConcat.cu

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -211,7 +211,9 @@ TargetRanksInfo TargetRanksInfoForDP(
211211
{
212212
for (int k = peerPPRankStart; k < peerPPRankEnd; k++)
213213
{
214-
int irank = (k * peerTPNum * peerCPNum) + (j * peerTPNum) + i;
214+
// Rank formula: ppRank * (tpNum * cpNum) + tpRank * cpNum + cpRank
215+
// where i=tpRank, j=cpRank, k=ppRank
216+
int irank = (k * peerTPNum * peerCPNum) + (i * peerCPNum) + j;
215217
retRanks.push_back(irank);
216218
}
217219
}

tests/integration/defs/accuracy/test_disaggregated_serving.py

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -872,8 +872,9 @@ def test_auto_dtype(self, overlap_scheduler, mtp_nextn):
872872
task.evaluate(llm)
873873

874874
@pytest.mark.skip_less_device(8)
875-
@pytest.mark.parametrize("gen_pp,gen_tp,gen_cp", [(1, 2, 2), (2, 1, 2)],
876-
ids=["pp1tp2cp2", "pp2tp1cp2"])
875+
@pytest.mark.parametrize("gen_pp,gen_tp,gen_cp", [(1, 1, 4), (1, 2, 2),
876+
(2, 1, 2)],
877+
ids=["pp1tp1cp4", "pp1tp2cp2", "pp2tp1cp2"])
877878
@pytest.mark.parametrize("cuda_graph_config", [
878879
None,
879880
{
@@ -911,6 +912,7 @@ def test_auto_dtype_with_helix(self, comms_medium, cuda_graph_config,
911912
"cache_transceiver_config": {
912913
"backend": "UCX"
913914
},
915+
# "print_iter_log": True,
914916
}
915917
gen_server_config = {
916918
"tensor_parallel_size": gen_tp,
@@ -929,6 +931,7 @@ def test_auto_dtype_with_helix(self, comms_medium, cuda_graph_config,
929931
"cache_transceiver_config": {
930932
"backend": "UCX"
931933
},
934+
# "print_iter_log": True,
932935
}
933936
disaggregated_server_config = {
934937
"hostname": "localhost",

0 commit comments

Comments
 (0)