Skip to content

Commit fe12fae

Browse files
authored
[https://nvbugs/5752516][chore] unwaive test; fix port conflicts in CI (#10152)
Signed-off-by: Lizhi Zhou <[email protected]>
1 parent cd5cd60 commit fe12fae

File tree

3 files changed

+8
-16
lines changed

3 files changed

+8
-16
lines changed

tests/integration/defs/disaggregated/test_auto_scaling.py

Lines changed: 8 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -12,9 +12,9 @@
1212
import pytest
1313
import requests
1414
import yaml
15+
from defs.common import get_free_port_in_ci as get_free_port
1516
from defs.conftest import llm_models_root
1617

17-
from tensorrt_llm._utils import get_free_port
1818
from tensorrt_llm.logger import logger
1919

2020
HEARTBEAT_INTERVAL = 1
@@ -454,7 +454,7 @@ async def test_worker_restart(model_name, disagg_server_config, worker_config,
454454
port=disagg_port)
455455
print(response)
456456
# kill gen1, the request should fail
457-
terminate(gen_worker1, release_port=False)
457+
terminate(gen_worker1, release_port=True)
458458
await asyncio.sleep(CHECK_STATUS_INTERVAL)
459459
verify_cluster_info(False, 1, 0, port=disagg_port)
460460
with pytest.raises(Exception):
@@ -480,7 +480,7 @@ async def test_worker_restart(model_name, disagg_server_config, worker_config,
480480
assert len(response.choices[0].text) >= 1
481481

482482
# kill ctx1, the request should fail
483-
terminate(ctx_worker1, release_port=False)
483+
terminate(ctx_worker1, release_port=True)
484484
await asyncio.sleep(CHECK_STATUS_INTERVAL)
485485
verify_cluster_info(False, 0, 1, port=disagg_port)
486486
with pytest.raises(Exception):
@@ -500,16 +500,16 @@ async def test_worker_restart(model_name, disagg_server_config, worker_config,
500500
assert len(response.choices[0].text) >= 1
501501

502502
# start ctx1 and gen1 again, we have 2 ctxs and 2 gens now
503-
await wait_for_port_released(ctx_worker1.port)
504-
await wait_for_port_released(gen_worker1.port)
505503
ctx_worker1 = run_ctx_worker(model_name,
506504
worker_config,
507505
work_dir,
508-
port=ctx_worker1.port)
506+
port=0,
507+
device=0)
509508
gen_worker1 = run_gen_worker(model_name,
510509
worker_config,
511510
work_dir,
512-
port=gen_worker1.port)
511+
port=0,
512+
device=1)
513513
await wait_for_worker_ready(ctx_worker1.port)
514514
await wait_for_worker_ready(gen_worker1.port)
515515
await asyncio.sleep(CHECK_STATUS_INTERVAL)
@@ -556,6 +556,7 @@ async def test_disagg_server_restart(model_name, disagg_server_config,
556556
terminate(disagg_server)
557557
# wait for the port to be released, so we can rebind the new process to the same port
558558
await wait_for_port_released(disagg_port)
559+
await asyncio.sleep(CHECK_STATUS_INTERVAL)
559560

560561
with pytest.raises(requests.exceptions.RequestException):
561562
verify_cluster_info(False,

tests/integration/test_lists/test-db/l0_dgx_h100.yml

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -116,17 +116,12 @@ l0_dgx_h100:
116116
- accuracy/test_disaggregated_serving.py::TestLlama3_1_8BInstruct::test_multi_instance[MMLU]
117117
- accuracy/test_llm_api_pytorch.py::TestQwen3NextInstruct::test_bf16_4gpu[tp4ep4_cudagraph_overlap]
118118
- disaggregated/test_auto_scaling.py::test_service_discovery[etcd-round_robin]
119-
- disaggregated/test_auto_scaling.py::test_service_discovery[etcd-load_balancing]
120-
- disaggregated/test_auto_scaling.py::test_worker_restart[etcd-round_robin]
121119
- disaggregated/test_auto_scaling.py::test_worker_restart[etcd-load_balancing]
122120
- disaggregated/test_auto_scaling.py::test_minimal_instances[etcd-round_robin]
123121
- disaggregated/test_auto_scaling.py::test_disagg_server_restart[etcd-round_robin]
124122
- disaggregated/test_auto_scaling.py::test_service_discovery[http-round_robin]
125-
- disaggregated/test_auto_scaling.py::test_service_discovery[http-load_balancing]
126123
- disaggregated/test_auto_scaling.py::test_service_discovery[http-kv_cache_aware]
127-
- disaggregated/test_auto_scaling.py::test_worker_restart[http-round_robin]
128124
- disaggregated/test_auto_scaling.py::test_worker_restart[http-load_balancing]
129-
- disaggregated/test_auto_scaling.py::test_worker_restart[http-kv_cache_aware]
130125
- disaggregated/test_auto_scaling.py::test_minimal_instances[http-round_robin]
131126
- disaggregated/test_auto_scaling.py::test_disagg_server_restart[http-round_robin]
132127
- condition:

tests/integration/test_lists/waives.txt

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -454,10 +454,6 @@ accuracy/test_cli_flow.py::TestPhi3Small128kInstruct::test_auto_dtype SKIP (http
454454
accuracy/test_cli_flow.py::TestPhi3_5MiniInstruct::test_auto_dtype SKIP (https://nvbugs/5744293)
455455
unittest/_torch/auto_deploy/unit/singlegpu/models/test_llama4_vlm_patch.py::test_build_run_llama4_vlm SKIP (https://nvbugs/5747878)
456456
accuracy/test_llm_api_pytorch.py::TestDeepSeekV3Lite::test_nvfp4_4gpus_online_eplb[fp8kv=True-moe_backend=TRTLLM] SKIP (https://nvbugs/5740377)
457-
disaggregated/test_auto_scaling.py::test_minimal_instances[etcd-round_robin] SKIP (https://nvbugs/5748564)
458-
disaggregated/test_auto_scaling.py::test_service_discovery[etcd-load_balancing] SKIP (https://nvbugs/5757415)
459-
disaggregated/test_auto_scaling.py::test_service_discovery[http-kv_cache_aware] SKIP (https://nvbugs/5758225)
460-
unittest/llmapi/apps/test_disagg_serving_perf_metrics.py SKIP (https://nvbugs/5752516)
461457
unittest/_torch/attention/test_trtllm_flashinfer_symbol_collision.py::test_flashinfer_fused_moe_matches_torch_moe SKIP (https://nvbugs/5752521)
462458
cpp/test_multi_gpu.py::TestDisagg::test_symmetric_executor[gpt-2proc-mpi_kvcache-90] SKIP (https://nvbugs/5755941)
463459
accuracy/test_disaggregated_serving.py::TestDeepSeekV3Lite::test_guided_decoding[xgrammar-mtp_nextn=0] SKIP (https://nvbugs/5748600)

0 commit comments

Comments
 (0)