[https://nvbugs/5695984][fix] Unwaive llama3 eagle test

[mikeiovine]

Description

Unwaive the tests. They appear to be passing on main as long as we reduce the draft length. Given that the accuracy drop is small, this was probably just due to different kernels.

Test Coverage

Existing tests.

PR Checklist

Please review the following before submitting your PR:

• PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.

• PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.

• Test cases are provided for new code paths (see test instructions)

• Any new dependencies have been scanned for license and vulnerabilities

• CODEOWNERS updated if ownership changes

• Documentation updated as needed

• Update tava architecture diagram if there is a significant design change in PR.

• The reviewers assigned automatically/manually are appropriate for the PR.

• Please check this after reviewing the above items as appropriate for this PR.

GitHub Bot Help

/bot [-h] ['run', 'kill', 'skip', 'reuse-pipeline'] ...

Provide a user friendly way for developers to interact with a Jenkins server.

Run /bot [-h|--help] to print this help message.

See details below for each supported subcommand.

Details

run [--reuse-test (optional)pipeline-id --disable-fail-fast --skip-test --stage-list "A10-PyTorch-1, xxx" --gpu-type "A30, H100_PCIe" --test-backend "pytorch, cpp" --add-multi-gpu-test --only-multi-gpu-test --disable-multi-gpu-test --post-merge --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" --detailed-log --debug(experimental)]

Launch build/test pipelines. All previously running jobs will be killed.

--reuse-test (optional)pipeline-id (OPTIONAL) : Allow the new pipeline to reuse build artifacts and skip successful test stages from a specified pipeline or the last pipeline if no pipeline-id is indicated. If the Git commit ID has changed, this option will be always ignored. The DEFAULT behavior of the bot is to reuse build artifacts and successful test results from the last pipeline.

--disable-reuse-test (OPTIONAL) : Explicitly prevent the pipeline from reusing build artifacts and skipping successful test stages from a previous pipeline. Ensure that all builds and tests are run regardless of previous successes.

--disable-fail-fast (OPTIONAL) : Disable fail fast on build/tests/infra failures.

--skip-test (OPTIONAL) : Skip all test stages, but still run build stages, package stages and sanity check stages. Note: Does NOT update GitHub check status.

--stage-list "A10-PyTorch-1, xxx" (OPTIONAL) : Only run the specified test stages. Examples: "A10-PyTorch-1, xxx". Note: Does NOT update GitHub check status.

--gpu-type "A30, H100_PCIe" (OPTIONAL) : Only run the test stages on the specified GPU types. Examples: "A30, H100_PCIe". Note: Does NOT update GitHub check status.

--test-backend "pytorch, cpp" (OPTIONAL) : Skip test stages which don't match the specified backends. Only support [pytorch, cpp, tensorrt, triton]. Examples: "pytorch, cpp" (does not run test stages with tensorrt or triton backend). Note: Does NOT update GitHub pipeline status.

--only-multi-gpu-test (OPTIONAL) : Only run the multi-GPU tests. Note: Does NOT update GitHub check status.

--disable-multi-gpu-test (OPTIONAL) : Disable the multi-GPU tests. Note: Does NOT update GitHub check status.

--add-multi-gpu-test (OPTIONAL) : Force run the multi-GPU tests in addition to running L0 pre-merge pipeline.

--post-merge (OPTIONAL) : Run the L0 post-merge pipeline instead of the ordinary L0 pre-merge pipeline.

--extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" (OPTIONAL) : Run the ordinary L0 pre-merge pipeline and specified test stages. Examples: --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx".

--detailed-log (OPTIONAL) : Enable flushing out all logs to the Jenkins console. This will significantly increase the log volume and may slow down the job.

--debug (OPTIONAL) : Experimental feature. Enable access to the CI container for debugging purpose. Note: Specify exactly one stage in the stage-list parameter to access the appropriate container environment. Note: Does NOT update GitHub check status.

For guidance on mapping tests to stage names, see docs/source/reference/ci-overview.md
and the scripts/test_to_stage_mapping.py helper.

kill

kill

Kill all running builds associated with pull request.

skip

skip --comment COMMENT

Skip testing for latest commit on pull request. --comment "Reason for skipping build/test" is required. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

reuse-pipeline

reuse-pipeline

Reuse a previous pipeline to validate current commit. This action will also kill all currently running builds associated with the pull request. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

Summary by CodeRabbit

• Tests
  • Updated Eagle3 decoding test configuration to adjust test parameters
  • Removed test waivers for Eagle3 one-model setup test scenarios, enabling previously excluded test validation cases that are now expected to pass

_{✏️ Tip: You can customize this high-level summary in your review settings.}

[mikeiovine]

/bot run

[coderabbitai]

📝 Walkthrough

Walkthrough

The changes adjust Eagle3 decoding configuration by reducing the max_draft_len parameter from 4 to 3 in a test, and remove corresponding test waivers, indicating the test now passes with the updated setting.

Changes

Cohort / File(s)	Change Summary
Eagle3 Decoding Configuration tests/integration/defs/accuracy/test_llm_api_pytorch.py	Modified max_draft_len argument in EagleDecodingConfig from 4 to 3 within test_fp8_eagle3_tp8 test.
Test Waivers tests/integration/test_lists/waives.txt	Removed two waiver entries for test_fp8_eagle3_tp8 test variants (eagle3_one_model=True and eagle3_one_model=False).

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

• Single parameter adjustment with no control flow changes
• Straightforward waiver line removals reflecting test status update

Suggested reviewers

• yuxianq

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	You can run @coderabbitai generate docstrings to improve docstring coverage.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Title check	✅ Passed	Title clearly identifies the main change: unwaiving llama3 eagle tests, with proper formatting including NVBugs ticket and [fix] type.
Description check	✅ Passed	Description includes key sections: explanation of the issue/solution, test coverage mention, and completed PR checklist, meeting template requirements.

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment

---

📜 Recent review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between f7e2456 and e6b4073.

📒 Files selected for processing (2)

• tests/integration/defs/accuracy/test_llm_api_pytorch.py (1 hunks)
• tests/integration/test_lists/waives.txt (0 hunks)

💤 Files with no reviewable changes (1)

• tests/integration/test_lists/waives.txt

🧰 Additional context used

📓 Path-based instructions (2)

**/*.py

📄 CodeRabbit inference engine (CODING_GUIDELINES.md)

**/*.py: Code developed for TensorRT-LLM should conform to Python 3.8+
Indent Python code with 4 spaces. Do not use tabs
Always maintain the namespace when importing, even if only one class or function from a module is used (e.g., use from package.subpackage import foo; foo.SomeClass() instead of from package.subpackage.foo import SomeClass)
Python filenames should use snake_case (e.g., some_file.py)
Python classes should use PascalCase (e.g., class SomeClass)
Python functions and methods should use snake_case (e.g., def my_awesome_function():)
Python local variables should use snake_case. Prefix 'k' for variable names that start with a number (e.g., k_99th_percentile = ...)
Python global variables should use upper snake_case and prefix 'G' (e.g., G_MY_GLOBAL = ...)
Python constants should use upper snake_case (e.g., MY_CONSTANT = ...)
Avoid shadowing variables declared in an outer scope in Python code
Initialize all externally visible members of a Python class in the constructor
For Python interfaces that may be used outside a file, prefer docstrings over comments
Python comments should be reserved for code within a function, or interfaces that are local to a file
Use Google style docstrings for Python classes and functions, which can be parsed by Sphinx
Python attributes and variables can be documented inline with attribute docstrings that will be rendered under the class docstring
Avoid using reflection in Python when functionality can be easily achieved without reflection
When using try-except blocks in Python, limit the except to the smallest set of errors possible
When using try-except blocks in Python to handle multiple possible variable types (duck-typing), keep the body of the try as small as possible, using the else block to implement the logic

Files:

• tests/integration/defs/accuracy/test_llm_api_pytorch.py

**/*.{h,hpp,cpp,cc,cxx,cu,py}

📄 CodeRabbit inference engine (CODING_GUIDELINES.md)

All TensorRT-LLM source code files should contain an NVIDIA copyright header with the current year, including .cpp, .h, .cu, .py, and other source files

Files:

• tests/integration/defs/accuracy/test_llm_api_pytorch.py

🧠 Learnings (3)

📓 Common learnings

Learnt from: tongyuantongyu
Repo: NVIDIA/TensorRT-LLM PR: 7781
File: tests/integration/test_lists/waives.txt:313-313
Timestamp: 2025-09-17T02:48:52.732Z
Learning: In TensorRT-LLM, `tests/integration/test_lists/waives.txt` is specifically for waiving/skipping tests, while other test list files like those in `test-db/` and `qa/` directories are for different test execution contexts (pre-merge, post-merge, QA tests). The same test appearing in both waives.txt and execution list files is intentional - the test is part of test suites but will be skipped due to the waiver.

Learnt from: venkywonka
Repo: NVIDIA/TensorRT-LLM PR: 6029
File: .github/pull_request_template.md:45-53
Timestamp: 2025-08-27T17:50:13.264Z
Learning: For PR templates in TensorRT-LLM, avoid suggesting changes that would increase developer overhead, such as converting plain bullets to mandatory checkboxes. The team prefers guidance-style bullets that don't require explicit interaction to reduce friction in the PR creation process.

Learnt from: djns99
Repo: NVIDIA/TensorRT-LLM PR: 6915
File: cpp/tensorrt_llm/kernels/cutlass_kernels/moe_gemm/moe_kernels.cu:4010-4012
Timestamp: 2025-08-14T23:23:27.449Z
Learning: For MOE (Mixture of Experts) code reviews in TensorRT-LLM, avoid repeatedly suggesting finalize fusion validation checks and safety assertions. The user djns99 has indicated these suggestions are repetitive and unwanted across multiple MOE-related changes.

📚 Learning: 2025-08-26T09:37:10.463Z

Learnt from: jiaganc
Repo: NVIDIA/TensorRT-LLM PR: 7031
File: tensorrt_llm/bench/dataclasses/configuration.py:90-104
Timestamp: 2025-08-26T09:37:10.463Z
Learning: In TensorRT-LLM, the `get_pytorch_perf_config()` method returns `self.pytorch_config` which can contain default `cuda_graph_config` values, so `llm_args` may already have this config before the extra options processing.

Applied to files:

• tests/integration/defs/accuracy/test_llm_api_pytorch.py

📚 Learning: 2025-08-26T09:37:10.463Z

Learnt from: jiaganc
Repo: NVIDIA/TensorRT-LLM PR: 7031
File: tensorrt_llm/bench/dataclasses/configuration.py:90-104
Timestamp: 2025-08-26T09:37:10.463Z
Learning: In TensorRT-LLM's bench configuration, the `get_pytorch_perf_config()` method returns `self.pytorch_config` which is a Dict[str, Any] that can contain default values including `cuda_graph_config`, making the fallback `llm_args["cuda_graph_config"]` safe to use.

Applied to files:

• tests/integration/defs/accuracy/test_llm_api_pytorch.py

🧬 Code graph analysis (1)

tests/integration/defs/accuracy/test_llm_api_pytorch.py (1)

tensorrt_llm/llmapi/llm_args.py (1)

• EagleDecodingConfig (810-927)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)

• GitHub Check: Pre-commit Check

🔇 Additional comments (1)

tests/integration/defs/accuracy/test_llm_api_pytorch.py (1)

635-637: Approved—draft length adjustment enables test to pass.

The reduction to max_draft_len=3 aligns with the PR objective to unwaive the llama3 eagle test. This value is consistent with test_guided_decoding_with_eagle3 (line 383), which also uses max_draft_len=3 for Eagle3 configuration.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[tensorrt-cicd]

PR_Github #28812 [ run ] triggered by Bot. Commit: e6b4073

[tensorrt-cicd]

PR_Github #28812 [ run ] completed with state SUCCESS. Commit: e6b4073
/LLM/main/L0_MergeRequest_PR pipeline #22058 completed with status: 'FAILURE'

⚠️ Action Required:

• Please check the failed tests and fix your PR
• If you cannot view the failures, ask the CI triggerer to share details
• Once fixed, request an NVIDIA team member to trigger CI again

[mikeiovine]

/bot run

[tensorrt-cicd]

PR_Github #29165 [ run ] triggered by Bot. Commit: c5ab86f

[tensorrt-cicd]

PR_Github #29165 [ run ] completed with state SUCCESS. Commit: c5ab86f
/LLM/main/L0_MergeRequest_PR pipeline #22371 completed with status: 'FAILURE'

⚠️ Action Required:

• Please check the failed tests and fix your PR
• If you cannot view the failures, ask the CI triggerer to share details
• Once fixed, request an NVIDIA team member to trigger CI again

[mikeiovine]

/bot run --disable-fail-fast

[tensorrt-cicd]

PR_Github #30195 [ run ] triggered by Bot. Commit: fd800e9

[tensorrt-cicd]

PR_Github #30195 [ run ] completed with state SUCCESS. Commit: fd800e9
/LLM/main/L0_MergeRequest_PR pipeline #23241 completed with status: 'FAILURE'

⚠️ Action Required:

• Please check the failed tests and fix your PR
• If you cannot view the failures, ask the CI triggerer to share details
• Once fixed, request an NVIDIA team member to trigger CI again

[mikeiovine]

/bot run --disable-fail-fast

[tensorrt-cicd]

PR_Github #30292 [ run ] triggered by Bot. Commit: fd800e9

[tensorrt-cicd]

PR_Github #30292 [ run ] completed with state SUCCESS. Commit: fd800e9
/LLM/main/L0_MergeRequest_PR pipeline #23326 completed with status: 'SUCCESS'

[mikeiovine]

Looks like the waive got removed due to a faulty resolution of a merge conflict, will fix

[mikeiovine]

/bot run --disable-fail-fast

[tensorrt-cicd]

PR_Github #30303 [ run ] triggered by Bot. Commit: 112ffbc

[tensorrt-cicd]

PR_Github #30303 [ run ] completed with state SUCCESS. Commit: 112ffbc
/LLM/main/L0_MergeRequest_PR pipeline #23337 completed with status: 'FAILURE'

⚠️ Action Required:

• Please check the failed tests and fix your PR
• If you cannot view the failures, ask the CI triggerer to share details
• Once fixed, request an NVIDIA team member to trigger CI again