Skip to content

Conversation

@brb-nv
Copy link
Collaborator

@brb-nv brb-nv commented Dec 31, 2025

Description

Currently, Gemma3 27B VLM runs on a tight memory budget on H100 PCIe and goes OOM intermittently. This MR replaced BF16 test with FP8 test.

Test Coverage

$ pytest tests/integration/defs/accuracy/test_llm_api_pytorch_multimodal.py::TestGemma3_27BInstruct::test_fp8_prequantized -s -v

PR Checklist

Please review the following before submitting your PR:

  • PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.

  • PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.

  • Test cases are provided for new code paths (see test instructions)

  • Any new dependencies have been scanned for license and vulnerabilities

  • CODEOWNERS updated if ownership changes

  • Documentation updated as needed

  • Update tava architecture diagram if there is a significant design change in PR.

  • The reviewers assigned automatically/manually are appropriate for the PR.

  • Please check this after reviewing the above items as appropriate for this PR.

GitHub Bot Help

/bot [-h] ['run', 'kill', 'skip', 'reuse-pipeline'] ...

Provide a user friendly way for developers to interact with a Jenkins server.

Run /bot [-h|--help] to print this help message.

See details below for each supported subcommand.

Details

run [--reuse-test (optional)pipeline-id --disable-fail-fast --skip-test --stage-list "A10-PyTorch-1, xxx" --gpu-type "A30, H100_PCIe" --test-backend "pytorch, cpp" --add-multi-gpu-test --only-multi-gpu-test --disable-multi-gpu-test --post-merge --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" --detailed-log --debug(experimental)]

Launch build/test pipelines. All previously running jobs will be killed.

--reuse-test (optional)pipeline-id (OPTIONAL) : Allow the new pipeline to reuse build artifacts and skip successful test stages from a specified pipeline or the last pipeline if no pipeline-id is indicated. If the Git commit ID has changed, this option will be always ignored. The DEFAULT behavior of the bot is to reuse build artifacts and successful test results from the last pipeline.

--disable-reuse-test (OPTIONAL) : Explicitly prevent the pipeline from reusing build artifacts and skipping successful test stages from a previous pipeline. Ensure that all builds and tests are run regardless of previous successes.

--disable-fail-fast (OPTIONAL) : Disable fail fast on build/tests/infra failures.

--skip-test (OPTIONAL) : Skip all test stages, but still run build stages, package stages and sanity check stages. Note: Does NOT update GitHub check status.

--stage-list "A10-PyTorch-1, xxx" (OPTIONAL) : Only run the specified test stages. Examples: "A10-PyTorch-1, xxx". Note: Does NOT update GitHub check status.

--gpu-type "A30, H100_PCIe" (OPTIONAL) : Only run the test stages on the specified GPU types. Examples: "A30, H100_PCIe". Note: Does NOT update GitHub check status.

--test-backend "pytorch, cpp" (OPTIONAL) : Skip test stages which don't match the specified backends. Only support [pytorch, cpp, tensorrt, triton]. Examples: "pytorch, cpp" (does not run test stages with tensorrt or triton backend). Note: Does NOT update GitHub pipeline status.

--only-multi-gpu-test (OPTIONAL) : Only run the multi-GPU tests. Note: Does NOT update GitHub check status.

--disable-multi-gpu-test (OPTIONAL) : Disable the multi-GPU tests. Note: Does NOT update GitHub check status.

--add-multi-gpu-test (OPTIONAL) : Force run the multi-GPU tests in addition to running L0 pre-merge pipeline.

--post-merge (OPTIONAL) : Run the L0 post-merge pipeline instead of the ordinary L0 pre-merge pipeline.

--extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" (OPTIONAL) : Run the ordinary L0 pre-merge pipeline and specified test stages. Examples: --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx".

--detailed-log (OPTIONAL) : Enable flushing out all logs to the Jenkins console. This will significantly increase the log volume and may slow down the job.

--debug (OPTIONAL) : Experimental feature. Enable access to the CI container for debugging purpose. Note: Specify exactly one stage in the stage-list parameter to access the appropriate container environment. Note: Does NOT update GitHub check status.

For guidance on mapping tests to stage names, see docs/source/reference/ci-overview.md
and the scripts/test_to_stage_mapping.py helper.

kill

kill

Kill all running builds associated with pull request.

skip

skip --comment COMMENT

Skip testing for latest commit on pull request. --comment "Reason for skipping build/test" is required. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

reuse-pipeline

reuse-pipeline

Reuse a previous pipeline to validate current commit. This action will also kill all currently running builds associated with the pull request. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

@brb-nv brb-nv force-pushed the user/brb/make-gemma3-test-fp8 branch from e7e0c52 to e7fad07 Compare December 31, 2025 16:41
@brb-nv
Copy link
Collaborator Author

brb-nv commented Dec 31, 2025

/bot run --disable-fail-fast

@tensorrt-cicd
Copy link
Collaborator

PR_Github #30294 [ run ] triggered by Bot. Commit: e7fad07

@brb-nv brb-nv marked this pull request as ready for review December 31, 2025 20:38
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Dec 31, 2025

📝 Walkthrough

Walkthrough

The PR refactors Gemma3-27B Instruct tests from auto dtype inference to explicit FP8 quantization. Test method is renamed to test_fp8_prequantized, model path updated to FP8-quantized variant, and accuracy reference metadata updated with FP8 quantization parameters.

Changes

Cohort / File(s) Summary
Test Configuration Updates
tests/integration/defs/accuracy/test_llm_api_pytorch_multimodal.py
Test method renamed from test_auto_dtype to test_fp8_prequantized; updated model path to FP8-quantized variant; added dtype="fp8" to KvCacheConfig; added cuda_graph_config=None parameter to LLM invocation.
Accuracy Reference Metadata
tests/integration/defs/accuracy/references/mmmu.yaml
Added FP8 quantization metadata for google/gemma-3-27b-it: quant_algo: FP8 and kv_cache_quant_algo: FP8; updated accuracy value from 52.0 to 51.0.
Test List Updates
tests/integration/test_lists/qa/llm_function_core.txt, llm_function_core_sanity.txt, llm_function_nim.txt, test-db/l0_h100.yml
Updated test references across four list files to replace TestGemma3_27BInstruct::test_auto_dtype with TestGemma3_27BInstruct::test_fp8_prequantized in multimodal accuracy suite.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. You can run @coderabbitai generate docstrings to improve docstring coverage.
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly describes the main change: converting the Gemma3 multimodal test to use FP8 quantization instead of auto dtype.
Description check ✅ Passed PR description includes required sections (Description, Test Coverage, PR Checklist) with clear explanation of the issue and solution, though the description section is brief.
✨ Finishing touches
  • 📝 Generate docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@tensorrt-cicd
Copy link
Collaborator

PR_Github #30294 [ run ] completed with state SUCCESS. Commit: e7fad07
/LLM/main/L0_MergeRequest_PR pipeline #23328 completed with status: 'SUCCESS'

@brb-nv
Copy link
Collaborator Author

brb-nv commented Dec 31, 2025

Test passed in pre-merge as part of H100_PCIe-PyTorch-3 stage.

@brb-nv brb-nv requested a review from chang-l December 31, 2025 21:17
@brb-nv brb-nv force-pushed the user/brb/make-gemma3-test-fp8 branch from 18b224c to 2894a1b Compare January 1, 2026 00:48
@brb-nv
Copy link
Collaborator Author

brb-nv commented Jan 1, 2026

/bot run --disable-fail-fast

@brb-nv brb-nv enabled auto-merge (squash) January 1, 2026 00:52
@tensorrt-cicd
Copy link
Collaborator

PR_Github #30309 [ run ] triggered by Bot. Commit: 2894a1b

@tensorrt-cicd
Copy link
Collaborator

PR_Github #30309 [ run ] completed with state SUCCESS. Commit: 2894a1b
/LLM/main/L0_MergeRequest_PR pipeline #23343 completed with status: 'FAILURE'

⚠️ Action Required:

  • Please check the failed tests and fix your PR
  • If you cannot view the failures, ask the CI triggerer to share details
  • Once fixed, request an NVIDIA team member to trigger CI again

@brb-nv
Copy link
Collaborator Author

brb-nv commented Jan 1, 2026

/bot run --disable-fail-fast

@tensorrt-cicd
Copy link
Collaborator

PR_Github #30316 [ run ] triggered by Bot. Commit: 2894a1b

@tensorrt-cicd
Copy link
Collaborator

PR_Github #30316 [ run ] completed with state SUCCESS. Commit: 2894a1b
/LLM/main/L0_MergeRequest_PR pipeline #23350 completed with status: 'SUCCESS'

@brb-nv brb-nv merged commit 0b75340 into NVIDIA:main Jan 1, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants