Skip to content

chore: cleanup GDS Cmake interface#4928

Merged
achartier merged 1 commit intoNVIDIA:mainfrom
achartier:gds-cleanup
Jun 10, 2025
Merged

chore: cleanup GDS Cmake interface#4928
achartier merged 1 commit intoNVIDIA:mainfrom
achartier:gds-cleanup

Conversation

@achartier
Copy link
Collaborator

PR title

chore: cleanup GDS Cmake interface

Description

  • Only find the library once
  • Use the generic CUDA toolkit library path (not hardcoded to 12.6)
  • Use the generic target arch directory (so it works on ARM)

Test Coverage

Build only change

GitHub Bot Help

/bot [-h] ['run', 'kill', 'skip', 'reuse-pipeline'] ...

Provide a user friendly way for developers to interact with a Jenkins server.

Run /bot [-h|--help] to print this help message.

See details below for each supported subcommand.

Details

run [--disable-fail-fast --skip-test --stage-list "A10-1, xxx" --gpu-type "A30, H100_PCIe" --add-multi-gpu-test --only-multi-gpu-test --disable-multi-gpu-test --post-merge --extra-stage "H100_PCIe-[Post-Merge]-1, xxx"]

Launch build/test pipelines. All previously running jobs will be killed.

--disable-fail-fast (OPTIONAL) : Disable fail fast on build/tests/infra failures.

--skip-test (OPTIONAL) : Skip all test stages, but still run build stages, package stages and sanity check stages. Note: Does NOT update GitHub check status.

--stage-list "A10-1, xxx" (OPTIONAL) : Only run the specified test stages. Examples: "A10-1, xxx". Note: Does NOT update GitHub check status.

--gpu-type "A30, H100_PCIe" (OPTIONAL) : Only run the test stages on the specified GPU types. Examples: "A30, H100_PCIe". Note: Does NOT update GitHub check status.

--only-multi-gpu-test (OPTIONAL) : Only run the multi-GPU tests. Note: Does NOT update GitHub check status.

--disable-multi-gpu-test (OPTIONAL) : Disable the multi-GPU tests. Note: Does NOT update GitHub check status.

--add-multi-gpu-test (OPTIONAL) : Force run the multi-GPU tests. Will also run L0 pre-merge pipeline.

--post-merge (OPTIONAL) : Run the L0 post-merge pipeline instead of the ordinary L0 pre-merge pipeline.

--extra-stage "H100_PCIe-[Post-Merge]-1, xxx" (OPTIONAL) : Run the ordinary L0 pre-merge pipeline and specified test stages. Examples: --extra-stage "H100_PCIe-[Post-Merge]-1, xxx".

kill

kill

Kill all running builds associated with pull request.

skip

skip --comment COMMENT

Skip testing for latest commit on pull request. --comment "Reason for skipping build/test" is required. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

reuse-pipeline

reuse-pipeline

Reuse a previous pipeline to validate current commit. This action will also kill all currently running builds associated with the pull request. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

@achartier achartier requested a review from Funatiq June 5, 2025 03:01
@achartier
Copy link
Collaborator Author

@arthurrasmusson FYI

@achartier
Copy link
Collaborator Author

/bot run

@tensorrt-cicd
Copy link
Collaborator

PR_Github #7610 [ run ] triggered by Bot

@tensorrt-cicd
Copy link
Collaborator

PR_Github #7610 [ run ] completed with state SUCCESS
/LLM/main/L0_MergeRequest_PR pipeline #5526 completed with status: 'FAILURE'

@achartier
Copy link
Collaborator Author

/bot run

@tensorrt-cicd
Copy link
Collaborator

PR_Github #7772 [ run ] triggered by Bot

@tensorrt-cicd
Copy link
Collaborator

PR_Github #7772 [ run ] completed with state SUCCESS
/LLM/main/L0_MergeRequest_PR pipeline #5628 completed with status: 'FAILURE'

@achartier
Copy link
Collaborator Author

/bot run

@tensorrt-cicd
Copy link
Collaborator

PR_Github #7911 [ run ] triggered by Bot

@tensorrt-cicd
Copy link
Collaborator

PR_Github #7911 [ run ] completed with state FAILURE
/LLM/main/L0_MergeRequest_PR pipeline #5717 completed with status: 'FAILURE'

@achartier
Copy link
Collaborator Author

/bot run

@tensorrt-cicd
Copy link
Collaborator

PR_Github #8147 [ run ] triggered by Bot

@achartier achartier enabled auto-merge (squash) June 9, 2025 18:03
@tensorrt-cicd
Copy link
Collaborator

PR_Github #8147 [ run ] completed with state SUCCESS
/LLM/main/L0_MergeRequest_PR pipeline #5904 completed with status: 'FAILURE'

Signed-off-by: Aurelien Chartier <2567591+achartier@users.noreply.github.com>
@achartier
Copy link
Collaborator Author

/bot run

@tensorrt-cicd
Copy link
Collaborator

PR_Github #8202 [ run ] triggered by Bot

@tensorrt-cicd
Copy link
Collaborator

PR_Github #8202 [ run ] completed with state SUCCESS
/LLM/main/L0_MergeRequest_PR pipeline #5949 completed with status: 'SUCCESS'

@achartier achartier merged commit dcf72c6 into NVIDIA:main Jun 10, 2025
3 checks passed
@achartier achartier deleted the gds-cleanup branch June 10, 2025 14:47
@arthurrasmusson
Copy link
Contributor

Thank you for the heads up @achartier. Back soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants