Skip to content

[None][chore] Waive test failing on pre-merge CI#8295

Merged
brb-nv merged 1 commit intoNVIDIA:release/1.1from
brb-nv:user/brb/waive-failing-tests-rel1.1-10-12
Oct 12, 2025
Merged

[None][chore] Waive test failing on pre-merge CI#8295
brb-nv merged 1 commit intoNVIDIA:release/1.1from
brb-nv:user/brb/waive-failing-tests-rel1.1-10-12

Conversation

@brb-nv
Copy link
Collaborator

@brb-nv brb-nv commented Oct 12, 2025

Description

Waive test failing on pre-merge CI

Test Coverage

N/A

PR Checklist

Please review the following before submitting your PR:

  • PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.

  • PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.

  • Test cases are provided for new code paths (see test instructions)

  • Any new dependencies have been scanned for license and vulnerabilities

  • CODEOWNERS updated if ownership changes

  • Documentation updated as needed

  • The reviewers assigned automatically/manually are appropriate for the PR.

  • Please check this after reviewing the above items as appropriate for this PR.

GitHub Bot Help

/bot [-h] ['run', 'kill', 'skip', 'reuse-pipeline'] ...

Provide a user friendly way for developers to interact with a Jenkins server.

Run /bot [-h|--help] to print this help message.

See details below for each supported subcommand.

Details

run [--reuse-test (optional)pipeline-id --disable-fail-fast --skip-test --stage-list "A10-PyTorch-1, xxx" --gpu-type "A30, H100_PCIe" --test-backend "pytorch, cpp" --add-multi-gpu-test --only-multi-gpu-test --disable-multi-gpu-test --post-merge --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" --detailed-log --debug(experimental)]

Launch build/test pipelines. All previously running jobs will be killed.

--reuse-test (optional)pipeline-id (OPTIONAL) : Allow the new pipeline to reuse build artifacts and skip successful test stages from a specified pipeline or the last pipeline if no pipeline-id is indicated. If the Git commit ID has changed, this option will be always ignored. The DEFAULT behavior of the bot is to reuse build artifacts and successful test results from the last pipeline.

--disable-reuse-test (OPTIONAL) : Explicitly prevent the pipeline from reusing build artifacts and skipping successful test stages from a previous pipeline. Ensure that all builds and tests are run regardless of previous successes.

--disable-fail-fast (OPTIONAL) : Disable fail fast on build/tests/infra failures.

--skip-test (OPTIONAL) : Skip all test stages, but still run build stages, package stages and sanity check stages. Note: Does NOT update GitHub check status.

--stage-list "A10-PyTorch-1, xxx" (OPTIONAL) : Only run the specified test stages. Examples: "A10-PyTorch-1, xxx". Note: Does NOT update GitHub check status.

--gpu-type "A30, H100_PCIe" (OPTIONAL) : Only run the test stages on the specified GPU types. Examples: "A30, H100_PCIe". Note: Does NOT update GitHub check status.

--test-backend "pytorch, cpp" (OPTIONAL) : Skip test stages which don't match the specified backends. Only support [pytorch, cpp, tensorrt, triton]. Examples: "pytorch, cpp" (does not run test stages with tensorrt or triton backend). Note: Does NOT update GitHub pipeline status.

--only-multi-gpu-test (OPTIONAL) : Only run the multi-GPU tests. Note: Does NOT update GitHub check status.

--disable-multi-gpu-test (OPTIONAL) : Disable the multi-GPU tests. Note: Does NOT update GitHub check status.

--add-multi-gpu-test (OPTIONAL) : Force run the multi-GPU tests in addition to running L0 pre-merge pipeline.

--post-merge (OPTIONAL) : Run the L0 post-merge pipeline instead of the ordinary L0 pre-merge pipeline.

--extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" (OPTIONAL) : Run the ordinary L0 pre-merge pipeline and specified test stages. Examples: --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx".

--detailed-log (OPTIONAL) : Enable flushing out all logs to the Jenkins console. This will significantly increase the log volume and may slow down the job.

--debug (OPTIONAL) : Experimental feature. Enable access to the CI container for debugging purpose. Note: Specify exactly one stage in the stage-list parameter to access the appropriate container environment. Note: Does NOT update GitHub check status.

For guidance on mapping tests to stage names, see docs/source/reference/ci-overview.md
and the scripts/test_to_stage_mapping.py helper.

kill

kill

Kill all running builds associated with pull request.

skip

skip --comment COMMENT

Skip testing for latest commit on pull request. --comment "Reason for skipping build/test" is required. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

reuse-pipeline

reuse-pipeline

Reuse a previous pipeline to validate current commit. This action will also kill all currently running builds associated with the pull request. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

Summary by CodeRabbit

  • Tests
    • Added a skip for a specific parameter combination in a weight-only quantized GEMM test to avoid a known external issue, preventing unnecessary failures and saving time.
    • Introduced a duplicate safeguard in another location within the same test to ensure the skip is consistently applied before any setup or execution.

@brb-nv brb-nv requested a review from a team as a code owner October 12, 2025 20:43
@brb-nv brb-nv requested a review from pcastonguay October 12, 2025 20:43
@brb-nv brb-nv force-pushed the user/brb/waive-failing-tests-rel1.1-10-12 branch from 14e79e0 to 5cd212b Compare October 12, 2025 20:44
@brb-nv
Copy link
Collaborator Author

brb-nv commented Oct 12, 2025

/bot run

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Oct 12, 2025

📝 Walkthrough

Walkthrough

Adds conditional skips in a unit test to bypass execution when k==512 and n==32768, placed early in the test and duplicated later in the file.

Changes

Cohort / File(s) Summary of Changes
Test guard for specific params
tests/unittest/_torch/thop/parallel/test_weight_only_quant_gemm.py
Added a skip condition for the parameter combo (k==512, n==32768) at the start of the test; the same guard is duplicated later in the file. No public APIs changed.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Suggested reviewers

  • 2ez4bz

Pre-merge checks and finishing touches

❌ Failed checks (2 warnings)
Check name Status Explanation Resolution
Description Check ⚠️ Warning The description uses the correct section headings but is overly brief and lacks essential details on the nature of the failure and the specific changes made to resolve it, and the Test Coverage section is marked "N/A" without referencing the modified test or explaining how the change is validated, so it does not sufficiently follow the template’s guidance. Please expand the Description to explain which test fails, why it fails, and how the added guard addresses the issue, and update the Test Coverage section to reference the specific test modifications or outline how the change is covered by existing or new tests.
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. You can run @coderabbitai generate docstrings to improve docstring coverage.
✅ Passed checks (1 passed)
Check name Status Explanation
Title Check ✅ Passed The title follows the required "[None][chore]" format and succinctly conveys the primary change of waiving a failing test in the pre-merge CI pipeline, making it clear, concise, and directly relevant to the modifications in the test file.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

📜 Recent review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between d857cd4 and a0b4c6c.

📒 Files selected for processing (1)
  • tests/unittest/_torch/thop/parallel/test_weight_only_quant_gemm.py (1 hunks)
🧰 Additional context used
📓 Path-based instructions (3)
**/*.{h,hpp,hh,hxx,cpp,cxx,cc,cu,cuh,py}

📄 CodeRabbit inference engine (CODING_GUIDELINES.md)

Use only spaces, no tabs; indent with 4 spaces.

Files:

  • tests/unittest/_torch/thop/parallel/test_weight_only_quant_gemm.py
**/*.py

📄 CodeRabbit inference engine (CODING_GUIDELINES.md)

**/*.py: Python code must target Python 3.8+.
Indent Python code with 4 spaces; do not use tabs.
Maintain module namespace when importing; prefer 'from package.subpackage import foo' then 'foo.SomeClass()' instead of importing the class directly.
Python filenames should be snake_case (e.g., some_file.py).
Python classes use PascalCase names.
Functions and methods use snake_case names.
Local variables use snake_case; prefix 'k' for variables that start with a number (e.g., k_99th_percentile).
Global variables use upper SNAKE_CASE prefixed with 'G' (e.g., G_MY_GLOBAL).
Constants use upper SNAKE_CASE (e.g., MY_CONSTANT).
Avoid shadowing variables from an outer scope.
Initialize all externally visible members of a class in the constructor.
Prefer docstrings for interfaces that may be used outside a file; comments for in-function or file-local interfaces.
Use Google-style docstrings for classes and functions (Sphinx-parsable).
Document attributes and variables inline so they render under the class/function docstring.
Avoid reflection when a simpler, explicit approach suffices (e.g., avoid dict(**locals()) patterns).
In try/except, catch the most specific exceptions possible.
For duck-typing try/except, keep the try body minimal and use else for the main logic.

Files:

  • tests/unittest/_torch/thop/parallel/test_weight_only_quant_gemm.py
**/*.{cpp,cxx,cc,h,hpp,hh,hxx,cu,cuh,py}

📄 CodeRabbit inference engine (CODING_GUIDELINES.md)

Prepend the NVIDIA Apache-2.0 copyright header with current year to the top of all source files (e.g., .cpp, .h, .cu, .py).

Files:

  • tests/unittest/_torch/thop/parallel/test_weight_only_quant_gemm.py
🪛 Ruff (0.13.3)
tests/unittest/_torch/thop/parallel/test_weight_only_quant_gemm.py

52-52: f-string without any placeholders

Remove extraneous f prefix

(F541)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
  • GitHub Check: Pre-commit Check

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Oct 12, 2025

📝 Walkthrough

Walkthrough

A conditional skip was added to tests/unittest/_torch/thop/parallel/test_weight_only_quant_gemm.py to bypass the test case where k=512 and n=32768, referencing an nvbugs issue URL. No other logic or API changes were made.

Changes

Cohort / File(s) Summary
Test skip addition
tests/unittest/_torch/thop/parallel/test_weight_only_quant_gemm.py
Inserted conditional to skip the test when parameters match k=512 and n=32768, with a message containing an nvbugs URL. No other modifications.

Sequence Diagram(s)

sequenceDiagram
  autonumber
  participant TR as Test Runner
  participant T as test_weight_only_quant_gemm

  TR->>T: Execute test with parameters
  alt If k==512 and n==32768
    note over T: New conditional skip
    T-->>TR: Mark test as skipped (nvbugs reference)
  else Other parameter combos
    T-->>TR: Run assertions as before
  end
Loading

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~7 minutes

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. You can run @coderabbitai generate docstrings to improve docstring coverage.
✅ Passed checks (2 passed)
Check name Status Explanation
Title Check ✅ Passed The pull request title follows the repository’s convention by using “[None][chore]” and clearly states that a failing pre-merge CI test is being waived, succinctly capturing the main change without extraneous details.
Description Check ✅ Passed The pull request description adheres to the required template by providing a “## Description” section that explains the change, a “## Test Coverage” section with an appropriate N/A entry for the waived test, and a complete “## PR Checklist” along with the “## GitHub Bot Help” details, making it a mostly complete and well-structured submission.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

📜 Review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between d857cd4 and 5cd212b.

📒 Files selected for processing (1)
  • tests/unittest/_torch/thop/parallel/test_weight_only_quant_gemm.py (1 hunks)
🧰 Additional context used
📓 Path-based instructions (3)
**/*.{h,hpp,hh,hxx,cpp,cxx,cc,cu,cuh,py}

📄 CodeRabbit inference engine (CODING_GUIDELINES.md)

Use only spaces, no tabs; indent with 4 spaces.

Files:

  • tests/unittest/_torch/thop/parallel/test_weight_only_quant_gemm.py
**/*.py

📄 CodeRabbit inference engine (CODING_GUIDELINES.md)

**/*.py: Python code must target Python 3.8+.
Indent Python code with 4 spaces; do not use tabs.
Maintain module namespace when importing; prefer 'from package.subpackage import foo' then 'foo.SomeClass()' instead of importing the class directly.
Python filenames should be snake_case (e.g., some_file.py).
Python classes use PascalCase names.
Functions and methods use snake_case names.
Local variables use snake_case; prefix 'k' for variables that start with a number (e.g., k_99th_percentile).
Global variables use upper SNAKE_CASE prefixed with 'G' (e.g., G_MY_GLOBAL).
Constants use upper SNAKE_CASE (e.g., MY_CONSTANT).
Avoid shadowing variables from an outer scope.
Initialize all externally visible members of a class in the constructor.
Prefer docstrings for interfaces that may be used outside a file; comments for in-function or file-local interfaces.
Use Google-style docstrings for classes and functions (Sphinx-parsable).
Document attributes and variables inline so they render under the class/function docstring.
Avoid reflection when a simpler, explicit approach suffices (e.g., avoid dict(**locals()) patterns).
In try/except, catch the most specific exceptions possible.
For duck-typing try/except, keep the try body minimal and use else for the main logic.

Files:

  • tests/unittest/_torch/thop/parallel/test_weight_only_quant_gemm.py
**/*.{cpp,cxx,cc,h,hpp,hh,hxx,cu,cuh,py}

📄 CodeRabbit inference engine (CODING_GUIDELINES.md)

Prepend the NVIDIA Apache-2.0 copyright header with current year to the top of all source files (e.g., .cpp, .h, .cu, .py).

Files:

  • tests/unittest/_torch/thop/parallel/test_weight_only_quant_gemm.py
🪛 Ruff (0.13.3)
tests/unittest/_torch/thop/parallel/test_weight_only_quant_gemm.py

52-52: f-string without any placeholders

Remove extraneous f prefix

(F541)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
  • GitHub Check: Pre-commit Check

@brb-nv brb-nv force-pushed the user/brb/waive-failing-tests-rel1.1-10-12 branch from 5cd212b to a0b4c6c Compare October 12, 2025 20:47
@brb-nv
Copy link
Collaborator Author

brb-nv commented Oct 12, 2025

/bot run

@tensorrt-cicd
Copy link
Collaborator

PR_Github #21106 [ run ] triggered by Bot

@tensorrt-cicd
Copy link
Collaborator

PR_Github #21107 [ run ] triggered by Bot

@tensorrt-cicd
Copy link
Collaborator

PR_Github #21106 [ run ] completed with state ABORTED

@brb-nv
Copy link
Collaborator Author

brb-nv commented Oct 12, 2025

/bot skip --comment "Waive failing test"

@brb-nv brb-nv enabled auto-merge (squash) October 12, 2025 22:03
Signed-off-by: Balaram Buddharaju <169953907+brb-nv@users.noreply.github.com>
@brb-nv brb-nv force-pushed the user/brb/waive-failing-tests-rel1.1-10-12 branch from a0b4c6c to 136f50a Compare October 12, 2025 22:04
@brb-nv
Copy link
Collaborator Author

brb-nv commented Oct 12, 2025

/bot run

@tensorrt-cicd
Copy link
Collaborator

PR_Github #21107 [ run ] completed with state SUCCESS
/LLM/release-1.1/L0_MergeRequest_PR pipeline #95 completed with status: 'FAILURE'

@tensorrt-cicd
Copy link
Collaborator

PR_Github #21108 [ skip ] triggered by Bot

@tensorrt-cicd
Copy link
Collaborator

PR_Github #21109 [ run ] triggered by Bot

@tensorrt-cicd
Copy link
Collaborator

PR_Github #21108 [ skip ] completed with state ABORTED

@tensorrt-cicd
Copy link
Collaborator

PR_Github #21109 [ run ] completed with state SUCCESS
/LLM/release-1.1/L0_MergeRequest_PR pipeline #96 completed with status: 'FAILURE'

@brb-nv
Copy link
Collaborator Author

brb-nv commented Oct 12, 2025

/bot skip --comment "Waive failing test"

@tensorrt-cicd
Copy link
Collaborator

PR_Github #21111 [ skip ] triggered by Bot

@tensorrt-cicd
Copy link
Collaborator

PR_Github #21111 [ skip ] completed with state SUCCESS
Skipping testing for commit 136f50a

@brb-nv brb-nv merged commit 04bded7 into NVIDIA:release/1.1 Oct 12, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants