Skip to content

[https://nvbugs/5640873][fix] Move thop tests to pre-merge#9094

Merged
HuiGao-NV merged 1 commit intoNVIDIA:mainfrom
HuiGao-NV:move_thop_cases
Nov 13, 2025
Merged

[https://nvbugs/5640873][fix] Move thop tests to pre-merge#9094
HuiGao-NV merged 1 commit intoNVIDIA:mainfrom
HuiGao-NV:move_thop_cases

Conversation

@HuiGao-NV
Copy link
Collaborator

@HuiGao-NV HuiGao-NV commented Nov 12, 2025

Summary by CodeRabbit

  • Tests
    • Re-enabled PyTorch THOP tests in test configuration.
    • Added timeout configuration for parallel test execution.
    • Improved resource cleanup in test teardown procedures.

Description

Test Coverage

PR Checklist

Please review the following before submitting your PR:

  • PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.

  • PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.

  • Test cases are provided for new code paths (see test instructions)

  • Any new dependencies have been scanned for license and vulnerabilities

  • CODEOWNERS updated if ownership changes

  • Documentation updated as needed

  • Update tava architecture diagram if there is a significant design change in PR.

  • The reviewers assigned automatically/manually are appropriate for the PR.

  • Please check this after reviewing the above items as appropriate for this PR.

GitHub Bot Help

/bot [-h] ['run', 'kill', 'skip', 'reuse-pipeline'] ...

Provide a user friendly way for developers to interact with a Jenkins server.

Run /bot [-h|--help] to print this help message.

See details below for each supported subcommand.

Details

run [--reuse-test (optional)pipeline-id --disable-fail-fast --skip-test --stage-list "A10-PyTorch-1, xxx" --gpu-type "A30, H100_PCIe" --test-backend "pytorch, cpp" --add-multi-gpu-test --only-multi-gpu-test --disable-multi-gpu-test --post-merge --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" --detailed-log --debug(experimental)]

Launch build/test pipelines. All previously running jobs will be killed.

--reuse-test (optional)pipeline-id (OPTIONAL) : Allow the new pipeline to reuse build artifacts and skip successful test stages from a specified pipeline or the last pipeline if no pipeline-id is indicated. If the Git commit ID has changed, this option will be always ignored. The DEFAULT behavior of the bot is to reuse build artifacts and successful test results from the last pipeline.

--disable-reuse-test (OPTIONAL) : Explicitly prevent the pipeline from reusing build artifacts and skipping successful test stages from a previous pipeline. Ensure that all builds and tests are run regardless of previous successes.

--disable-fail-fast (OPTIONAL) : Disable fail fast on build/tests/infra failures.

--skip-test (OPTIONAL) : Skip all test stages, but still run build stages, package stages and sanity check stages. Note: Does NOT update GitHub check status.

--stage-list "A10-PyTorch-1, xxx" (OPTIONAL) : Only run the specified test stages. Examples: "A10-PyTorch-1, xxx". Note: Does NOT update GitHub check status.

--gpu-type "A30, H100_PCIe" (OPTIONAL) : Only run the test stages on the specified GPU types. Examples: "A30, H100_PCIe". Note: Does NOT update GitHub check status.

--test-backend "pytorch, cpp" (OPTIONAL) : Skip test stages which don't match the specified backends. Only support [pytorch, cpp, tensorrt, triton]. Examples: "pytorch, cpp" (does not run test stages with tensorrt or triton backend). Note: Does NOT update GitHub pipeline status.

--only-multi-gpu-test (OPTIONAL) : Only run the multi-GPU tests. Note: Does NOT update GitHub check status.

--disable-multi-gpu-test (OPTIONAL) : Disable the multi-GPU tests. Note: Does NOT update GitHub check status.

--add-multi-gpu-test (OPTIONAL) : Force run the multi-GPU tests in addition to running L0 pre-merge pipeline.

--post-merge (OPTIONAL) : Run the L0 post-merge pipeline instead of the ordinary L0 pre-merge pipeline.

--extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" (OPTIONAL) : Run the ordinary L0 pre-merge pipeline and specified test stages. Examples: --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx".

--detailed-log (OPTIONAL) : Enable flushing out all logs to the Jenkins console. This will significantly increase the log volume and may slow down the job.

--debug (OPTIONAL) : Experimental feature. Enable access to the CI container for debugging purpose. Note: Specify exactly one stage in the stage-list parameter to access the appropriate container environment. Note: Does NOT update GitHub check status.

For guidance on mapping tests to stage names, see docs/source/reference/ci-overview.md
and the scripts/test_to_stage_mapping.py helper.

kill

kill

Kill all running builds associated with pull request.

skip

skip --comment COMMENT

Skip testing for latest commit on pull request. --comment "Reason for skipping build/test" is required. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

reuse-pipeline

reuse-pipeline

Reuse a previous pipeline to validate current commit. This action will also kill all currently running builds associated with the pull request. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

Signed-off-by: Hui Gao <huig@nvidia.com>
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Nov 12, 2025

📝 Walkthrough

Walkthrough

This pull request re-enables PyTorch THOP tests in the l0_b300 test suite by adding parallel and serial variants with timeout configuration, removes the THOP test entry from the l0_dgx_b300 suite, and adds CUDA cache cleanup to the mamba_conv1d_op test class.

Changes

Cohort / File(s) Summary
Test Configuration Updates
tests/integration/test_lists/test-db/l0_b300.yml
Re-enables THOP tests by removing commented entry and adding thop/parallel (with 90s timeout) and thop/serial test entries
Test Configuration Removal
tests/integration/test_lists/test-db/l0_dgx_b300.yml
Removes unittest/_torch/thop test entry from test list
Test Cleanup Enhancement
tests/unittest/_torch/thop/parallel/test_mamba_conv1d_op.py
Adds tearDown method to TestFunctional class to clear CUDA cache after each test execution

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

  • Configuration changes are straightforward (enable/disable tests, add timeout)
  • tearDown method is a standard, minimal cleanup pattern with no complex logic
  • Changes are homogeneous and self-contained within their respective files

Pre-merge checks and finishing touches

❌ Failed checks (2 warnings)
Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. You can run @coderabbitai generate docstrings to improve docstring coverage.
Description check ⚠️ Warning The PR description is largely incomplete; it contains only template boilerplate without substantive content in required sections like Description and Test Coverage. Fill in the Description section with a clear explanation of why thop tests are being moved to pre-merge, and document relevant test cases in the Test Coverage section.
✅ Passed checks (1 passed)
Check name Status Explanation
Title check ✅ Passed The title is clear and specific—it directly references the PR objective of moving thop tests to pre-merge via an NVBugs ticket.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@HuiGao-NV
Copy link
Collaborator Author

/bot run --stage-list "B200_PCIe-PyTorch-1,H100_PCIe-PyTorch-1,B300-PyTorch-1" --disable-fail-fast

@tensorrt-cicd
Copy link
Collaborator

PR_Github #24293 [ run ] triggered by Bot. Commit: d827089

@HuiGao-NV HuiGao-NV changed the title Move thop tests to pre-merge [https://nvbugs/5640873][fix] Move thop tests to pre-merge Nov 12, 2025
@tensorrt-cicd
Copy link
Collaborator

PR_Github #24293 [ run ] completed with state SUCCESS. Commit: d827089
/LLM/main/L0_MergeRequest_PR pipeline #18327 (Partly Tested) completed with status: 'SUCCESS'

@HuiGao-NV
Copy link
Collaborator Author

/bot run --disable-multi-gpu-test --disable-fail-fast

@tensorrt-cicd
Copy link
Collaborator

PR_Github #24300 [ run ] triggered by Bot. Commit: d827089

@tensorrt-cicd
Copy link
Collaborator

PR_Github #24300 [ run ] completed with state FAILURE. Commit: d827089
/LLM/main/L0_MergeRequest_PR pipeline #18332 (Partly Tested) completed with status: 'FAILURE'

@HuiGao-NV
Copy link
Collaborator Author

/bot run --stage-list "H100_PCIe-PyTorch-2"

@HuiGao-NV HuiGao-NV requested a review from QiJune November 12, 2025 22:49
@tensorrt-cicd
Copy link
Collaborator

PR_Github #24341 [ run ] triggered by Bot. Commit: d827089

Copy link
Collaborator

@QiJune QiJune left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tensorrt-cicd
Copy link
Collaborator

PR_Github #24341 [ run ] completed with state SUCCESS. Commit: d827089
/LLM/main/L0_MergeRequest_PR pipeline #18370 (Partly Tested) completed with status: 'FAILURE'

@HuiGao-NV
Copy link
Collaborator Author

/bot skip --comment "failure is timeout of H100_PCIe-PyTorch2/test_unittests.py::test_unittests_v2[unittest/_torch/speculative] which is not related to the cases in this change"

@tensorrt-cicd
Copy link
Collaborator

PR_Github #24378 [ skip ] triggered by Bot. Commit: d827089

@tensorrt-cicd
Copy link
Collaborator

PR_Github #24378 [ skip ] completed with state SUCCESS. Commit: d827089
Skipping testing for commit d827089

@HuiGao-NV HuiGao-NV merged commit cde18c1 into NVIDIA:main Nov 13, 2025
6 of 11 checks passed
zheyuf pushed a commit to zheyuf/TensorRT-LLM that referenced this pull request Nov 19, 2025
@HuiGao-NV HuiGao-NV deleted the move_thop_cases branch December 5, 2025 07:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants