Skip to content

[None][fix] change logging for weight loading on unified memory#9177

Merged
farazkh80 merged 4 commits intoNVIDIA:mainfrom
farazkh80:fix-mpi-cpath
Nov 19, 2025
Merged

[None][fix] change logging for weight loading on unified memory#9177
farazkh80 merged 4 commits intoNVIDIA:mainfrom
farazkh80:fix-mpi-cpath

Conversation

@farazkh80
Copy link
Collaborator

@farazkh80 farazkh80 commented Nov 14, 2025

Summary by CodeRabbit

  • Chores
    • Updated Docker build configuration to enhance support for Triton runtime compilation by setting CUDA environment paths for development containers
    • Refined logging verbosity by reducing GPU device transfer message noise on integrated graphics systems, providing cleaner debug output for developers

Description

Test Coverage

PR Checklist

Please review the following before submitting your PR:

  • PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.

  • PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.

  • Test cases are provided for new code paths (see test instructions)

  • Any new dependencies have been scanned for license and vulnerabilities

  • CODEOWNERS updated if ownership changes

  • Documentation updated as needed

  • Update tava architecture diagram if there is a significant design change in PR.

  • The reviewers assigned automatically/manually are appropriate for the PR.

  • Please check this after reviewing the above items as appropriate for this PR.

GitHub Bot Help

/bot [-h] ['run', 'kill', 'skip', 'reuse-pipeline'] ...

Provide a user friendly way for developers to interact with a Jenkins server.

Run /bot [-h|--help] to print this help message.

See details below for each supported subcommand.

Details

run [--reuse-test (optional)pipeline-id --disable-fail-fast --skip-test --stage-list "A10-PyTorch-1, xxx" --gpu-type "A30, H100_PCIe" --test-backend "pytorch, cpp" --add-multi-gpu-test --only-multi-gpu-test --disable-multi-gpu-test --post-merge --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" --detailed-log --debug(experimental)]

Launch build/test pipelines. All previously running jobs will be killed.

--reuse-test (optional)pipeline-id (OPTIONAL) : Allow the new pipeline to reuse build artifacts and skip successful test stages from a specified pipeline or the last pipeline if no pipeline-id is indicated. If the Git commit ID has changed, this option will be always ignored. The DEFAULT behavior of the bot is to reuse build artifacts and successful test results from the last pipeline.

--disable-reuse-test (OPTIONAL) : Explicitly prevent the pipeline from reusing build artifacts and skipping successful test stages from a previous pipeline. Ensure that all builds and tests are run regardless of previous successes.

--disable-fail-fast (OPTIONAL) : Disable fail fast on build/tests/infra failures.

--skip-test (OPTIONAL) : Skip all test stages, but still run build stages, package stages and sanity check stages. Note: Does NOT update GitHub check status.

--stage-list "A10-PyTorch-1, xxx" (OPTIONAL) : Only run the specified test stages. Examples: "A10-PyTorch-1, xxx". Note: Does NOT update GitHub check status.

--gpu-type "A30, H100_PCIe" (OPTIONAL) : Only run the test stages on the specified GPU types. Examples: "A30, H100_PCIe". Note: Does NOT update GitHub check status.

--test-backend "pytorch, cpp" (OPTIONAL) : Skip test stages which don't match the specified backends. Only support [pytorch, cpp, tensorrt, triton]. Examples: "pytorch, cpp" (does not run test stages with tensorrt or triton backend). Note: Does NOT update GitHub pipeline status.

--only-multi-gpu-test (OPTIONAL) : Only run the multi-GPU tests. Note: Does NOT update GitHub check status.

--disable-multi-gpu-test (OPTIONAL) : Disable the multi-GPU tests. Note: Does NOT update GitHub check status.

--add-multi-gpu-test (OPTIONAL) : Force run the multi-GPU tests in addition to running L0 pre-merge pipeline.

--post-merge (OPTIONAL) : Run the L0 post-merge pipeline instead of the ordinary L0 pre-merge pipeline.

--extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" (OPTIONAL) : Run the ordinary L0 pre-merge pipeline and specified test stages. Examples: --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx".

--detailed-log (OPTIONAL) : Enable flushing out all logs to the Jenkins console. This will significantly increase the log volume and may slow down the job.

--debug (OPTIONAL) : Experimental feature. Enable access to the CI container for debugging purpose. Note: Specify exactly one stage in the stage-list parameter to access the appropriate container environment. Note: Does NOT update GitHub check status.

For guidance on mapping tests to stage names, see docs/source/reference/ci-overview.md
and the scripts/test_to_stage_mapping.py helper.

kill

kill

Kill all running builds associated with pull request.

skip

skip --comment COMMENT

Skip testing for latest commit on pull request. --comment "Reason for skipping build/test" is required. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

reuse-pipeline

reuse-pipeline

Reuse a previous pipeline to validate current commit. This action will also kill all currently running builds associated with the pull request. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

@farazkh80
Copy link
Collaborator Author

/bot run

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Nov 14, 2025

📝 Walkthrough

Walkthrough

Two minor updates: environment variables for CUDA/Triton support added to Docker multi-stage build, and logging severity adjusted from warning to debug for an integrated GPU message.

Changes

Cohort / File(s) Summary
Docker configuration
docker/Dockerfile.multi
Added CPATH and TRITON_PTXAS_PATH environment variables in devel stage to support Triton runtime compilation with CUDA headers and ptxas binary path.
Logging adjustment
tensorrt_llm/_torch/modules/linear.py
Changed log level from warning to debug for the integrated GPU device transfer skip message.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

  • Both changes are configuration/logging adjustments with no logic modifications
  • No behavioral impact beyond diagnostic output verbosity

Pre-merge checks and finishing touches

❌ Failed checks (2 warnings)
Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. You can run @coderabbitai generate docstrings to improve docstring coverage.
Description check ⚠️ Warning The PR description is entirely empty—only the template placeholder comments remain without any actual content explaining the changes, rationale, or test coverage. Fill in the Description section with a clear explanation of the issue and solution, the Test Coverage section with relevant tests, and complete the PR Checklist appropriately.
✅ Passed checks (1 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly aligns with the changeset, which modifies logging levels and adds CUDA-related environment variables for build configuration.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Tip

📝 Customizable high-level summaries are now available in beta!

You can now customize how CodeRabbit generates the high-level summary in your pull requests — including its content, structure, tone, and formatting.

  • Provide your own instructions using the high_level_summary_instructions setting.
  • Format the summary however you like (bullet lists, tables, multi-section layouts, contributor stats, etc.).
  • Use high_level_summary_in_walkthrough to move the summary from the description to the walkthrough section.

Example instruction:

"Divide the high-level summary into five sections:

  1. 📝 Description — Summarize the main change in 50–60 words, explaining what was done.
  2. 📓 References — List relevant issues, discussions, documentation, or related PRs.
  3. 📦 Dependencies & Requirements — Mention any new/updated dependencies, environment variable changes, or configuration updates.
  4. 📊 Contributor Summary — Include a Markdown table showing contributions:
    | Contributor | Lines Added | Lines Removed | Files Changed |
  5. ✔️ Additional Notes — Add any extra reviewer context.
    Keep each section concise (under 200 words) and use bullet or numbered lists for clarity."

Note: This feature is currently in beta for Pro-tier users, and pricing will be announced later.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@farazkh80 farazkh80 changed the title [https://nvbugspro.nvidia.com/bug/5641476][fix] Add cpath for mpi env var fix [https://nvbugs/5641476][fix] Add cpath for mpi env var fix Nov 14, 2025
@tensorrt-cicd
Copy link
Collaborator

PR_Github #24620 [ run ] triggered by Bot. Commit: d7077f4

@tensorrt-cicd
Copy link
Collaborator

PR_Github #24620 [ run ] completed with state FAILURE. Commit: d7077f4
/LLM/main/L0_MergeRequest_PR pipeline #18585 completed with status: 'FAILURE'

@farazkh80
Copy link
Collaborator Author

/bot run --disable-fail-fast

@tensorrt-cicd
Copy link
Collaborator

PR_Github #24633 [ run ] triggered by Bot. Commit: b560ad6

@tensorrt-cicd
Copy link
Collaborator

PR_Github #24633 [ run ] completed with state SUCCESS. Commit: b560ad6
/LLM/main/L0_MergeRequest_PR pipeline #18596 completed with status: 'FAILURE'

@farazkh80
Copy link
Collaborator Author

/bot run --stage-list "B200_PCIe-PyTorch-2, H100_PCIe-PyTorch-2"

@tensorrt-cicd
Copy link
Collaborator

PR_Github #24782 [ run ] triggered by Bot. Commit: b560ad6

@tensorrt-cicd
Copy link
Collaborator

PR_Github #24782 [ run ] completed with state SUCCESS. Commit: b560ad6
/LLM/main/L0_MergeRequest_PR pipeline #18699 (Partly Tested) completed with status: 'SUCCESS'

@farazkh80
Copy link
Collaborator Author

farazkh80 and others added 2 commits November 18, 2025 18:09
Signed-off-by: Faraz Khoubsirat <58580514+farazkh80@users.noreply.github.com>
…stems to only log once.

Signed-off-by: Simeng Liu <109828133+SimengLiu-nv@users.noreply.github.com>
Signed-off-by: Faraz Khoubsirat <58580514+farazkh80@users.noreply.github.com>
Signed-off-by: Faraz Khoubsirat <58580514+farazkh80@users.noreply.github.com>
@farazkh80
Copy link
Collaborator Author

/bot run

@tensorrt-cicd
Copy link
Collaborator

PR_Github #24938 [ run ] triggered by Bot. Commit: b65230a

@tensorrt-cicd
Copy link
Collaborator

PR_Github #24938 [ run ] completed with state SUCCESS. Commit: b65230a
/LLM/main/L0_MergeRequest_PR pipeline #18837 completed with status: 'FAILURE'

@farazkh80
Copy link
Collaborator Author

/bot run

@tensorrt-cicd
Copy link
Collaborator

PR_Github #25067 [ run ] triggered by Bot. Commit: b65230a

@tensorrt-cicd
Copy link
Collaborator

PR_Github #25067 [ run ] completed with state SUCCESS. Commit: b65230a
/LLM/main/L0_MergeRequest_PR pipeline #18947 completed with status: 'SUCCESS'

Signed-off-by: Faraz Khoubsirat <58580514+farazkh80@users.noreply.github.com>
@farazkh80 farazkh80 changed the title [https://nvbugs/5641476][fix] Add cpath for mpi env var fix [None][fix] change logging for weight loading on unified memory Nov 19, 2025
@farazkh80
Copy link
Collaborator Author

/bot skip --comment "undid docker changes, and the log change has been verified before"

@tensorrt-cicd
Copy link
Collaborator

PR_Github #25076 [ skip ] triggered by Bot. Commit: d3b2213

@tensorrt-cicd
Copy link
Collaborator

PR_Github #25076 [ skip ] completed with state SUCCESS. Commit: d3b2213
Skipping testing for commit d3b2213

@farazkh80 farazkh80 enabled auto-merge (squash) November 19, 2025 19:16
@farazkh80 farazkh80 disabled auto-merge November 19, 2025 19:17
@farazkh80 farazkh80 merged commit 49c45eb into NVIDIA:main Nov 19, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants