Skip to content

Commit 08c2628

Browse files
committed
address review feedbacks
Signed-off-by: realAsma <[email protected]>
1 parent a72b7ea commit 08c2628

File tree

2 files changed

+4
-9
lines changed

2 files changed

+4
-9
lines changed

modelopt/torch/quantization/model_calib.py

Lines changed: 3 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -574,14 +574,9 @@ def forward(self, input, *args, **kwargs):
574574

575575
disable_awq = False
576576
for tq in [self.input_quantizer, self.weight_quantizer]:
577-
for attr in ["_pre_quant_scale", "_amax"]:
578-
if not tq.validate_attr(attr_name=attr):
579-
disable_awq = True
580-
warnings.warn(
581-
f"awq_lite: {attr} is not valid for {self.awq_lite.name}, skipping awq_lite"
582-
)
583-
break
584-
if disable_awq:
577+
if not tq.validate_attr(attr_name="_pre_quant_scale"):
578+
disable_awq = True
579+
warnings.warn(f"awq_lite: skipping awq_lite for valid for {self.awq_lite.name}")
585580
break
586581

587582
if disable_awq:

modelopt/torch/quantization/nn/modules/tensor_quantizer.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -514,7 +514,7 @@ def validate_attr(
514514
is_valid = torch.all(attr_value >= 0) and not torch.any(torch.isinf(attr_value))
515515
if is_valid:
516516
return True
517-
name = f"{name} " if name else ""
517+
name = f"{name}." if name else ""
518518
msg = f"{name}{attr_name} contains invalid values: {attr_value}"
519519
if warn_error:
520520
warnings.warn(msg)

0 commit comments

Comments
 (0)