Skip to content

Commit b94ad1b

Browse files
Add last aggregator job in unit/gpu CI test as required check
Signed-off-by: Keval Morabia <[email protected]>
1 parent 2b52759 commit b94ad1b

File tree

2 files changed

+16
-0
lines changed

2 files changed

+16
-0
lines changed

.github/workflows/gpu_tests.yml

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -36,6 +36,7 @@ jobs:
3636
pyproject.toml
3737
setup.py
3838
base_sha: ${{ fromJSON(steps.get-pr-info.outputs.pr-info).base.ref }}
39+
fail_on_initial_diff_error: true
3940
wait-checks:
4041
needs: [check-file-changes]
4142
if: needs.check-file-changes.outputs.any_changed == 'true'
@@ -70,3 +71,12 @@ jobs:
7071
timeout-minutes: 90
7172
container: *gpu_container
7273
steps: *gpu_steps
74+
gpu-pr-required-check:
75+
# Run even if gpu-tests-pr is skipped
76+
if: ${{ startsWith(github.ref, 'refs/heads/pull-request/') && always() }}
77+
needs: [check-file-changes, gpu-tests-pr]
78+
runs-on: ubuntu-latest
79+
steps:
80+
- name: Required GPU tests did not succeed
81+
if: ${{ needs.check-file-changes.outputs.any_changed == 'true' && needs.gpu-tests-pr.result != 'success' }}
82+
run: exit 1

.github/workflows/unit_tests.yml

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -126,3 +126,9 @@ jobs:
126126
python-version: "3.12"
127127
- name: Run unit tests
128128
run: pip install tox && tox -e py312-partial-unit-${{ matrix.test-env }}
129+
unit-pr-required-check:
130+
if: github.event_name == 'pull_request'
131+
needs: [linux, windows, multi-py, multi-torch, multi-transformers, partial-install]
132+
runs-on: ubuntu-latest
133+
steps:
134+
- run: echo "All PR unit test jobs completed"

0 commit comments

Comments
 (0)