[5541172] update based on review comments

Signed-off-by: unknown <[email protected]>

Author: ynankani

examples/windows/accuracy_benchmark/kl_divergence_metrics/compute_kl_divergence.py

@@ -496,10 +496,13 @@ def validate_inputs(hf_model, ep_path_pairs):
     Returns:
         bool: True if all inputs are valid, False otherwise.
     """
-    # Check HF model path (only if provided)
-    if hf_model and not os.path.exists(hf_model):
-        print(f"[ERROR] Hugging Face model path does not exist: {hf_model}")
-        return False
+    # Check HF model path (only if provided and it looks like a local path)
+    # If it doesn't exist locally, assume it's a HF model name to be downloaded
+    if hf_model and os.path.exists(hf_model):
+        # Verify it's a valid directory
+        if not os.path.isdir(hf_model):
+            print(f"[ERROR] Hugging Face model path is not a directory: {hf_model}")
+            return False
 
     # Check execution providers and paths
     for ep, path in ep_path_pairs:
@@ -525,6 +528,10 @@ def main():
   python compute_kl_divergence.py --hf_model "F:\\shared\\Llama-3.1-8B-Instruct"
       --ep cuda --path "G:\\models\\cuda_model" --output "hf_vs_cuda.json"
 
+  # Compare HF vs CUDA model (download from Hugging Face)
+  python compute_kl_divergence.py --hf_model "meta-llama/Llama-3.1-8B-Instruct"
+      --ep cuda --path "G:\\models\\cuda_model" --output "hf_vs_cuda.json"
+
   # Compare HF vs CUDA vs DirectML models
   python compute_kl_divergence.py --hf_model "F:\\shared\\Llama-3.1-8B-Instruct"
       --ep cuda --path "G:\\models\\cuda_model"

examples/windows/accuracy_benchmark/kl_divergence_metrics/extract_logits_hf.py

@@ -182,10 +182,7 @@ def main():
     global DEBUG
     DEBUG = args.debug
 
-    # Validate model directory exists
-    if not os.path.exists(args.model_path):
-        print(f"Error: Model directory does not exist: {args.model_path}")
-        return 1
+
 
     try:
         # Extract logits