Skip to content

Conversation

@gcunhase
Copy link
Contributor

What does this PR do?

Type of change: new feature

Overview: ?

Usage

$ python -m modelopt.onnx.autocast --onnx_path=$MODEL_NAME.onnx --trt_plugins=$PLUGIN_PATH.so --trt_plugins_precision #PLUGIN_NAME:fp16

Testing

See bug 5597780

Before your PR is "Ready for review"

  • Make sure you read and follow Contributor guidelines and your commits are signed.
  • Is this change backward compatible?: Yes
  • Did you write any new necessary tests?: No
  • Did you add or update any necessary documentation?: No
  • Did you update Changelog?: No

@gcunhase gcunhase requested review from a team as code owners October 23, 2025 19:03
@gcunhase gcunhase requested a review from ajrasane October 23, 2025 19:03
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Oct 23, 2025

Important

Review skipped

Auto reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@gcunhase gcunhase force-pushed the dev/gcunhasergio/autocast_custom_op_add_fp16_only_support_5597780 branch from 7653d8a to 7fef5a5 Compare October 23, 2025 19:07
@codecov
Copy link

codecov bot commented Oct 23, 2025

Codecov Report

❌ Patch coverage is 78.57143% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 73.44%. Comparing base (2fd67cc) to head (7fef5a5).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
modelopt/onnx/autocast/graphsanitizer.py 72.72% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #460      +/-   ##
==========================================
+ Coverage   73.40%   73.44%   +0.03%     
==========================================
  Files         180      180              
  Lines       18047    18059      +12     
==========================================
+ Hits        13248    13264      +16     
+ Misses       4799     4795       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants