Replace EXPECT with _CCCL_ASSERT for idx bounds checks

Where idx is only checked (idx == 0) but not used afterwards,
use _CCCL_ASSERT instead of EXPECT. These are precondition checks
that can be disabled in release builds.

Keeps EXPECT for grid impl where idx is validated against size
and then used to index the array.

Made-with: Cursor

Author: andralex

cudax/include/cuda/experimental/__stf/places/exec/green_context.cuh

@@ -279,13 +279,13 @@ public:
 
   ::std::shared_ptr<exec_place::impl> get_place(size_t idx) override
   {
-    EXPECT(idx == 0, "Index out of bounds for green_ctx exec_place");
+    _CCCL_ASSERT(idx == 0, "Index out of bounds for green_ctx exec_place");
     return shared_from_this();
   }
 
   exec_place activate(size_t idx) const override
   {
-    EXPECT(idx == 0, "Index out of bounds for green_ctx exec_place");
+    _CCCL_ASSERT(idx == 0, "Index out of bounds for green_ctx exec_place");
 
     // Save the current context and transform it into a fake green context place
     CUcontext current_ctx;
@@ -301,7 +301,7 @@ public:
 
   void deactivate(const exec_place& prev, size_t idx = 0) const override
   {
-    EXPECT(idx == 0, "Index out of bounds for green_ctx exec_place");
+    _CCCL_ASSERT(idx == 0, "Index out of bounds for green_ctx exec_place");
 
     auto prev_impl      = ::std::static_pointer_cast<exec_place_green_ctx_impl>(prev.get_impl());
     CUcontext saved_ctx = prev_impl->driver_context_;

cudax/include/cuda/experimental/__stf/places/places.cuh

@@ -943,21 +943,21 @@ public:
   // Grid interface - host is a 1-element grid
   ::std::shared_ptr<exec_place::impl> get_place(size_t idx) override
   {
-    EXPECT(idx == 0, "Index out of bounds for host exec_place");
+    _CCCL_ASSERT(idx == 0, "Index out of bounds for host exec_place");
     // Static instance - use no-op deleter instead of shared_from_this()
     return ::std::shared_ptr<impl>(this, [](impl*) {});
   }
 
   // Activation - no-op for host
   exec_place activate(size_t idx) const override
   {
-    EXPECT(idx == 0, "Index out of bounds for host exec_place");
+    _CCCL_ASSERT(idx == 0, "Index out of bounds for host exec_place");
     return exec_place();
   }
 
   void deactivate(const exec_place& prev, size_t idx = 0) const override
   {
-    EXPECT(idx == 0, "Index out of bounds for host exec_place");
+    _CCCL_ASSERT(idx == 0, "Index out of bounds for host exec_place");
     _CCCL_ASSERT(!prev.get_impl(), "Host deactivate expects empty prev");
   }
 
@@ -1012,7 +1012,7 @@ public:
 
   ::std::shared_ptr<exec_place::impl> get_place(size_t idx) override
   {
-    EXPECT(idx == 0, "Index out of bounds for device_auto exec_place");
+    _CCCL_ASSERT(idx == 0, "Index out of bounds for device_auto exec_place");
     // Static instance - use no-op deleter instead of shared_from_this()
     return ::std::shared_ptr<impl>(this, [](impl*) {});
   }
@@ -1061,7 +1061,7 @@ public:
 
     exec_place activate(size_t idx) const override
     {
-      EXPECT(idx == 0, "Index out of bounds for device exec_place");
+      _CCCL_ASSERT(idx == 0, "Index out of bounds for device exec_place");
       auto old_dev_id = cuda_try<cudaGetDevice>();
       if (old_dev_id != devid_)
       {
@@ -1072,7 +1072,7 @@ public:
 
     void deactivate(const exec_place& prev, size_t idx = 0) const override
     {
-      EXPECT(idx == 0, "Index out of bounds for device exec_place");
+      _CCCL_ASSERT(idx == 0, "Index out of bounds for device exec_place");
       auto current_dev_id  = cuda_try<cudaGetDevice>();
       auto restored_dev_id = device_ordinal(prev.affine_data_place());
       if (current_dev_id != restored_dev_id)
@@ -1328,13 +1328,13 @@ inline exec_place data_place::affine_exec_place() const
 
 inline ::std::shared_ptr<exec_place::impl> exec_place::impl::get_place(size_t idx)
 {
-  EXPECT(idx == 0, "Index out of bounds for scalar exec_place");
+  _CCCL_ASSERT(idx == 0, "Index out of bounds for scalar exec_place");
   return shared_from_this();
 }
 
 inline ::std::shared_ptr<exec_place::impl> exec_place_device::impl::get_place(size_t idx)
 {
-  EXPECT(idx == 0, "Index out of bounds for device exec_place");
+  _CCCL_ASSERT(idx == 0, "Index out of bounds for device exec_place");
   // Static instance - use no-op deleter instead of shared_from_this()
   return ::std::shared_ptr<impl>(this, [](impl*) {});
 }