Skip to content

Turn --extended-lambda on by default for all examples#6635

Open
viralbhadeshiya wants to merge 15 commits intoNVIDIA:mainfrom
viralbhadeshiya:extended_lambda_example
Open

Turn --extended-lambda on by default for all examples#6635
viralbhadeshiya wants to merge 15 commits intoNVIDIA:mainfrom
viralbhadeshiya:extended_lambda_example

Conversation

@viralbhadeshiya
Copy link
Contributor

Description

  • Convert all functor to lambda in examples for thrust, cub and libcudacxx
  • Changed exmaple cmake files to build example with --extended-lambda on by default

closes #6466

Checklist

  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@viralbhadeshiya viralbhadeshiya requested a review from a team as a code owner November 15, 2025 18:38
@github-project-automation github-project-automation bot moved this to Todo in CCCL Nov 15, 2025
@copy-pr-bot
Copy link
Contributor

copy-pr-bot bot commented Nov 15, 2025

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@cccl-authenticator-app cccl-authenticator-app bot moved this from Todo to In Review in CCCL Nov 15, 2025
@viralbhadeshiya viralbhadeshiya marked this pull request as draft November 15, 2025 20:08
@cccl-authenticator-app cccl-authenticator-app bot moved this from In Review to In Progress in CCCL Nov 15, 2025
Copy link
Contributor

@bernhardmgruber bernhardmgruber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking great so far! Thank you so much!

I think you can use structured bindings in more places. I gave you a few examples below among a few other things.

@alliepiper alliepiper marked this pull request as ready for review January 17, 2026 16:34
@cccl-authenticator-app cccl-authenticator-app bot moved this from In Progress to In Review in CCCL Jan 17, 2026
Copy link
Contributor

@alliepiper alliepiper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CMake LGTM -- @bernhardmgruber can you take another look re: your review comments?

@viralbhadeshiya Could you merge main into this branch and resolve the conflicts when you get a chance?

Thanks!

@alliepiper alliepiper requested review from a team and gevtushenko and removed request for a team January 17, 2026 16:38
@bernhardmgruber
Copy link
Contributor

CMake LGTM -- @bernhardmgruber can you take another look re: your review comments?

My above comments have not been addressed yet. @viralbhadeshiya please address them. Thx!

@viralbhadeshiya
Copy link
Contributor Author

Thanks @bernhardmgruber @alliepiper , let me take a look at those changes comment. Will make a change and let you know when I am done.

@alliepiper
Copy link
Contributor

Will make a change and let you know when I am done.

Thanks! I'll mark this as a draft for now. Just click "Ready for Review" when you're ready for us to take another look.

@alliepiper alliepiper marked this pull request as draft January 19, 2026 16:30
@cccl-authenticator-app cccl-authenticator-app bot moved this from In Review to In Progress in CCCL Jan 19, 2026
@viralbhadeshiya
Copy link
Contributor Author

@bernhardmgruber can you take a look at the changes that I pushed for review, lmk if I got those right, or if you want me to change/add anything.

@viralbhadeshiya viralbhadeshiya marked this pull request as ready for review January 22, 2026 04:21
@cccl-authenticator-app cccl-authenticator-app bot moved this from In Progress to In Review in CCCL Jan 22, 2026
@bernhardmgruber
Copy link
Contributor

/ok to test ce4d2ce

@bernhardmgruber
Copy link
Contributor

/ok to test f49ec14

@github-actions

This comment has been minimized.

@viralbhadeshiya
Copy link
Contributor Author

@bernhardmgruber I have no idea, why this is failing, do you have any suggestions where should I take a look to solve this?

@bernhardmgruber
Copy link
Contributor

/ok to test 5750b59

@bernhardmgruber
Copy link
Contributor

@bernhardmgruber I have no idea, why this is failing, do you have any suggestions where should I take a look to solve this?

Seems like another artifact of a stale sccache object after updating Catch2. Let's see if updating the branch helps.

@github-actions
Copy link
Contributor

github-actions bot commented Feb 6, 2026

😬 CI Workflow Results

🟥 Finished in 24m 35s: Pass: 4%/163 | Total: 16h 35m | Max: 24m 17s | Hits: 98%/45250

See results here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: In Review

Development

Successfully merging this pull request may close these issues.

Turn --extended-lambda on by default for all examples

3 participants