Turn --extended-lambda on by default for all examples#6635
Turn --extended-lambda on by default for all examples#6635viralbhadeshiya wants to merge 15 commits intoNVIDIA:mainfrom
Conversation
bernhardmgruber
left a comment
There was a problem hiding this comment.
This is looking great so far! Thank you so much!
I think you can use structured bindings in more places. I gave you a few examples below among a few other things.
alliepiper
left a comment
There was a problem hiding this comment.
CMake LGTM -- @bernhardmgruber can you take another look re: your review comments?
@viralbhadeshiya Could you merge main into this branch and resolve the conflicts when you get a chance?
Thanks!
My above comments have not been addressed yet. @viralbhadeshiya please address them. Thx! |
|
Thanks @bernhardmgruber @alliepiper , let me take a look at those changes comment. Will make a change and let you know when I am done. |
Thanks! I'll mark this as a draft for now. Just click "Ready for Review" when you're ready for us to take another look. |
|
@bernhardmgruber can you take a look at the changes that I pushed for review, lmk if I got those right, or if you want me to change/add anything. |
|
/ok to test ce4d2ce |
|
/ok to test f49ec14 |
This comment has been minimized.
This comment has been minimized.
|
@bernhardmgruber I have no idea, why this is failing, do you have any suggestions where should I take a look to solve this? |
|
/ok to test 5750b59 |
Seems like another artifact of a stale sccache object after updating Catch2. Let's see if updating the branch helps. |
😬 CI Workflow Results🟥 Finished in 24m 35s: Pass: 4%/163 | Total: 16h 35m | Max: 24m 17s | Hits: 98%/45250See results here. |
Description
closes #6466
Checklist